From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AAE83457A1 for ; Mon, 12 Aug 2024 14:53:14 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A58EF402C3; Mon, 12 Aug 2024 14:53:14 +0200 (CEST) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2040.outbound.protection.outlook.com [40.107.244.40]) by mails.dpdk.org (Postfix) with ESMTP id D5A7E4029C for ; Mon, 12 Aug 2024 14:53:13 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=OnB5C5ivnDQ2IFGE1FR+S83UQcqfmlf++wYXqF6+1PUrf5fOdUhIab9H/WLiziDV4DZNkhss4CnfBbNc7ChFrgZsVf1nlXN5XiVsOym6IGZHKJcxeUutCBgA2WM8j5rTEC069fZ5h6aCvpPDKA+vKhHJmaRx4m+lTWd7UfhiL2CzkNrxKNYLmdspX+XpIgNhPD/EL4hH82nmR0tdpQxudQNU4S3ItlQT/tsYGz4XlBoye0iPN7JfwLhfswCgA3bWh9+BP+YOwp+s1KqUEIEk3mD0gEuO3Q8lOe6cBXfuY5JZ0qlmMzfqEpm+QHzC1UYiP3OCboNM8w1doKBYcQF7hQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NILUUWQOosN6mWoMU0bXJqR3P9AyJAsMFFsojAj9GkY=; b=YKeniJHdbFhUTEd4zz4OkUIsIzwYfd8e8Ls9JdqAA73nqJNP9YbhtNieqOKPPnfGkcNpV9Cx4gqPJdMsJQvzQ4mrgHHZm9PxzvL7eWpEYeFl9WrvMwAHkVWH7W9kXw9O17PqICMEDbm/wdl+Loqw32gfQ6b0i++v6YdmbxBKdac1mYDMsqB24vZXJj2I0qfY8DgKHL5IO8kRsATAMspNPrw92FhQQo6/cDsFx3m6B+QBdCon3mbbTy/70ARLECKCRcOHN5EPnEtlFXdtZ5pODJbkSbBp4X5TmkJdfa/3J1W2CjMbdTrR4BvxI2ZILaEV7BWoUkB89gNDbACWI/j7JQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=intel.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NILUUWQOosN6mWoMU0bXJqR3P9AyJAsMFFsojAj9GkY=; b=j5TZcAXVzGKRTz41K0JXEFW8g27K+krK/1+bMFtDChZRdj1AYOaZeDQOIazCF6gHeGoCkrCuvJPQZLjpZ34XmNb5R0ntBKppCNlKiUo63MimFxG4uOPRGKjr8yc1i330gLMGgMVu8LelrG6HHfmXfIklTdFa34HQuz3XUyDLfA50HPBQJkZx73mWt2FQNy18DGSl1vi1lW4w5Xrwyw3XjVOid0DZqGKI1ImdZ912eYEvxy/Jn6bT3u3MGZaVOuco5oN79961FY4B2iVCAek79h6jRA0ara01r5PVFiM0E82QwWBCig6f5OoGzfJvWAn9r9d5JSgalrgVtgtxsfvIuA== Received: from DM6PR08CA0064.namprd08.prod.outlook.com (2603:10b6:5:1e0::38) by SA3PR12MB7975.namprd12.prod.outlook.com (2603:10b6:806:320::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7849.20; Mon, 12 Aug 2024 12:53:10 +0000 Received: from DS1PEPF00017094.namprd03.prod.outlook.com (2603:10b6:5:1e0:cafe::ba) by DM6PR08CA0064.outlook.office365.com (2603:10b6:5:1e0::38) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7849.20 via Frontend Transport; Mon, 12 Aug 2024 12:53:10 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by DS1PEPF00017094.mail.protection.outlook.com (10.167.17.137) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7828.19 via Frontend Transport; Mon, 12 Aug 2024 12:53:10 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Mon, 12 Aug 2024 05:52:59 -0700 Received: from nvidia.com (10.126.230.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Mon, 12 Aug 2024 05:52:57 -0700 From: Xueming Li To: Ganapati Kundapura CC: , Akhil Goyal , dpdk stable Subject: patch 'cryptodev: validate crypto callbacks from next node' has been queued to stable release 23.11.2 Date: Mon, 12 Aug 2024 20:48:20 +0800 Message-ID: <20240812125035.389667-24-xuemingl@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240812125035.389667-1-xuemingl@nvidia.com> References: <20240712110153.309690-23-xuemingl@nvidia.com> <20240812125035.389667-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.230.35] X-ClientProxiedBy: rnnvmail201.nvidia.com (10.129.68.8) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS1PEPF00017094:EE_|SA3PR12MB7975:EE_ X-MS-Office365-Filtering-Correlation-Id: c181d066-8949-4aa0-e788-08dcbacdb86e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|82310400026|376014|36860700013|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?CQaZgOyHvTdc0i9/TMg4dFH/HaNVeL3aefn5rBjc4u6CY3sUWSZrkOGXDNRq?= =?us-ascii?Q?tx/uIFap3Z7+rdEr5jo2vNqBhJdBR3lIbecSXwal3XOxIvcb/TdNJS0m0wUz?= =?us-ascii?Q?3oHNZQaI6QHNyc2xbNXMcxQxYdv8ezmIZkHxjhp320/5HXmgizDizDra5oK0?= =?us-ascii?Q?HWMpjWM06udhs7qbA7bv87trEhEmXFSWeaRrKAuIazCsKiA3eYGGDyhlP4xx?= =?us-ascii?Q?SLjQyJA4ysaa40n6eCXgKIvbmBlEzDX1oCGGq2gXvNGFNnWLgKUf0ZScahrS?= =?us-ascii?Q?mlsxcVvEDE9StlvHq2Aufvv0ym03oavYdByWXQRgwA/gss80ON61SRk0K0aB?= =?us-ascii?Q?43yaDWyQtwn+H4c7Y5xcVVwEQ7bVv0vr/zeVwRrLf3NoRf/QXC1rjSysSLBo?= =?us-ascii?Q?AmKKMZdbdrVvH9WarErGTPZC6hr0dKvtHPE8k13FH4EGvEh/UqEuedV5U2xI?= =?us-ascii?Q?6DXRYw1tWd42bV36QOJGmbsmKP8I7Nvk+k3n5/fDqukizuF8VavWEdUlKv5J?= =?us-ascii?Q?4VdvE532gZ6rgbkNBKB6UB/0h9HfQ6pFxLeVt1r6QfDVLruBKdaOsPIKK3Ey?= =?us-ascii?Q?hzqUVsbt1BeY9WuxVqa3wt1ox652gXHgIHxmhqRJvMUOt1p/cyprf2W32MtO?= =?us-ascii?Q?LkTIPBpFsmwg+Uqb27Rm/nBWqU1VjpiJmyv1ADvhZHKNvh8wGUG4ZWK95AzF?= =?us-ascii?Q?rngZw4izoiyf7i7sd2PBVWXcLemTiBFNNpojr6sB/RNCdqtkNEDYMLvHQq8f?= =?us-ascii?Q?MVRtYOzFcu42QvBdTBshcJK0FxyNKwGogPsElTBIgSA82AqpRSzcdGbB/EjF?= =?us-ascii?Q?wf2sKcDHyHCBtQJKK5Hn2yJVUebCoMynIiYJiJjryM4nAX52ovZb3M9Uiuvi?= =?us-ascii?Q?X43E4kBtFYsfuZBWpwU8KQ3pBRiNdB1IFrTvEMgTfKRidqiqiIVOJPr5UVom?= =?us-ascii?Q?y7A/PA2OHjS69HSm18Urmk1w7Ba+o6IT5gBC9dVBNeA2AxsK/Kn43p2pci6l?= =?us-ascii?Q?wKbiqjPpIp9cIQtl8HaJJkroTKs80M+0mC/OZ7oryCtayq+A+wB515q9Dvlo?= =?us-ascii?Q?oQlCZuRH9OFM+iRJQ48KrdLYeiiS65xnB7Q5OiHGQfad6OF5TYw4oymkU4Cg?= =?us-ascii?Q?VWPaTLl4tTG7utUSxbcc5QHvwRa3weXbguB4LaPn/I/n8/QJKhue1HuRuZmK?= =?us-ascii?Q?n6ttwe76bW5DxIcOMoGdParSwPe0RkhooCL7J8tnuVseo5RZ3p7b8jyGxTuf?= =?us-ascii?Q?1IM8fKHeEFPY9DzW6Yd5qIhArAnon0s/Ws9tm9Nj9rTl/3LZ44jQTv58FuhO?= =?us-ascii?Q?2hy8MkqAX+AqhpjPG/fRDA6BbevDf4iWg1p/zu7caacUU4YjuJUjCOpa6cKG?= =?us-ascii?Q?OyZtFldHLTZ0PFfXpKOxh9j8FZjM03lLOoS55qyMLyRefzgJyx26C8SI9E9m?= =?us-ascii?Q?V9qt4pWWTjDUt+r7LfpwUD3fn7Q6RVhX?= X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230040)(82310400026)(376014)(36860700013)(1800799024); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Aug 2024 12:53:10.3543 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c181d066-8949-4aa0-e788-08dcbacdb86e X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DS1PEPF00017094.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR12MB7975 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 23.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 08/14/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=23.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=23.11-staging&id=9b3e2355812ed4d6fc82b74ceaad30914df0aea2 Thanks. Xueming Li --- >From 9b3e2355812ed4d6fc82b74ceaad30914df0aea2 Mon Sep 17 00:00:00 2001 From: Ganapati Kundapura Date: Thu, 27 Jun 2024 05:06:26 -0500 Subject: [PATCH] cryptodev: validate crypto callbacks from next node Cc: Xueming Li [ upstream commit e858d0c9612211ba43d6703cb7834697214a3fe1 ] Crypto callbacks are invoked on checking from head node which is always valid pointer. This patch checks next node from the head node if callbacks registered before invoking callbacks. Fixes: 1c3ffb95595e ("cryptodev: add enqueue and dequeue callbacks") Signed-off-by: Ganapati Kundapura Acked-by: Akhil Goyal --- lib/cryptodev/rte_cryptodev.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/cryptodev/rte_cryptodev.h b/lib/cryptodev/rte_cryptodev.h index 59c7d69da5..a42a4fc04e 100644 --- a/lib/cryptodev/rte_cryptodev.h +++ b/lib/cryptodev/rte_cryptodev.h @@ -1910,7 +1910,7 @@ rte_cryptodev_dequeue_burst(uint8_t dev_id, uint16_t qp_id, nb_ops = fp_ops->dequeue_burst(qp, ops, nb_ops); #ifdef RTE_CRYPTO_CALLBACKS - if (unlikely(fp_ops->qp.deq_cb != NULL)) { + if (unlikely(fp_ops->qp.deq_cb[qp_id].next != NULL)) { struct rte_cryptodev_cb_rcu *list; struct rte_cryptodev_cb *cb; @@ -1977,7 +1977,7 @@ rte_cryptodev_enqueue_burst(uint8_t dev_id, uint16_t qp_id, fp_ops = &rte_crypto_fp_ops[dev_id]; qp = fp_ops->qp.data[qp_id]; #ifdef RTE_CRYPTO_CALLBACKS - if (unlikely(fp_ops->qp.enq_cb != NULL)) { + if (unlikely(fp_ops->qp.enq_cb[qp_id].next != NULL)) { struct rte_cryptodev_cb_rcu *list; struct rte_cryptodev_cb *cb; -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-08-12 20:44:03.341035734 +0800 +++ 0023-cryptodev-validate-crypto-callbacks-from-next-node.patch 2024-08-12 20:44:01.955069267 +0800 @@ -1 +1 @@ -From e858d0c9612211ba43d6703cb7834697214a3fe1 Mon Sep 17 00:00:00 2001 +From 9b3e2355812ed4d6fc82b74ceaad30914df0aea2 Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit e858d0c9612211ba43d6703cb7834697214a3fe1 ] @@ -13 +15,0 @@ -Cc: stable@dpdk.org @@ -22 +24 @@ -index c946f747fc..bec947f6d5 100644 +index 59c7d69da5..a42a4fc04e 100644