From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 17F54457A1 for ; Mon, 12 Aug 2024 14:53:20 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 128D1402C3; Mon, 12 Aug 2024 14:53:20 +0200 (CEST) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2087.outbound.protection.outlook.com [40.107.223.87]) by mails.dpdk.org (Postfix) with ESMTP id 9D0E54029C for ; Mon, 12 Aug 2024 14:53:18 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=yjzTiq/Sv30bDX5z2zyyTMwgQUlrZrHPsT7JweL4E+bTSdbR8WObCOoB6K8HB6QowoVNrZBhxDXmIkHce0wUVmokYigfdHxfu2esHH2JNOSV8MTOaSrUvlCPbWF3h5QaHzsiboY+guFg7XvE3phlEFZ0RvZgSCTSlu4nBEVYGw+bjXXfcenEEdGvoYhXpw69Fa55iyIVTSU7ujzVqANJz//JO9847Qwiv6A/Zow+FLKY6hme4mPOu/0N6WcJ+f4h5k8aFLWISviKeKAIqEyemwq42goTqAsOS3qFcLhf4B5xct58knALHnoo1J0a2GAFS05ZEqrV5M6PaO5sE4HQ8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ouEwAXjyfK66+KgcuGTjVYfKH4WeLWAx2R9xJmwF7kA=; b=wYCpnHkypldGd1fyfBMjVDagXqMMjNMs8Wz3TXzoAayBPOEuNaq01Q8UIGirJfEVPUgSwQGbsYkPc1V5Lkw74Ke/ZJ5SK2gfLbDkVMxZzI2OfuAVnX4goA67QYVjA/qlB8a4NTSYWVhYwz62SRKkH2JqrIioWIqypEX2bNbW+HdWPCzjNTKmHIHyrPlFQ5eQihxno5BIEo3gsK63F7Re5iO7bZvxCutlaNUEJi2tLn1tiyybRLk8Eid943mR201vpFHXou0f2ImtyA85kSesv33C1xaR0KO9hAalwUNeNFfqUMAM+atVJCOiiwLU2DfnXb7YDohkiS4c2Cft8HIoig== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=marvell.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ouEwAXjyfK66+KgcuGTjVYfKH4WeLWAx2R9xJmwF7kA=; b=uLEjpzrQBqaJP/QkwD85QZzYj10WQQ6iIOGStslF9WZWrAcbStJVcl1KPtJlGqnIsAP/rxlkgdUoxG5vkQ8vEJ5SXo+E6Wrmhuu8Q7mP772gTH2N4qC06Xst70tupNCrbP5FJ/kPSmBY84w0+buDxViVaxOUHforCPuVcKdlefm2JBHckmz4l3/16V3URgWDNzwGXCcykwKafu0ShXK5JFqGEWK1qngWVtHZCC/uTMC39n+dnj6IOXWYbZCVjHKb8X/4el1r0jmj8NdrdDobc0elPGAnkHz9L+fXQQqVASDTPwMD9cB1DA1F/FM6cFZewqZZ3HEye3AdFca5wGrAVQ== Received: from SN6PR04CA0079.namprd04.prod.outlook.com (2603:10b6:805:f2::20) by SN7PR12MB7153.namprd12.prod.outlook.com (2603:10b6:806:2a4::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7849.20; Mon, 12 Aug 2024 12:53:12 +0000 Received: from SA2PEPF00003F63.namprd04.prod.outlook.com (2603:10b6:805:f2:cafe::3d) by SN6PR04CA0079.outlook.office365.com (2603:10b6:805:f2::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7849.22 via Frontend Transport; Mon, 12 Aug 2024 12:53:12 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by SA2PEPF00003F63.mail.protection.outlook.com (10.167.248.38) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7849.8 via Frontend Transport; Mon, 12 Aug 2024 12:53:12 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Mon, 12 Aug 2024 05:53:01 -0700 Received: from nvidia.com (10.126.230.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Mon, 12 Aug 2024 05:52:59 -0700 From: Xueming Li To: Gowrishankar Muthukrishnan CC: , Brian Dooley , dpdk stable Subject: patch 'examples/fips_validation: fix dereference and out-of-bound' has been queued to stable release 23.11.2 Date: Mon, 12 Aug 2024 20:48:21 +0800 Message-ID: <20240812125035.389667-25-xuemingl@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240812125035.389667-1-xuemingl@nvidia.com> References: <20240712110153.309690-23-xuemingl@nvidia.com> <20240812125035.389667-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.230.35] X-ClientProxiedBy: rnnvmail201.nvidia.com (10.129.68.8) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SA2PEPF00003F63:EE_|SN7PR12MB7153:EE_ X-MS-Office365-Filtering-Correlation-Id: 2cf9b938-e7d7-4a45-17a6-08dcbacdb99b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|36860700013|376014|82310400026|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?Kmx3MGeK25yxzAGgFx2yt6119t5yBQHTsm6uFSFB6m2NZktzq9MRyBstrL9d?= =?us-ascii?Q?H0c9yqC/Cdpt8d5ajIv6KhR19PxJbbT3f/9HVj9ucApC1FcDxyyM51mSpz6N?= =?us-ascii?Q?FsjRRbcjx8qibHyNa1wq7QBwe2fgcqDnyq95R/lkoTg5EojU3p6G5DKl3DlF?= =?us-ascii?Q?6acGwei5DHXn2X4QMkH1YI9uvIDbhtFz9h1bNTOk0YOSCmoH3vRhs15Py3J8?= =?us-ascii?Q?q3LcUnjCGNOTVlc+aI/sPyx1MhYR1xSftbSuJoSr6inBIxIUeXl8tBZ0JIOp?= =?us-ascii?Q?aHCXwTVOWCJOLY/BMjyNMKxrnQgd9zwNVuoCavoMbs6ApCGQMFDZtC7uDUHv?= =?us-ascii?Q?ltckUbPgJwRwy60jf/8YKQS7LyX4bwxCwZjxrMRCnzsFxWUpx3nmX2Fj0Exe?= =?us-ascii?Q?VptNknladVSQwTKtWvCv8g9LAcgpzCJGIxjzvCax8g/OsKG11j7IpriAqkxX?= =?us-ascii?Q?5mLOxB2xoFh9BNiNFlWNl+A+UdMGwRKTjs8Luw/sRZpqf3j3TVYkQO+Ghen7?= =?us-ascii?Q?ut5go1OCEYsXT8ie7bCSD4OvmyZvycwXLUXhRWksyVR3FrFhY+bcwwlmwpts?= =?us-ascii?Q?2IJ6tz+Tto9xwFxjhOFOJFRn0mGV9nVR85YA+EzmhcyiFx5yr+u8zkEVBW40?= =?us-ascii?Q?ULqm6eN6/hI7yW1wx5kJ88SxSEhJ0DdcScpfLi6d/EiCWeRlByOomTE8SxIw?= =?us-ascii?Q?xJ6H+Jtq3JpRQ9zLmr8oIuAZN2DJ+HOXC/+epXf+43Mr0Fs7fiJwMa+UsNna?= =?us-ascii?Q?rhqjxk3lhGXyHnvyJv18Tmtg9+R96d7tqbgPMwZkRmVxSnVM40Ka3ICqRjY0?= =?us-ascii?Q?d/7SW3WC9aYyXxXDtnCHIWS9fIe1IPehhhysKAmR2CtNHZUXpgQGGhOhIifj?= =?us-ascii?Q?Iip7DD51fNT1AvukGnmmnsEE3rrMzAeqqODz2+/JyqExPQunSbDHff60oRKb?= =?us-ascii?Q?Wcph91U9Lc7ntDaqLrkrEI7XrUIEbWE9SwCSwddQ4JziyNG8CHHUw4mn0sPk?= =?us-ascii?Q?YE3Y5VTcHLzamStbQhXtSHNQ0DFuYLiON1n4xgdp8iEK3/azaBSc/rFN9Pzb?= =?us-ascii?Q?sFvoS4Fq1Xo0d9uKORw0NVFvhSBsAW7VDwGwuhkEPXQYBrsL18gP2VYjvr+M?= =?us-ascii?Q?2yD1RG8Bng6nkgwOQugX33i3jJ+ek3VVbE2s/tfPCycI81L5droS3VUPF1xE?= =?us-ascii?Q?pzhV3/NITu3JpqjTIUeZBLZtGw5pRYXQxscPBy0+ay+k0tS1waZS2cAT3Aj6?= =?us-ascii?Q?1PzGBOAnoGSgm7b2qajCjNTzg0MiuDQFEHhWHTPCWSm8c3+lBlpA00wMgrqa?= =?us-ascii?Q?uuEfA0D4v7Z+6eGeRKqzVa+sKBOhSMpctNfY+HudbFgjOptunnbTxDWXK1kd?= =?us-ascii?Q?0s187hqUk8z8lJpcvIpvfoZ9frt/i9OBUoaWM/faR7fMXO0IAZXZLds+ZZ1J?= =?us-ascii?Q?COAJ/ya67yNZFBrn0kkJk6JydbIq//UH?= X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230040)(36860700013)(376014)(82310400026)(1800799024); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Aug 2024 12:53:12.3372 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2cf9b938-e7d7-4a45-17a6-08dcbacdb99b X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: SA2PEPF00003F63.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB7153 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 23.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 08/14/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=23.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=23.11-staging&id=cc8ca588a08bc581d8f456794a5a66f584e66c0f Thanks. Xueming Li --- >From cc8ca588a08bc581d8f456794a5a66f584e66c0f Mon Sep 17 00:00:00 2001 From: Gowrishankar Muthukrishnan Date: Wed, 26 Jun 2024 15:56:23 +0530 Subject: [PATCH] examples/fips_validation: fix dereference and out-of-bound Cc: Xueming Li [ upstream commit 57c10aaf3880fac5b2d0e1ddcfd8645e22b9f83c ] Fix NULL dereference, out-of-bound, bad bit shift issues reported by coverity scan. Coverity issue: 384440, 384435, 384433, 384429 Fixes: 36128a67c27e ("examples/fips_validation: add asymmetric validation") Signed-off-by: Gowrishankar Muthukrishnan Acked-by: Brian Dooley --- examples/fips_validation/fips_validation_rsa.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/examples/fips_validation/fips_validation_rsa.c b/examples/fips_validation/fips_validation_rsa.c index f675b51051..55f81860a0 100644 --- a/examples/fips_validation/fips_validation_rsa.c +++ b/examples/fips_validation/fips_validation_rsa.c @@ -328,6 +328,9 @@ parse_test_rsa_json_interim_writeback(struct fips_val *val) if (prepare_vec_rsa() < 0) return -1; + if (!vec.rsa.e.val) + return -1; + writeback_hex_str("", info.one_line_text, &vec.rsa.n); obj = json_string(info.one_line_text); json_object_set_new(json_info.json_write_group, "n", obj); @@ -474,7 +477,7 @@ fips_test_randomize_message(struct fips_val *msg, struct fips_val *rand) uint16_t rv_len; if (!msg->val || !rand->val || rand->len > RV_BUF_LEN - || msg->len > FIPS_TEST_JSON_BUF_LEN) + || msg->len > (FIPS_TEST_JSON_BUF_LEN - 1)) return -EINVAL; memset(rv, 0, sizeof(rv)); @@ -503,7 +506,7 @@ fips_test_randomize_message(struct fips_val *msg, struct fips_val *rand) m[i + j] ^= rv[j]; m[i + j] = ((uint8_t *)&rv_bitlen)[0]; - m[i + j + 1] = (((uint8_t *)&rv_bitlen)[1] >> 8) & 0xFF; + m[i + j + 1] = ((uint8_t *)&rv_bitlen)[1]; rte_free(msg->val); msg->len = (rv_bitlen + m_bitlen + 16) / 8; -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-08-12 20:44:03.368304032 +0800 +++ 0024-examples-fips_validation-fix-dereference-and-out-of-.patch 2024-08-12 20:44:01.955069267 +0800 @@ -1 +1 @@ -From 57c10aaf3880fac5b2d0e1ddcfd8645e22b9f83c Mon Sep 17 00:00:00 2001 +From cc8ca588a08bc581d8f456794a5a66f584e66c0f Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit 57c10aaf3880fac5b2d0e1ddcfd8645e22b9f83c ] @@ -11 +13,0 @@ -Cc: stable@dpdk.org