From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6E379457A1 for ; Mon, 12 Aug 2024 14:55:06 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6A78E40674; Mon, 12 Aug 2024 14:55:06 +0200 (CEST) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2040.outbound.protection.outlook.com [40.107.223.40]) by mails.dpdk.org (Postfix) with ESMTP id CD28F402C3 for ; Mon, 12 Aug 2024 14:55:04 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=aP3r/fx8f9Momq5bPZLIVLKnbeBjNuBiQlkZ0fQGjYiz0dLKOFhkaAPizGIRF9IuSpZDX5geroWbhYFkVKaHcjXXpKXe4LUIcB7cJOxMLPaODL9VXyxV6mH07ycZiVdpWOJgoupxFoT0yw7X1x3H0v0HPTuvmvba0OQX6gUi58Z/yQzJ67nklZ+sDcvwsANZSnV24wq+MRNQS9CqxXUXDi7SpT2NHC17gIhhTIrW9B8av7N1blRWGwy/FyeRwxKb5Ktd01bITtgwjfXh5UMjHh8c6zbBMGOwgukePUb/7z3Ebo9eY2HHzYWLTGEjuiUi/eio6SXcq9ji1Do/NgnwdQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=f90uMSkG2kOm/qnmEZiRjMR0Ci4NSVr4ca3+TWycu+c=; b=SlEO67/F3SCMJUkMYX8PgxXfN9LjkNkabU+sTIY4/cqmwPUUeo/n5CudCNoJpoxhVoAQkdpXIs6317Xd522MzkZtAi284ey5FGgyRx6G3o9snLEZgmu3gMXrBv/GbJn6pi+abtjgRfUDx5mJUH4+mzrp0ZM9aCmxWPPeopKvBPARsLof3LRMxt0Q5Jk6ip4BmgKQl2YaI7Vyu5Zrgdr39z78dYhiGZkHiE68d3CtSq8ZtnPwJQ9KDHDPtC5Fu3NQrGDMZcsE12bKApdnToee1boifzT8Y0MpnIquG4pBNFPfQXmg21QiJJbFtZfWH3K5gou3ApYvlJm1hIGgab8NFg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=nxp.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=f90uMSkG2kOm/qnmEZiRjMR0Ci4NSVr4ca3+TWycu+c=; b=GbOeFve7PdWGBygCxBzXAPU6hiUqzRR+I5P2pw/tNcSqpyCDLuAYHpFoRqYe2pGtzzjvFvBau12N6CHYE8UZcGW5aJ0gKpLPrZtazedrz14pfCCw3+i45sMBQt3zJ1Qz+yo5cPMA80ymJ1x+07GDmzq9Es1+AbIG/TsgBrAyifVPbluORSGu/a68UIf5sLjlAr7sUiGM942W/1cjuO5+i2htHTyT9kEpwqZ+soGY4rnGkQKPQLj7PAgT5xaU402bsJ+k1F1+q3EFZ98g8FKsJnTQae+/sKV+Pph8EyD0TwDXJYizoc0MbHFLlwuJ9/Os5KRSGkaf/wE3XErHu0XeVg== Received: from SN7P220CA0013.NAMP220.PROD.OUTLOOK.COM (2603:10b6:806:123::18) by PH7PR12MB9150.namprd12.prod.outlook.com (2603:10b6:510:2eb::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7849.20; Mon, 12 Aug 2024 12:55:02 +0000 Received: from SA2PEPF00003F67.namprd04.prod.outlook.com (2603:10b6:806:123:cafe::95) by SN7P220CA0013.outlook.office365.com (2603:10b6:806:123::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7849.22 via Frontend Transport; Mon, 12 Aug 2024 12:55:01 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by SA2PEPF00003F67.mail.protection.outlook.com (10.167.248.42) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7849.8 via Frontend Transport; Mon, 12 Aug 2024 12:55:01 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Mon, 12 Aug 2024 05:54:50 -0700 Received: from nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Mon, 12 Aug 2024 05:54:48 -0700 From: Xueming Li To: Apeksha Gupta CC: , Vanshika Shukla , "dpdk stable" Subject: patch 'bus/dpaa: fix memory leak in bus scan' has been queued to stable release 23.11.2 Date: Mon, 12 Aug 2024 20:48:40 +0800 Message-ID: <20240812125035.389667-44-xuemingl@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240812125035.389667-1-xuemingl@nvidia.com> References: <20240712110153.309690-23-xuemingl@nvidia.com> <20240812125035.389667-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.231.35] X-ClientProxiedBy: rnnvmail201.nvidia.com (10.129.68.8) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SA2PEPF00003F67:EE_|PH7PR12MB9150:EE_ X-MS-Office365-Filtering-Correlation-Id: 364969bc-b8d0-4f7d-206c-08dcbacdfac5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|376014|1800799024|82310400026|36860700013; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?RmOrQtchNwXgLvZ4EcibyfQlEVt/z+sQIW6CrPAcozMPdklCAyMBTH0V0J31?= =?us-ascii?Q?h8dzW3QVBUfwWMOzNSmdB6EPAMCiOjARGmf2SjmWwzDt6XS2fpNgDpqXuOOl?= =?us-ascii?Q?m4//5U1kNqIx2p+V+YLXihwcTDJG/h2wlIFzaXuR/6Bx3JsjWoV62zFluCCJ?= =?us-ascii?Q?M4zenmG5O464KpIrGrGCp5aF5uCYLJh4qdxnt+6SEgmVoBXF4Fc1Xz4F9VLq?= =?us-ascii?Q?BU1E/j3u5YERHxP/STgwO3TnNCB0fpFz2v7+icudSS2/F14Isv18igcwpKcH?= =?us-ascii?Q?TgMtLBXe79zaSsjoTlFf2Y9/tA6ohowPcMOaKSQgntUy5B3jTaRmyLhKZaHC?= =?us-ascii?Q?xtVnmCWpjLd8hI7zwScj+p05K2mLm4ybYMBSPgcVCS6mkfsOyy/jfPVuCP3i?= =?us-ascii?Q?FGFY0nhoM2P98mNdJ2VhJtRQJLMvlonSR/JMByGbVBmoyJmFiOXewOZX8Xto?= =?us-ascii?Q?BUIG7yBXqNyzKLXonyRGHtCMq4cQj4KsCQTrQ1Tjd+ALGoj6zwGmHolWpElC?= =?us-ascii?Q?wG4n8B11/85dfeaoxgO7UnRG2i5xoPzfg9tb93Xeu55QNjsjmRd79d4Zd6IH?= =?us-ascii?Q?yWhN77G1Ye9by/CUyD2gmRblHVYubl1MJaEvhVLofsz4Q0q06NjXfBbqI3ON?= =?us-ascii?Q?0cwM+7PUCz2Xyd7JATuVbRIhpqd2at+Bvoz+t5Lnfi7IyK0CbozNp2cI9/SF?= =?us-ascii?Q?nU0ZEEb6sBx+pefBp1/Fdy1TvxtTKe9gwWFLBCSrpxkM2akMCm6PV6OnRxlW?= =?us-ascii?Q?+bHWhf8qHB5rXhZgbiDYdJQOmbFJORMjJTQ/ikNYSnKgn/XqIkdjNbjFZVBL?= =?us-ascii?Q?56ksmBEHKtGK6yna5WYF4gbhndNUq7jopTg+VAGOdnO5SR19YEGMlSUFMBjb?= =?us-ascii?Q?7oxXD10xRYJwxw0Tw7v9voVbGkcxep8BUmfSNO6DF9/szQFiudo2zqjjWCc0?= =?us-ascii?Q?KpE3yjqb6DIyUIPh8ME2ovIFPz2A+64rt1z+2zVFt0WlGEUFsPvTyW06r0J5?= =?us-ascii?Q?jTveypYz/i8E51cbBPiXeyTreWEG9oWnspnjMnaIyW36idNUQCeB2OwSqRKe?= =?us-ascii?Q?0bpRvicwVMTeOxIGaRqUYNQ5Dz5Jc0SfuJbWtCEuiZr0HUn+PYzhc+Jg6ccU?= =?us-ascii?Q?EIh4OaYBtcwKOP5jJZ4feQ+TkFqsI+2+Xwyg3O/RCM1MNjrdkj/UoBnJact1?= =?us-ascii?Q?iTP26wRCYcGnYQ0+NSl+k3jZrD6yVqndIKrepR6yPXc0shgk5g8jGhE2BwI1?= =?us-ascii?Q?cjMNO8j7z+rEvqpZnEE9kt1I9vkc7r/aqozwy0LpP3gHIWgc++14DkZHOrcF?= =?us-ascii?Q?CtNOPd0dLqJBpT8T4Z365jBqRDjHmuD4AySAxKlrggmyy3AzpYrNUuGJSuvH?= =?us-ascii?Q?JMntUNQIju0D653qVO71xXhnwpWTw5tIDFtOvcSLm9YH/MHSPeFlWP+N8QBW?= =?us-ascii?Q?VocjaZ4Z5JCxX63oYzla8sGpaziQ13Z4?= X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230040)(376014)(1800799024)(82310400026)(36860700013); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Aug 2024 12:55:01.6490 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 364969bc-b8d0-4f7d-206c-08dcbacdfac5 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: SA2PEPF00003F67.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB9150 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 23.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 08/14/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=23.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=23.11-staging&id=0b4bc3a5d1d1c981a2fb2a7de19f05e434036566 Thanks. Xueming Li --- >From 0b4bc3a5d1d1c981a2fb2a7de19f05e434036566 Mon Sep 17 00:00:00 2001 From: Apeksha Gupta Date: Wed, 10 Jul 2024 14:25:28 +0530 Subject: [PATCH] bus/dpaa: fix memory leak in bus scan Cc: Xueming Li [ upstream commit de0833ffe31739fd40789b1580025bc849d8871f ] Resource leak: variable dev is going out of scope leaks the storage. Coverity issue: 373703 Fixes: d61138d4f0e2 ("drivers: remove direct access to interrupt handle") Signed-off-by: Apeksha Gupta Signed-off-by: Vanshika Shukla --- drivers/bus/dpaa/dpaa_bus.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/bus/dpaa/dpaa_bus.c b/drivers/bus/dpaa/dpaa_bus.c index 0823553398..aaf2a5f43e 100644 --- a/drivers/bus/dpaa/dpaa_bus.c +++ b/drivers/bus/dpaa/dpaa_bus.c @@ -187,6 +187,7 @@ dpaa_create_device_list(void) if (dev->intr_handle == NULL) { DPAA_BUS_LOG(ERR, "Failed to allocate intr handle"); ret = -ENOMEM; + free(dev); goto cleanup; } @@ -238,6 +239,7 @@ dpaa_create_device_list(void) if (dev->intr_handle == NULL) { DPAA_BUS_LOG(ERR, "Failed to allocate intr handle"); ret = -ENOMEM; + free(dev); goto cleanup; } -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-08-12 20:44:03.880520291 +0800 +++ 0043-bus-dpaa-fix-memory-leak-in-bus-scan.patch 2024-08-12 20:44:02.025069281 +0800 @@ -1 +1 @@ -From de0833ffe31739fd40789b1580025bc849d8871f Mon Sep 17 00:00:00 2001 +From 0b4bc3a5d1d1c981a2fb2a7de19f05e434036566 Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit de0833ffe31739fd40789b1580025bc849d8871f ] @@ -11 +13,0 @@ -Cc: stable@dpdk.org @@ -20 +22 @@ -index b8f41ec069..1f6997c77e 100644 +index 0823553398..aaf2a5f43e 100644 @@ -23 +25 @@ -@@ -188,6 +188,7 @@ dpaa_create_device_list(void) +@@ -187,6 +187,7 @@ dpaa_create_device_list(void) @@ -31 +33 @@ -@@ -239,6 +240,7 @@ dpaa_create_device_list(void) +@@ -238,6 +239,7 @@ dpaa_create_device_list(void)