From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A2F22457A1 for ; Mon, 12 Aug 2024 14:55:27 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 97C45402C3; Mon, 12 Aug 2024 14:55:27 +0200 (CEST) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2077.outbound.protection.outlook.com [40.107.223.77]) by mails.dpdk.org (Postfix) with ESMTP id B52E54029C for ; Mon, 12 Aug 2024 14:55:26 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=vvKkNVZ12vVedlOJiTUX0k577UA++oGSbrAkFXvLxXvbg8gx3ysb4vGD9FbAQHX7raDkXgToJD/CRKvN/yrcChbCm1JmdzrNstry/ZpJDNkBtaho7Uq5kbPxrBB+dP6pACFuQ3hVPIxNB1xiDrylZVORbCqX/an8oMS/pu/TxvVEVDCHJKXMNHx4xO0HPTGrSIzCx3XjEY+KL2QYImBOybl8N4eftuXR8MUjm9AxDfwFn45BM/1OVYnj2Oxj+U+n2XYuN9w2SbUgzKKDQQ0IATAnrQQwye7n2vXv8xpUrenIXA2LRV8VgbGCU8jlOj1IXjrzfVj7o29lpjPlJYqgbQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VY2J+WPSvXusB2I0j5AarVY6WY9HLWQNxAZ3PkZ31QE=; b=KqIcButDPOtZlSgzKTRtG69P9zAEnC93bPe+EHK7NDFalfvVylwEx7QUk4fz5z1bcQgITzlaGVCcsXyFSJZKzOpSwevTfmaagQgdYy3T4vJDpENR7fkKa8UzEnavN1DWXVZZjFdd46DhDWr+ff9lcMJwcUkvCapmynyiCTnYB3GFF5Sjk/cSTr3GoEC7Plb4manpX4DZ2FJAOu0ZpoYQh1d78ebIo00QnZrtUJzmYp4gz+KkoQn9huuwZRIHWp4CvjvXoSxVn+rrn4l/j2WTDm0K2a94u42GF44rGlTThnur2Z7JrT6rsQowL6Q7qAdS/UiUpXyQRbW8EWjD4Acing== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=nxp.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VY2J+WPSvXusB2I0j5AarVY6WY9HLWQNxAZ3PkZ31QE=; b=BJDuALoACH6hTK5I4smBcgk3jmPZtsMgfSpJNeAkIPuuejpr999KKxOL+YjgcqfRjwnHl72ypPavR2L5uqopxsG4wJavlzM8fVctBT0vq3gvH5KmGWSyK+i95AqIYrJECYduD9A/E1CW2q7GRqfGf7Fro02g+LEWcy9j4PjhWPGmr0Fp38M6kdhLZKS34EUpujZ9+Iww0ggzycogZvN9ZIf8cFUJufbBQTbeiYwYt/Hp/ju6Zm9wCbXMl4RvTUJLJ+VjNNS7F4SH9IUogUIl3eFDuXhJRUnBf8WP2zlwVOFHTLaI8QsA9/Krd+2PMeKv1f4KVe5eSI7ZWMONUXIO4g== Received: from DM5PR07CA0093.namprd07.prod.outlook.com (2603:10b6:4:ae::22) by PH0PR12MB7486.namprd12.prod.outlook.com (2603:10b6:510:1e9::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7849.22; Mon, 12 Aug 2024 12:55:23 +0000 Received: from DS1PEPF0001708E.namprd03.prod.outlook.com (2603:10b6:4:ae:cafe::6) by DM5PR07CA0093.outlook.office365.com (2603:10b6:4:ae::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7849.22 via Frontend Transport; Mon, 12 Aug 2024 12:55:23 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by DS1PEPF0001708E.mail.protection.outlook.com (10.167.17.134) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7828.19 via Frontend Transport; Mon, 12 Aug 2024 12:55:23 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Mon, 12 Aug 2024 05:55:14 -0700 Received: from nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Mon, 12 Aug 2024 05:55:12 -0700 From: Xueming Li To: Rohit Raj CC: , Vanshika Shukla , "dpdk stable" Subject: patch 'bus/dpaa: remove redundant file descriptor check' has been queued to stable release 23.11.2 Date: Mon, 12 Aug 2024 20:48:43 +0800 Message-ID: <20240812125035.389667-47-xuemingl@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240812125035.389667-1-xuemingl@nvidia.com> References: <20240712110153.309690-23-xuemingl@nvidia.com> <20240812125035.389667-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.231.35] X-ClientProxiedBy: rnnvmail201.nvidia.com (10.129.68.8) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS1PEPF0001708E:EE_|PH0PR12MB7486:EE_ X-MS-Office365-Filtering-Correlation-Id: a81ebb91-4fff-4fe9-fc1d-08dcbace07c4 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|376014|36860700013|82310400026|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?DrPnaj+/aO/hi39bmVErD+A1KF+EDwxTsziDb5IvsMLx2sfnVxiDBlCF4sL4?= =?us-ascii?Q?+Nr2Z6RYdrpPxKWiJybLOKpoUQCb9hEe0bCDOR6TkJf0RBf7yEXhmbR5ie2V?= =?us-ascii?Q?qfF1jYJrYMMVKx98crdS/kdziFrfswtPb1ZxVB51KTrGzdwHrpMfe1vSCUd/?= =?us-ascii?Q?snECPgbjBSd2sca5owzI1Xridk4YCf8/j2bOcbv5kXewtch9at1pvyAXPLjb?= =?us-ascii?Q?gGPwMKYsTfyxX1LNQxDtJ3iPicp482aKhpQBN1n/IeaW7al7xMqIHt0uBVgY?= =?us-ascii?Q?NTdDOuMlB36O1gNpV34vkKmJepezlemhcirD66an7fAVlHTRdCptbUPWTIRw?= =?us-ascii?Q?FdoePHphfCzQKtw7783vDH3jR7dYgJzU/jEgksJPdhqrdaeCFazQzYT2/WrB?= =?us-ascii?Q?rddoLAm05cREr1VVRIx79JHIBolB399wP42h/Oyp8cVdFjfy71pEGGtm+101?= =?us-ascii?Q?TtZqEOCVQl5bZipFP3VUmH6K+RFF5li1LEWsJsYAjMQp+ee/j3lxT/Eo8n0o?= =?us-ascii?Q?B5GAcz1APFUBNZMlYxBu95JivK8ILbjU5EWKvUzn3zG5+AShskh0UmOUZYen?= =?us-ascii?Q?dEG8kLbQAsxNnoS0N2mPtXZYJlTMuwBbv06mL1g92MS1IEtWhHHP36960enK?= =?us-ascii?Q?jDgT9S5RcWgWKOetaQxwdonLtdIwzDh3jEF5GAIg4aZ6LzersljbYmJBU8y2?= =?us-ascii?Q?MqLtJUhUaNR8lNcGmkpk7qoui1e4gotvkcWrF/U94xmDGjFxeVH0oCk0kjhc?= =?us-ascii?Q?GJf5tNNcQ+zXlRDbZHAp1CCABlRlpiJztC5/2VaDb/h4GFdLpTOWrwdHLFHv?= =?us-ascii?Q?JOAlIT1zpyjWYYR0ZJUMNu16tiD6ON6lj4yvqElbo6gVcrxFc+xhvaPD/IhR?= =?us-ascii?Q?BculQESDCn6R4C5tRkrmMGzhi19KVipB0FNvKr3ew1bYF9DFOOTP90HxKsE1?= =?us-ascii?Q?EIGASNY5JDFKDsRhAw3n/U28zcJOr21dRBC/LZRwvor4xqgqwZzG+Ba77X4a?= =?us-ascii?Q?DdyfzO+cIBjQN4OxJu1PQFpYA71l+DzdoI5sxEERuzRABse2cl4Du2YfqBHM?= =?us-ascii?Q?7f/KYd/VppfvNV/V7Lz3aChTccAhlSz9CJM0YZ3lE1Z3MwBNDqGjfFLsXoJv?= =?us-ascii?Q?GYZhWVuUW3sYpk+0NRl6+1gbzK/cHEV7kTDlv9SOZJTUBrxQz2KGCmn11JAp?= =?us-ascii?Q?xsPw+KkJDYi/bnH06eQiCdM1V7ZucpREEQouGDECYy7cBsv3NL0VFy0QfmS9?= =?us-ascii?Q?icOEk+QTZzWqDfieCKAm+AaKSrc0u/P+Qfx5d7fQdsknNCNOAe6CzzP09BDz?= =?us-ascii?Q?2Pu/uPAEMJ/WEPnKD7PzR/iJLkWS4IVAVeTWhHuPng1Nd2wvMQJbuXRmPP/k?= =?us-ascii?Q?47HopwtK1WOq3hjf+TLu/oHYuiYSe8gXdcl+inHeTVt6dlNq32CQMLAn88r6?= =?us-ascii?Q?ui/HDIql/fewOAgtqxnPfolkKRbGGT91?= X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230040)(376014)(36860700013)(82310400026)(1800799024); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Aug 2024 12:55:23.4740 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a81ebb91-4fff-4fe9-fc1d-08dcbace07c4 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DS1PEPF0001708E.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR12MB7486 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 23.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 08/14/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=23.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=23.11-staging&id=d21248db895951d5efbbb77c5ca0d936fed30675 Thanks. Xueming Li --- >From d21248db895951d5efbbb77c5ca0d936fed30675 Mon Sep 17 00:00:00 2001 From: Rohit Raj Date: Wed, 10 Jul 2024 14:25:31 +0530 Subject: [PATCH] bus/dpaa: remove redundant file descriptor check Cc: Xueming Li [ upstream commit 0ca2093f6b3608467bebe9caf27ce98671fb3381 ] This patch removes the redundant file descriptor check. Coverity issue: 425715 Fixes: 2f3d633aa593 ("common/dpaax: add library for PA/VA translation table") Signed-off-by: Rohit Raj Signed-off-by: Vanshika Shukla --- drivers/bus/dpaa/base/qbman/process.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/bus/dpaa/base/qbman/process.c b/drivers/bus/dpaa/base/qbman/process.c index 3504ec97db..3e4622f606 100644 --- a/drivers/bus/dpaa/base/qbman/process.c +++ b/drivers/bus/dpaa/base/qbman/process.c @@ -1,7 +1,7 @@ /* SPDX-License-Identifier: (BSD-3-Clause OR GPL-2.0) * * Copyright 2011-2016 Freescale Semiconductor Inc. - * Copyright 2017,2020 NXP + * Copyright 2017,2020,2022,2024 NXP * */ #include @@ -27,15 +27,16 @@ static int check_fd(void) { int ret; - if (fd >= 0) - return 0; ret = pthread_mutex_lock(&fd_init_lock); assert(!ret); + /* check again with the lock held */ if (fd < 0) fd = open(PROCESS_PATH, O_RDWR); + ret = pthread_mutex_unlock(&fd_init_lock); assert(!ret); + return (fd >= 0) ? 0 : -ENODEV; } -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-08-12 20:44:04.043643478 +0800 +++ 0046-bus-dpaa-remove-redundant-file-descriptor-check.patch 2024-08-12 20:44:02.025069281 +0800 @@ -1 +1 @@ -From 0ca2093f6b3608467bebe9caf27ce98671fb3381 Mon Sep 17 00:00:00 2001 +From d21248db895951d5efbbb77c5ca0d936fed30675 Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit 0ca2093f6b3608467bebe9caf27ce98671fb3381 ] @@ -10 +12,0 @@ -Cc: stable@dpdk.org @@ -19 +21 @@ -index 59e0d641ce..2d805c5bd9 100644 +index 3504ec97db..3e4622f606 100644 @@ -31 +33 @@ -@@ -28,15 +28,16 @@ static int check_fd(void) +@@ -27,15 +27,16 @@ static int check_fd(void)