From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D4BE7457A1 for ; Mon, 12 Aug 2024 14:56:06 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CC69340668; Mon, 12 Aug 2024 14:56:06 +0200 (CEST) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2065.outbound.protection.outlook.com [40.107.220.65]) by mails.dpdk.org (Postfix) with ESMTP id CE07C40676 for ; Mon, 12 Aug 2024 14:56:04 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=AIEQvKkq6tcqfb53TMP780waqQToPTTyCQQCMohn/tGT6bCO8sCFweZex9Cw5wSE9peHAehohAfOnSzt3fdQlcBGJzIakOwJxjJHhrlq3snJs3DCiPdxrxHHC70mLmLgNTY+g/kyUSgzg/ejMwXDdzWoVAS5zgv4VnUO9I81Kh6mT4xXMLpC+DxJTSGptNXvc0wGDkvMNC1rtRjB74TfJa2AQeFo4I5oaCQD0azdNomc8p/ga0AOSBToQLjqvT7B8mv+7Bk/G8MpenCIlJVwxM0DgoLW1o/o3RDtvaAwlqupTCC+ltkmcVTtJPetk8pxOCHwdF5sW0GMdVjqKQYWlw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Z/Q7GPTWxbVHWWG/NMfetHIarWrU8ZsJfdPzH01MGzI=; b=bjgdgynTpGwdvVWAWr3cqiTQdtzTU/vNPDk54hgs7nl6x0LShbjR40+3emDvB+V3AXe5MWTtwE5SbKQM/1ol1aUH/xjaXbaidL734uKkPt4IqC1eyHwWSTOzsGw3plQUiS1wkX4dgiYGWUykPHLgqZscEiUlAZCdrOMAMLlRTdaYhcz5i1+SGcvk68YCxM9utuOCh20rEZRJwA4VZhmUxq3QjSOMO27w95ysB5heo/s9c3X/pu4O0rqeUOYr+n20EUssG3VMzLIemeh84pbqbcQYWojjpe4yAFhA94On+HTlhIm4OZgcbQi6VAXPwMNTNV+GEqe4hg1ay0u5GPWj6w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=intel.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Z/Q7GPTWxbVHWWG/NMfetHIarWrU8ZsJfdPzH01MGzI=; b=aDp2xI2YL/pOCgT/i4e3IIVMkQAbyoSeV+NOtIPuQ5AxgYQgnZ65ymJtkTqUoUoFMhKjq0kUPzbBWxH2ketQVEJPpKlixNxYMzOvG+oy6V0KTA1NQAuVar5qZXCEyjC+QLSZWUCPK6F7kgTTCGwQMbnq+fWoI0QmMZtIwE2TmhiUJJPBWASDYyJeTg4YlQuWGITjHYjsmofjOrP2hOcER1BNYNkMF6WCzt+rZdlGX7lxIizfBZLrWlQzz6TMN4ldtNoLuRjIUczr9RvGmZ38sLdUmXrYBgrA9JdzZQhSXhZYx7IjB7wUvIAwhigEM9ttjpmvZAsbpifLrxVZ1nOvsg== Received: from DM6PR08CA0044.namprd08.prod.outlook.com (2603:10b6:5:1e0::18) by BY5PR12MB4225.namprd12.prod.outlook.com (2603:10b6:a03:211::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7849.22; Mon, 12 Aug 2024 12:56:01 +0000 Received: from DS1PEPF00017094.namprd03.prod.outlook.com (2603:10b6:5:1e0:cafe::4c) by DM6PR08CA0044.outlook.office365.com (2603:10b6:5:1e0::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7849.20 via Frontend Transport; Mon, 12 Aug 2024 12:56:01 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by DS1PEPF00017094.mail.protection.outlook.com (10.167.17.137) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7828.19 via Frontend Transport; Mon, 12 Aug 2024 12:56:01 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Mon, 12 Aug 2024 05:55:49 -0700 Received: from nvidia.com (10.126.230.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Mon, 12 Aug 2024 05:55:47 -0700 From: Xueming Li To: Jesse Brandeburg CC: , Ian Stokes , Bruce Richardson , dpdk stable Subject: patch 'net/ice/base: fix sign extension' has been queued to stable release 23.11.2 Date: Mon, 12 Aug 2024 20:48:51 +0800 Message-ID: <20240812125035.389667-55-xuemingl@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240812125035.389667-1-xuemingl@nvidia.com> References: <20240712110153.309690-23-xuemingl@nvidia.com> <20240812125035.389667-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.230.35] X-ClientProxiedBy: rnnvmail201.nvidia.com (10.129.68.8) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS1PEPF00017094:EE_|BY5PR12MB4225:EE_ X-MS-Office365-Filtering-Correlation-Id: b635564c-be65-4f9c-5260-08dcbace1e6e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|82310400026|1800799024|376014|36860700013; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?k3X5UUQDY1/pgST+oIr4qUXrJOzmrlJ4POgtWkDS4aHn8LdSwH/swGLlqXBH?= =?us-ascii?Q?GUV2hqZzdy5n06MLAS3HA5P0cP9u8E/quuOCkDF5YhQzSGNvCQAYN0wpe2CN?= =?us-ascii?Q?4kSTTy3QCHlAvoJ70sXaZ6FOZIaHTjQCtNDCOVtU513uxRPOidaDBcwhP2LO?= =?us-ascii?Q?dLQuHyMd2EdDup/4ClyxJmeGy5t/CtIGCDHmEt9e3gm9CDhWQP1O5pMOnQ4p?= =?us-ascii?Q?9JV87ti6WfwqurK/RjASrbnlv17uJiUOOjrQ1DhN2CMTfZrSzbW3/ob4hdEy?= =?us-ascii?Q?wV8NFiW3fphQsIXDTgOTdHpmy83wzZQ04Bvk0BoCG2gv0nERFiogveWquE6i?= =?us-ascii?Q?Kn0bcgBn3wrMIv88PWvNn6zFbpZtBTTgo54ev90AuI3aZ2LdwYJ25306ebEK?= =?us-ascii?Q?eznl5s+3eawB1AcpOAlYZxKzS/Oz2Q/r99/93Ngiqc0QvbZ5ugC/+G07I04O?= =?us-ascii?Q?dmdRCwqRY/5drU3BtERtrjxd7zrPqXD7N9eW1uq0Tts4U72iusSsQFOZM4M4?= =?us-ascii?Q?uurLJFHZ+ezRo0FsuUgs3hzoUSD5JHHpFGANRiFy+UOQX+LAWK016JGbgdNG?= =?us-ascii?Q?SnxHQzrAGxuRjFAqEBAchc7gKSSmxMIliymuXDhwj3hNE6cV7E/7PTmEKvPV?= =?us-ascii?Q?v30PsAC9pqEUB8rNEtEtO4nTLVyBIYtWvLZ8wwqWR8Us5MegA1Xl1h61H3tx?= =?us-ascii?Q?hpmKQZq1fHT9frzbz8+CcMoOPK7SXDGLMmv59MXpjMl6uzIQhmEL1pYRrLee?= =?us-ascii?Q?GzcC2VdzZb80k3eBIrllcZAdD9Ngw2QNtSEtY7BK92JfNlbzMzcp8xTloVxu?= =?us-ascii?Q?7TPzf4STkerlzewjRoTOqjw20qMmawjStJbjd+dvFKO4jwEMCUBEjmc5P1vE?= =?us-ascii?Q?KNOt/8z0VzE7k7DBlUEAmxMdbPtImtdRDk4RkeJ4P7MrrRz2VmbWZd7VJ7oF?= =?us-ascii?Q?vpTBArpzHkqrE5a1CCLcb62/B13G4p04mPFpL6mej6Wx1KhpiPoqQigdzZuK?= =?us-ascii?Q?Mo814/cn1ozsW1i8s/qHTOOvZfgAf+asZvKatlUCKuLc0kcKMu4QYrZ/obTK?= =?us-ascii?Q?gKXk5Aau2IVhWc6vih4N8NZs2l8IbYoxbvWmwfM4TegRQ7lkm8Fwjcc+jPvZ?= =?us-ascii?Q?6LiGsvishPBIegIS7VlU/RDeaTUZsudWBFx4dX/FLDI9Im/1iwAlEljDHx0C?= =?us-ascii?Q?HVZvkqN5JKZuvrn1XVjhp7lVeFMAc5QrBPpMV8j367W0K5Wke1qWmlmx0Z8W?= =?us-ascii?Q?bn4tTHqS0scztU/ovUFL0eZOOc2xiAoFCws5ruWFQxp+LcQeatOQMwN4VgtO?= =?us-ascii?Q?oU5k1DSukYXDX/AEvsC1fNF6SdjGEgUkK3hKKUlbP9/ySiftRXEiPHdqMGkl?= =?us-ascii?Q?D5+7jUwW3M8rBU3hECIolmrBE3AwXlHIh4FBCSAMpuistxMX6s2VcYS4iTR+?= =?us-ascii?Q?UoOn+OrOPbD9cQrLyPry16RPWXQMAtvN?= X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230040)(82310400026)(1800799024)(376014)(36860700013); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Aug 2024 12:56:01.3999 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b635564c-be65-4f9c-5260-08dcbace1e6e X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DS1PEPF00017094.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB4225 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 23.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 08/14/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=23.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=23.11-staging&id=1257bf9a7cdd3d73b90f0ffb05d79830f408c20e Thanks. Xueming Li --- >From 1257bf9a7cdd3d73b90f0ffb05d79830f408c20e Mon Sep 17 00:00:00 2001 From: Jesse Brandeburg Date: Wed, 26 Jun 2024 12:41:03 +0100 Subject: [PATCH] net/ice/base: fix sign extension Cc: Xueming Li [ upstream commit 4fe3f901f86243bf2dc5925e870030995f229888 ] Fix a static analysis warning where if the 16-bit value in mask has the high-bit set, it will be sign extended by the shift left (which converts it to a signed integer). Avoid this by casting to a u32 to make sure the conversion happens before the shift and that it stays unsigned. Fixes: 9467486f179f ("net/ice/base: enable masking for RSS and FD field vectors") Signed-off-by: Jesse Brandeburg Signed-off-by: Ian Stokes Acked-by: Bruce Richardson --- drivers/net/ice/base/ice_flex_pipe.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/net/ice/base/ice_flex_pipe.c b/drivers/net/ice/base/ice_flex_pipe.c index f9266447d9..a0e4f5fa27 100644 --- a/drivers/net/ice/base/ice_flex_pipe.c +++ b/drivers/net/ice/base/ice_flex_pipe.c @@ -1534,16 +1534,14 @@ ice_write_prof_mask_reg(struct ice_hw *hw, enum ice_block blk, u16 mask_idx, switch (blk) { case ICE_BLK_RSS: offset = GLQF_HMASK(mask_idx); - val = (idx << GLQF_HMASK_MSK_INDEX_S) & - GLQF_HMASK_MSK_INDEX_M; - val |= (mask << GLQF_HMASK_MASK_S) & GLQF_HMASK_MASK_M; + val = (idx << GLQF_HMASK_MSK_INDEX_S) & GLQF_HMASK_MSK_INDEX_M; + val |= ((u32)mask << GLQF_HMASK_MASK_S) & GLQF_HMASK_MASK_M; break; case ICE_BLK_FD: offset = GLQF_FDMASK(mask_idx); val = (idx << GLQF_FDMASK_MSK_INDEX_S) & GLQF_FDMASK_MSK_INDEX_M; - val |= (mask << GLQF_FDMASK_MASK_S) & - GLQF_FDMASK_MASK_M; + val |= ((u32)mask << GLQF_FDMASK_MASK_S) & GLQF_FDMASK_MASK_M; break; default: ice_debug(hw, ICE_DBG_PKG, "No profile masks for block %d\n", -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-08-12 20:44:04.338305054 +0800 +++ 0054-net-ice-base-fix-sign-extension.patch 2024-08-12 20:44:02.085069292 +0800 @@ -1 +1 @@ -From 4fe3f901f86243bf2dc5925e870030995f229888 Mon Sep 17 00:00:00 2001 +From 1257bf9a7cdd3d73b90f0ffb05d79830f408c20e Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit 4fe3f901f86243bf2dc5925e870030995f229888 ] @@ -12 +14,0 @@ -Cc: stable@dpdk.org @@ -22 +24 @@ -index e06dbb0885..413b6f8ece 100644 +index f9266447d9..a0e4f5fa27 100644