From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E1215457A1 for ; Mon, 12 Aug 2024 14:57:25 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D8CE0402C3; Mon, 12 Aug 2024 14:57:25 +0200 (CEST) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2048.outbound.protection.outlook.com [40.107.243.48]) by mails.dpdk.org (Postfix) with ESMTP id 9B2BA4029C for ; Mon, 12 Aug 2024 14:57:24 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=bMCQLRk3YkxnizZM2ZzRvdKrc31lXG4OqzVSqjj+DprmeM/D7WCjLzSKDgwyb0kuQDML/iqYSgzE0pITjfGt9aOTbT1apOhgIXy856gwPr/gwfnEK72EDjHQPbpKLUrkZFp1XOj2DBHHyKn2880/W6TOUuXPByXQvsGjjXxxs3eXb36WGSvnXPBX8rZxBVW3TCZdyVZ/EFGeq4lCFs96j33KlJ+CtJVV+Av80CgUGtd4SX8sTMgoCdwL7M+kuxRBpFlU0D7HMzJ+mkHfmO0DmEFbx5oJJM2HnUm+A1zNFYkWxJdoYBfJT/iNAh3IqR4DzKxpficRd8gb22fRg2anxw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bmu1c3S0Il3Go49Yma9G6AqqYtJVOstkTaAy5KcA+kk=; b=a29Im2yKTuC1FTQ5c/J6tbj3Q7LpM/tq4ePxhSEn69yZhy6cVLILN3VoPmNs5TQPMM5frygYdjcQ55IEBdwn9ENKUaZco1KPNzNc2nUAcku9yGTVYNo/eDkZZEZ80MY41xGBDLn09J0MJPS3sAGWUcu3QthvzjukWj5ipZst2TDbpco7mJaw4skm0yjxhCzDkaTJ9CEnl4HD8MbFh2+bQ9zlXvec2ddEnUM69So5PV374hq2VtWzax5AaLulNJ3wKGAJSAqh9zFviJ8Y3TAHMKj0WctSo+AFlZgV2WRcOJgXkCnHuJ9mgSiAGbhgwmyxDtXABDCvphdKOjz7dQa8hw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=huawei.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bmu1c3S0Il3Go49Yma9G6AqqYtJVOstkTaAy5KcA+kk=; b=XNiuPv9RxT9Bo9UF1afGHeGQRDXRUUWGuNtukcDerLja7VbZGcLSIoNO+Z+s9E7P77pjyDFZ3WO4E7FH1xPR1rRogLhjoMyPtqZueQ5re7f8U/YrPS6RT3GDIzxYrD9ZPn+m39GEEh4L8OQvMcFQyu/dbEleZaG3g3gwWmRhELcZvjhmYI9/8AIeT/eOow0kFeJGIDYZWJ6CM2Abhu8RBrqQ/CwTBNNlvdh5GoOd90YTCsSJSvfrGSvRs8GGiCLH+FQTTeYXi5QxRgqXbe3Mq/iT7SlRwt4YtT6LL8rkeC2pOCc+PB1jMBPBcLEvZl6zK9sPcD/cMyNzmWZCidW4WA== Received: from BL0PR0102CA0045.prod.exchangelabs.com (2603:10b6:208:25::22) by CH3PR12MB8546.namprd12.prod.outlook.com (2603:10b6:610:15f::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7849.22; Mon, 12 Aug 2024 12:57:21 +0000 Received: from BL02EPF0001A0FF.namprd03.prod.outlook.com (2603:10b6:208:25:cafe::ca) by BL0PR0102CA0045.outlook.office365.com (2603:10b6:208:25::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7849.22 via Frontend Transport; Mon, 12 Aug 2024 12:57:21 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by BL02EPF0001A0FF.mail.protection.outlook.com (10.167.242.106) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7828.19 via Frontend Transport; Mon, 12 Aug 2024 12:57:20 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Mon, 12 Aug 2024 05:57:08 -0700 Received: from nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Mon, 12 Aug 2024 05:57:06 -0700 From: Xueming Li To: Dengdui Huang CC: , Aman Singh , dpdk stable Subject: patch 'app/testpmd: handle IEEE1588 init failure' has been queued to stable release 23.11.2 Date: Mon, 12 Aug 2024 20:49:03 +0800 Message-ID: <20240812125035.389667-67-xuemingl@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240812125035.389667-1-xuemingl@nvidia.com> References: <20240712110153.309690-23-xuemingl@nvidia.com> <20240812125035.389667-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.231.35] X-ClientProxiedBy: rnnvmail201.nvidia.com (10.129.68.8) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL02EPF0001A0FF:EE_|CH3PR12MB8546:EE_ X-MS-Office365-Filtering-Correlation-Id: 014d6346-9b00-4e1e-641d-08dcbace4d55 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|1800799024|82310400026|376014|36860700013; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?66fb6mV6/WJbLx330ZOcez5J23T+6P+fu/gGethNOQhB+NlBJjDRAscjf2yU?= =?us-ascii?Q?6tGWTeJ9q4qyRRNA+xomU5t4L27zrfiElU2KgRL+xlrZ54V0zwcnByMPyJ7t?= =?us-ascii?Q?aADNL/NdGd7j+/GWfX7Us07KqqZoxGi4L2PvN11+QLBmHoJW4DzxL2PG6tC3?= =?us-ascii?Q?pJGeuqe3tDvPuVFff1JyZTl2AE2+/2DMgJTRGl9m0WIgUNA8iJ/4wzHV5OJs?= =?us-ascii?Q?30fIS/1XZ0/yaN5u+nP3vrYPTd1/cMqFjnsygI0ULmFv6G/3ehFSusTkVAXQ?= =?us-ascii?Q?zyUdLSNtL5ajYAjjMd+Y8k3Srz+3KmeQoD+o1GbqkvB6ehe6BOivtcqXfCEy?= =?us-ascii?Q?crDAo/uONI4ZXlITz5iYHfpwT+qAQi2RlB3w4OoYAw2sGm/IzQZXZJ5JovFc?= =?us-ascii?Q?28IIArbynQ1OGYbL6EdD4uzOr5ZY5g1V76LEiarg56PQghY/8b9RQQl+WiIH?= =?us-ascii?Q?TUip7LJTuY7PV1SZY4Qo5za3USK65giG3qVGhgrBsqTgrj/OLeJAgBVuqIqW?= =?us-ascii?Q?eW6IVh7AOY2EuPRVusPFK3F0amrk0DgbsbBzznYnRw3YDY2iXWxDbKs3A97G?= =?us-ascii?Q?NH23Ezhexu0BCYmqNa7hqZwCYM9DuYbEaJzC64Nw/J9oYM8W0fLdZ9jMabZN?= =?us-ascii?Q?Qj/jufnQ0Mq9fo+WOmcS9V8Qk/bqfNWGQlBjUbQebZiCyHWoL678fBBuzwms?= =?us-ascii?Q?z/SZBIjjQ7cDsPWQUOgVAv7S6F0a3Xl3/XY1wEeG1OuDoRALikt+cdTuRS0b?= =?us-ascii?Q?PwQo0rqN0MrLQAoRjWPNKpHsDe4xd/THFmJlobDa90XYRE7rq/JuJ/rR5Z3D?= =?us-ascii?Q?QMUsTEyaqrKdzqgTIE380FivugMv5NfD+8zOjGAmwFKPJbrK5jxDKtFvtVL4?= =?us-ascii?Q?2rJ0H1bieuz+tvZE7vle+lSPuumtthYG8mzagBD53K49Tgw1J3J88IpTJOol?= =?us-ascii?Q?oR6XY+ashCTXkhDPM4r4VtWTgfliZ/OD9JTJuBFwpqP6X3nInKtua33q69PR?= =?us-ascii?Q?Dy8bwOA2b2xPPILQ2xEd1ZuOube1lkaKrvZ1uzSW84pmJR7Ya26DRRLfUJKI?= =?us-ascii?Q?soFVC7nj+ZGoD1rI/9rhRmepmgUst9Ichkn63hVsYdQANX4U14iXQ7IdsJbA?= =?us-ascii?Q?3tm3SSUBIf4/Y0tE2vFOIWWC41qkCmvDYgZAoOihhgsyEZxtXnMRtBbcRG3e?= =?us-ascii?Q?Y4FA6sprNBGqBUsyL0dbFLyGTkkVUtqObLIf7NcBgGdnu0zrYQ2PbAiqMViu?= =?us-ascii?Q?UgtKROn76+e9zRh0Dta7RytJQBLf/OIg5+TLwMWhh3CYiAVj/8pOXBgIubMB?= =?us-ascii?Q?Ei/IcSC9KAcloJBWoZAxhUWSgORaB8luVVqm5pvslVTMX2f+EjuMPg7qTsL3?= =?us-ascii?Q?UHpNMNAUkc9dvsZA7cozJy1q41ZtUlw8qDewQU7v8GcYe4wZ1ro0GXXqp86Z?= =?us-ascii?Q?FFOVmKAHdPVJfcoqq+hsOlp+WLo3mXnr?= X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230040)(1800799024)(82310400026)(376014)(36860700013); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Aug 2024 12:57:20.1207 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 014d6346-9b00-4e1e-641d-08dcbace4d55 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BL02EPF0001A0FF.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB8546 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 23.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 08/14/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=23.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=23.11-staging&id=f11711212c988fd0df19d9044710a68909f2e99b Thanks. Xueming Li --- >From f11711212c988fd0df19d9044710a68909f2e99b Mon Sep 17 00:00:00 2001 From: Dengdui Huang Date: Sat, 30 Mar 2024 15:44:09 +0800 Subject: [PATCH] app/testpmd: handle IEEE1588 init failure Cc: Xueming Li [ upstream commit 80071a1c8ed669298434c56efe4ca0839f2a970e ] When the port's timestamping function failed to initialize (for example, the device does not support PTP), the packets received by the hardware do not contain the timestamp. In this case, IEEE1588 packet forwarding should not start. This patch fix it. Plus, adding a failure message when failed to disable PTP. Fixes: a78040c990cb ("app/testpmd: update forward engine beginning") Signed-off-by: Dengdui Huang Acked-by: Aman Singh --- app/test-pmd/ieee1588fwd.c | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/app/test-pmd/ieee1588fwd.c b/app/test-pmd/ieee1588fwd.c index 386d9f10e6..52ae551e2f 100644 --- a/app/test-pmd/ieee1588fwd.c +++ b/app/test-pmd/ieee1588fwd.c @@ -197,14 +197,23 @@ ieee1588_packet_fwd(struct fwd_stream *fs) static int port_ieee1588_fwd_begin(portid_t pi) { - rte_eth_timesync_enable(pi); - return 0; + int ret; + + ret = rte_eth_timesync_enable(pi); + if (ret) + printf("Port %u enable PTP failed, ret = %d\n", pi, ret); + + return ret; } static void port_ieee1588_fwd_end(portid_t pi) { - rte_eth_timesync_disable(pi); + int ret; + + ret = rte_eth_timesync_disable(pi); + if (ret) + printf("Port %u disable PTP failed, ret = %d\n", pi, ret); } static void -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-08-12 20:44:04.714636624 +0800 +++ 0066-app-testpmd-handle-IEEE1588-init-failure.patch 2024-08-12 20:44:02.145069304 +0800 @@ -1 +1 @@ -From 80071a1c8ed669298434c56efe4ca0839f2a970e Mon Sep 17 00:00:00 2001 +From f11711212c988fd0df19d9044710a68909f2e99b Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit 80071a1c8ed669298434c56efe4ca0839f2a970e ] @@ -15 +17,0 @@ -Cc: stable@dpdk.org @@ -24 +26 @@ -index 3371771751..afea7735c7 100644 +index 386d9f10e6..52ae551e2f 100644