From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B8E39457A1 for ; Mon, 12 Aug 2024 14:57:37 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B2E1B402C3; Mon, 12 Aug 2024 14:57:37 +0200 (CEST) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2062.outbound.protection.outlook.com [40.107.243.62]) by mails.dpdk.org (Postfix) with ESMTP id 89D964029C for ; Mon, 12 Aug 2024 14:57:35 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=EizhQmHJtvYfvnTgqosgmaviiNc1CViUazKplUzQFbP7G4qAzUulhvcO7sFmHlC4aYtu/lKyxdUjs6Tz3egNBFMTuIstDen4iWwIlpQ3OB6cqs3RXx8VeO4C04VnspuauvcEBCc3bSs111cAL3DUA2POwctFee8T4DFhnRXHDQvrfpgPszUcwOekg3jwZlOeAyw9mjdxdmbK/U3JHFGpg06FWmlN3fVVwST/zdUmzcv/IXD4e+qjL6pb8BCbMoDIO3CcOc8VmAIUbZfSRjMMkAo2LOKaBtzgcDxRGTHueDFTVJuY7wdVwLeENdm2P75Tu5oXUeGn5Q/kI7WUElwixA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DZZdcylSzRRmhzJhWfcXhTG7NXtRTP9WtYhgb86krp4=; b=r8P/0Z1QwY6jkYrUlcjCi+ed70b73cp9y4BHAeXrlgPAZlwCqvEx68/JBR451zrGIxt8V0Zp1nz7H3TP3pB+Ft6Etn9H6ZTXK1sEQIhKdVGI/Ki2fhP9q0JeyUayNnEvv77jl/rYrsJx/YJRH0B2WjNmVerNyo7ce+dWabRrBsZS89CnOnKtDRq1fW4OXKNq9D1AM8NsawWVVvBn6DZZmv9eIvuZOi5H3GnTocjWRFa3m4S0IescMY+T+xsT6eg3hyHVCn4uZfE1n9JSw9504ORoO3h+n6t2K6Wa7XjoNxDCY71NoCo6Yzdgi+ObrKT3w1Rf6GCIW3Z3zvlzyS/fag== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=gmail.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DZZdcylSzRRmhzJhWfcXhTG7NXtRTP9WtYhgb86krp4=; b=IbnLVWCNNNorxBy6KfKMYTIsZJZKqrUEzFWgnMmpwMceTeHFshKDzOWRZ7wUeMpXv2SjlASdVCM5yIOrrb0s66rXKNS3CKmc9Rt3y26YTUUy7bXoB/8yPgoDEidnSEEhPNJlugFkMKlrBIA/Ir/UkugYXO5r7ok5YwQ9D1uGLZbwYdAFlpCslyi55OO8SqltMlLUKRYB7Rqd3ctu4ejSGHfdxkalizK+KUGfFJRrPTehoON7m9T3BGH4MZ/kmX7A8r9rsTQ8T4PJ8hoimcc6D8zXfVKedKayy4C9TZZ0Xeq6Ld/392aC3vp4y0LIsG2jM7O0mxMi/kHW5fIBImJ/rA== Received: from BYAPR03CA0029.namprd03.prod.outlook.com (2603:10b6:a02:a8::42) by PH7PR12MB6634.namprd12.prod.outlook.com (2603:10b6:510:211::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7849.19; Mon, 12 Aug 2024 12:57:32 +0000 Received: from CO1PEPF000042A8.namprd03.prod.outlook.com (2603:10b6:a02:a8:cafe::f6) by BYAPR03CA0029.outlook.office365.com (2603:10b6:a02:a8::42) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7828.33 via Frontend Transport; Mon, 12 Aug 2024 12:57:31 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by CO1PEPF000042A8.mail.protection.outlook.com (10.167.243.37) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7828.19 via Frontend Transport; Mon, 12 Aug 2024 12:57:31 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Mon, 12 Aug 2024 05:57:14 -0700 Received: from nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Mon, 12 Aug 2024 05:57:12 -0700 From: Xueming Li To: Mahmoud Maatuq CC: , Long Li , dpdk stable Subject: patch 'net/mana: fix uninitialized return value' has been queued to stable release 23.11.2 Date: Mon, 12 Aug 2024 20:49:06 +0800 Message-ID: <20240812125035.389667-70-xuemingl@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240812125035.389667-1-xuemingl@nvidia.com> References: <20240712110153.309690-23-xuemingl@nvidia.com> <20240812125035.389667-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.231.35] X-ClientProxiedBy: rnnvmail201.nvidia.com (10.129.68.8) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1PEPF000042A8:EE_|PH7PR12MB6634:EE_ X-MS-Office365-Filtering-Correlation-Id: 8d24f694-16a7-4605-61ec-08dcbace541d X-LD-Processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|1800799024|36860700013|82310400026|376014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?xGzl6JwW4lWIEAnuyvsy18UvS4uoyJ4++7S2k9kkXSQZdh5KNDEPNMpYRgm+?= =?us-ascii?Q?UgtcTgdckdOc5E55y7EZLl+nylwHizlMSXcWKf/mN5QRHwVoAdlhD/BkP8mH?= =?us-ascii?Q?VT98lfVIWMeUcWMmPDnV4ksv/6b4FA2WinWvfe1bXbLipgxBKBNG7vhdWXdg?= =?us-ascii?Q?7MIOBGhcgtEr9H38c/qZr0rV7lyHWgjKxiHEpH5jKXLS4cFtTI6Fy/cwkt7y?= =?us-ascii?Q?CzlpeGQTLiaQdSbplsopPMU1hqJTMFJr82WwOhK8f6jJnmiC8/+PFvv/RBTf?= =?us-ascii?Q?ws7fbcHgc2BOz43NYiRsRYq0IrBUKJTvvY2oB/7F86xiTtA1AEe3vyhAUvcw?= =?us-ascii?Q?aqjFbrz4P6+ETBFP54L7dtqPZ6m47lDDLy5whKztcB2FxTWrvHX9WbUqVH7K?= =?us-ascii?Q?OjcqXQ8zhCbq3DxfQ/VfJkSl1ZvcOjfNx/ekb/w9sIGjhgDg+2wV0w8krg76?= =?us-ascii?Q?Chb5mICKH48h/6SKQaqNuL3fsRDWuTFUbxAzaEv/UiTPpt5jeBDwcn0ZXvJ6?= =?us-ascii?Q?Xq74xY+d/us4Y4+9NnQPrwsoX7oxd1g8B+iqRR1o9t3IE/J3PEBsNaPPg667?= =?us-ascii?Q?JgGylBLsKRsHSACV0KRw/1mncXM42pN9ZoS6pcPoz78FaGeuiy4gvIOeGWcs?= =?us-ascii?Q?//SMvPY86Gz0wIkuDwACBtIWD1op4OZNN8XPltxSzv+IICjVZ9x9cm+e62bN?= =?us-ascii?Q?W39uwlfDFOtEJ9pkGe/7pdFLvgqP0r9aW2iH8lcNiUB4sM2tX9fwFhmSPpxX?= =?us-ascii?Q?OK4Kk8haAoVvoYUOt9PEgshYQfIHzHKML5KZx4BnqfLhSPhoZqqOPPgCyMfd?= =?us-ascii?Q?SZ0/O00STtDUM8RkB6h/0ZOQQe9Md/KIdjwG9PTVlN7IcTlg+6t9/hOBD96Y?= =?us-ascii?Q?IYZMUfd3n+tEwByftjYORMKkjtPWrJw4RQsLXp/xJhg9pCQ/LuZ+cYyEOMkx?= =?us-ascii?Q?r4nlfn2yd5V1tRApnUO3Xi2par/P/Eendt+CVoK+cChNMdXkWxoaN74eVt7y?= =?us-ascii?Q?VrCmdHd0EKdVhFqaiQJ3MzHVTlZy8e7MWVqbc3wDGhsL66K/rB2yk7ade20w?= =?us-ascii?Q?ImDebALnDHSWCrsloIPo1wLW7CYNMvpvq0sVVU7QKpqH/Tn/RolR3bfQo/qh?= =?us-ascii?Q?r5s+cWbDiL+eMKr+wcFkR52dl0DJPZsTi8fcSeq47P5cPUei+4dhsB5evkwy?= =?us-ascii?Q?3NZaBDqcfi90kZVn6YMAcIk/ra4+hPHMuLvjUuGMvv8XVpPxyXTDyJwR/ox4?= =?us-ascii?Q?Srn6p92td9+E1cF6LSOu0aAm7NvDntDkHcG4y8D5n3+0Dea1HWIWgdI2kpSV?= =?us-ascii?Q?/ZJcfEuvQi5Yp1fFgfSow8lIhNHFI3thHI3rB85ognEBDxeVBWcQuJ5Yh1fP?= =?us-ascii?Q?TdemUq8LASkGDBtewnKxUGFsVEUbviHKEGET0nk7vbYejN3zuT2mBWB5O0AF?= =?us-ascii?Q?0IAzOyNkxHgzC183qgfY6nnVSg8ZsEuO?= X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230040)(1800799024)(36860700013)(82310400026)(376014); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Aug 2024 12:57:31.5133 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8d24f694-16a7-4605-61ec-08dcbace541d X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1PEPF000042A8.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB6634 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 23.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 08/14/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=23.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=23.11-staging&id=708d5a261b673590204842dda9988a18a649fd25 Thanks. Xueming Li --- >From 708d5a261b673590204842dda9988a18a649fd25 Mon Sep 17 00:00:00 2001 From: Mahmoud Maatuq Date: Thu, 13 Jun 2024 22:30:39 +0400 Subject: [PATCH] net/mana: fix uninitialized return value Cc: Xueming Li [ upstream commit c2c0c8af08ed4e37a10bbabf98a09a105a5650a8 ] in case we didn't enter or finished the loop without getting ifname we ret shouldn't have an arbitrary value. Coverity issue: 424690 Fixes: 84497839d9ca ("net/mana: support MTU update") Signed-off-by: Mahmoud Maatuq Reviewed-by: Long Li --- drivers/net/mana/mana.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/mana/mana.c b/drivers/net/mana/mana.c index 58257c971e..65ca139be5 100644 --- a/drivers/net/mana/mana.c +++ b/drivers/net/mana/mana.c @@ -711,7 +711,7 @@ mana_dev_stats_reset(struct rte_eth_dev *dev __rte_unused) static int mana_get_ifname(const struct mana_priv *priv, char (*ifname)[IF_NAMESIZE]) { - int ret; + int ret = -ENODEV; DIR *dir; struct dirent *dent; -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-08-12 20:44:04.805287417 +0800 +++ 0069-net-mana-fix-uninitialized-return-value.patch 2024-08-12 20:44:02.165069308 +0800 @@ -1 +1 @@ -From c2c0c8af08ed4e37a10bbabf98a09a105a5650a8 Mon Sep 17 00:00:00 2001 +From 708d5a261b673590204842dda9988a18a649fd25 Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit c2c0c8af08ed4e37a10bbabf98a09a105a5650a8 ] @@ -11 +13,0 @@ -Cc: stable@dpdk.org @@ -20 +22 @@ -index 68c625258e..c37c4e3444 100644 +index 58257c971e..65ca139be5 100644 @@ -23 +25 @@ -@@ -715,7 +715,7 @@ mana_dev_stats_reset(struct rte_eth_dev *dev __rte_unused) +@@ -711,7 +711,7 @@ mana_dev_stats_reset(struct rte_eth_dev *dev __rte_unused)