From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1EA75457A1 for ; Mon, 12 Aug 2024 14:59:50 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 00B3B4066D; Mon, 12 Aug 2024 14:59:50 +0200 (CEST) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2054.outbound.protection.outlook.com [40.107.223.54]) by mails.dpdk.org (Postfix) with ESMTP id 7509C402C3 for ; Mon, 12 Aug 2024 14:59:48 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=s10k36+PtrXjSTuf8Y2n9WtwyMjCKq8RSxYq1vX3DCwZMHXXE0D9C5UGrwta2LniuOEniy/KMbJnnCYEDPQ6YQWh3Er2rCns9QATV8UlX7nDR0KTS5Lko4ltTsXsGyrS90trP0lHsZQLlM480CaIVWDWmVv6TX/Q/SY++eetTDmN6QfE2QXduFw3KAoWdQtPG3N6rwdtJwjAWfm6Sp8T1zIwZ7THIxXlZyteatCrYqOzys8XBQQ4QMKtkFlUL7RdXg+OM999MmRMU4L5orCd1+QxMGEZaaQlD5sDiNnr7e5zeUVl1fqtMw8sBzWlVWk3jgjAdvTP8H2KWi7RQHkV9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qCxUqErPTukw512sIuJUlc171bAT0RCwbr2MDvK+JR8=; b=x5lcMYX6W2qhkXtHXTNBgZdJMI8M/npC94VQ2LHsJYJ+uPe1qPqx04x5pn8wys6Eo5bj1JeR0IptTw7iv6jNcB4RDaxKhwSQ/FbtSkoUQSZ1qWQv+hMpflbNEIdwucu5OtHJNdMQA5VZJYV4haqYgGQrFTuQ1Z+4W0jzo/MTsDDWF3d8hWUs00VzFCkBV2+hFVctCN3Zm5Vz2HtHBfcyCcyy9WqOi7UtYM48yjttKDSKzb1kpWAL0s7uwufVUzk39y2ZcsQx0hOzk0Or764T0qWKsf8BWigDkMXlBbeVudFdQl3oPEXZxj0ddJKX0cIhEfARkHU5+uxX8uEaLyVEPA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=corigine.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qCxUqErPTukw512sIuJUlc171bAT0RCwbr2MDvK+JR8=; b=osBnZY1GdOdvkRhIk39qZlTps5oNK3Kz9btOnetawzrMYUQZLy+b8meG3G1BhJeJUiTJKB15pj2L7lsc6mlU3lsdnQNef0AADz6kC23rJ8f/NvL9y1X8AJcI1vR+om4XqVZOTLVCljTsosK9eV8sJDcN22QSQsL7B20CZ4VnoEC9SSXiZm9s0KU4dtAJumLirfW/2NlAIyZYw3BgpscKNys/ImxtPvauvnK5a2kiOFPVMIaO50vuO9kiuVsJdnseDHjsOgBmQK0CeAWqySKXYFZYxlMjsf6ejI1shMvKgla4MMpr0Df/So7LWNfs9lHGswevPXZ/RCW+qcLlqxMUkg== Received: from BY5PR04CA0019.namprd04.prod.outlook.com (2603:10b6:a03:1d0::29) by PH7PR12MB6635.namprd12.prod.outlook.com (2603:10b6:510:210::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7849.20; Mon, 12 Aug 2024 12:59:45 +0000 Received: from CO1PEPF000042AA.namprd03.prod.outlook.com (2603:10b6:a03:1d0:cafe::cd) by BY5PR04CA0019.outlook.office365.com (2603:10b6:a03:1d0::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7849.22 via Frontend Transport; Mon, 12 Aug 2024 12:59:44 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by CO1PEPF000042AA.mail.protection.outlook.com (10.167.243.39) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7828.19 via Frontend Transport; Mon, 12 Aug 2024 12:59:44 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Mon, 12 Aug 2024 05:59:26 -0700 Received: from nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Mon, 12 Aug 2024 05:59:24 -0700 From: Xueming Li To: Peng Zhang CC: , Chaoyong He , Long Wu , dpdk stable Subject: patch 'net/nfp: fix dereference of null pointer' has been queued to stable release 23.11.2 Date: Mon, 12 Aug 2024 20:49:29 +0800 Message-ID: <20240812125035.389667-93-xuemingl@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240812125035.389667-1-xuemingl@nvidia.com> References: <20240712110153.309690-23-xuemingl@nvidia.com> <20240812125035.389667-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.231.35] X-ClientProxiedBy: rnnvmail201.nvidia.com (10.129.68.8) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1PEPF000042AA:EE_|PH7PR12MB6635:EE_ X-MS-Office365-Filtering-Correlation-Id: 050656c6-ee84-4a42-53a5-08dcbacea35d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|1800799024|376014|82310400026|36860700013; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?TvA00yx5GWtmWbLwPjH8Urn6PeXSnOFt+HyK6+VNcD5WdmsNVEYybEWitSgL?= =?us-ascii?Q?PWd9rUpOL4/xTylAu8b4uDGn3XZ+IgDJjeTIqSdxRvQORI828GqVkcrpSCVn?= =?us-ascii?Q?FaW6rN9WhUBSbiAxfXQk/MR/N1TQ1bSjQo9tpm4gWfDXKj3io9H3Gjpxa0kc?= =?us-ascii?Q?ALeYmQE5uLwpUeUm6S9Wr2KQUR6y3alWdlELzK0lAGWNcrvl+cc+pfKs4k9Y?= =?us-ascii?Q?ZRXZprw43C7drK4iJrGVvw9Ry3a0tNYYM1p5PNznfX14XjDDrCqFEtxlZlnt?= =?us-ascii?Q?vgJKe/VCg5WP2mh3MNr6G7EkaPDeD8WpVNqTy2DaJvJf6XFjxjur1NukhMJx?= =?us-ascii?Q?9FfCia/9Z0SbciQfsFr2P/8OIFvkPDqj43+TPaf3iiLa9qw2A09Zwuq/IXtZ?= =?us-ascii?Q?a7iyh0z2e59M/YqAr/NiRyQIE+zYhUyH1ThrqKr7deJFxEXp+d2TqcMVq2+D?= =?us-ascii?Q?cqSz3whfFSMpMI3GbLB+GG8yBuvBxYiMvnN2BqrO1p6V52am/B8i+ZEqMtAF?= =?us-ascii?Q?LSfnLE0nTd1GSxARDH7cmPjdoBQpWxsjRnTbQh20BwUI8wZrglPYj+6QZMJQ?= =?us-ascii?Q?8L6eg6x+YIv0YeZysM0Gdt36fWTod+JUz5p4N4z1sSrekKS19J08ZTTQdya/?= =?us-ascii?Q?fj3fRcdX7dXfQFiDktZ3enKS8Xm0+V3qaYSFcqMn9vzhJCrylVcoPOKBVoe8?= =?us-ascii?Q?cnZCKRIy49b3G5cN0AuqyC4aEBOtZ+oDTo6ZBZjl3qwbZIniLo8axhOiiY9V?= =?us-ascii?Q?SPIfAHky0rQ4Ymbgon8xCzNzXqqrqASLLwzg5I0oaUxztav1UpKezV6VgZP2?= =?us-ascii?Q?5eb+EeY2ZAmv7vOyzQnEKQYtNcgo7EGA73c1jljJJm3zACItR45w4/jMc3iT?= =?us-ascii?Q?tghPM7ziWPnRVnP1mtS99H1HHInK5Q+j+7WboO5qMmcXPNbZHxQBfY7s1gqQ?= =?us-ascii?Q?zcDaBJx5SW4mSR3GtDv4kTlgPbe+KQubTBvYrCKYAy3ZqwO/wZqXDzNvzGp1?= =?us-ascii?Q?2xvqR50VOmj69vSSnR5XyMGWgdeUBCXdbp5CY5TqJqt5VdenAI2RtvoWTNyt?= =?us-ascii?Q?Wm96FlxKXpzgy398u6K7CLrZOK/HukmVAJJgW0hokGhP4Iz3w33MBpmpk7BO?= =?us-ascii?Q?pZ+5vxyz7cDjDsN3WaT6uhEHauKm8o/oz28qYhp8+hpYHIphAM+RCzCHcXJZ?= =?us-ascii?Q?JlAc6N+y8+i9TBBQplH5c3nDzR9uu7YsocWjLej2uOAE2tBrBiTvJntQME0B?= =?us-ascii?Q?pC6M4gVew5sdfjhCOnLnF8K1Z4Nc46AKZLi57zvILTWlWzz5c1gbqpmQvPO5?= =?us-ascii?Q?+CUou6TBjXoyFC01yEO6KfyF4qrs3xH4DTWOFnQvJUibRjWeNGz2/Qvz2X/5?= =?us-ascii?Q?TQt6muZ17C6Sbr/5p7JZqPNlAsudvxU21OCR/yzaSyiEFPBvZniu1tRQrAAe?= =?us-ascii?Q?n/UWV8zNWxYIcLQl+XlvmRwRswCmcpv8?= X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230040)(1800799024)(376014)(82310400026)(36860700013); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Aug 2024 12:59:44.4724 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 050656c6-ee84-4a42-53a5-08dcbacea35d X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1PEPF000042AA.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB6635 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 23.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 08/14/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=23.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=23.11-staging&id=51d6936232523f4f798868217607a8b781deef2d Thanks. Xueming Li --- >From 51d6936232523f4f798868217607a8b781deef2d Mon Sep 17 00:00:00 2001 From: Peng Zhang Date: Wed, 19 Jun 2024 17:58:10 +0800 Subject: [PATCH] net/nfp: fix dereference of null pointer Cc: Xueming Li [ upstream commit bb177a392fe5e9f3b1145e29b5febbd8cfff4b6e ] The original logic can not make sure the 'repr' pointer has valid value and the dereference of null pointer will cause a segment fault problem. Fixes: eae7dadbe987 ("net/nfp: update link status reporting") Signed-off-by: Peng Zhang Reviewed-by: Chaoyong He Reviewed-by: Long Wu --- drivers/net/nfp/flower/nfp_flower_ctrl.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/net/nfp/flower/nfp_flower_ctrl.c b/drivers/net/nfp/flower/nfp_flower_ctrl.c index c25487c277..102daa3d70 100644 --- a/drivers/net/nfp/flower/nfp_flower_ctrl.c +++ b/drivers/net/nfp/flower/nfp_flower_ctrl.c @@ -441,6 +441,11 @@ nfp_flower_cmsg_port_mod_rx(struct nfp_app_fw_flower *app_fw_flower, return -EINVAL; } + if (repr == NULL) { + PMD_DRV_LOG(ERR, "Can not get 'repr' for port %#x", port); + return -EINVAL; + } + repr->link.link_duplex = RTE_ETH_LINK_FULL_DUPLEX; if ((msg->info & NFP_FLOWER_CMSG_PORT_MOD_INFO_LINK) != 0) repr->link.link_status = RTE_ETH_LINK_UP; -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-08-12 20:44:05.501181862 +0800 +++ 0092-net-nfp-fix-dereference-of-null-pointer.patch 2024-08-12 20:44:02.355069346 +0800 @@ -1 +1 @@ -From bb177a392fe5e9f3b1145e29b5febbd8cfff4b6e Mon Sep 17 00:00:00 2001 +From 51d6936232523f4f798868217607a8b781deef2d Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit bb177a392fe5e9f3b1145e29b5febbd8cfff4b6e ] @@ -11 +13,0 @@ -Cc: stable@dpdk.org @@ -21 +23 @@ -index de6e419cac..8cfafe91c8 100644 +index c25487c277..102daa3d70 100644