From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C52DE457A1 for ; Mon, 12 Aug 2024 14:59:55 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3E8194066D; Mon, 12 Aug 2024 14:59:55 +0200 (CEST) Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2064.outbound.protection.outlook.com [40.107.92.64]) by mails.dpdk.org (Postfix) with ESMTP id 3E3EF40654 for ; Mon, 12 Aug 2024 14:59:53 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=P/CX0SFt2Z7qf7hWJH0XtK2BBsb7aD177/uVIC6gHRFDxhkse10BCMKWTLV2QkBar7F8URk29BbcEBoQSOq6N0jWhunAj+GrJn4WBiCJF3VZgnKC4WNYrYOXllbDOieDReGhQTuKzmYf0dLzw+iaYW5RwxgJ6WSGrg/l/e/uSTt3TFXERo2u8mZwp7TcF9Z9aQFdt7rekI96OfK/cQhmNhgj9eu7kFoX0uob1JgTJsEDJLJxXVR6ZLm90j1/jgdmZU1ErxVCm32mrckuq5/Kuve4iOaxPyxC+S6IxCq5hezXethBeRFkPD0qmoc01v6VkmRZ5D80Yj9phVWiEhmC7Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=AHB0RNhrl6dbsUUHjouMTPZc4uRHXaDoSf2qgo70dL4=; b=lYJ/TD1GDGANaPu903DukIgQTRVwiJpuIb3HtkbTFLRh0Gx06TJS97w50P0shT941vYfMdOSPHX2oSmkF09ESSK+881xGV6txOH9a4i6hdSumvtvsYL41OVyECoR4f8NSdrNrhV09NLhDiWFh/D2lk1UQlRZg2IGGGJP/ozIthjESpo2b39RWKVuCertNG+i3/guPpHAZTGfMkvazRv8csAD2JKcOkRPAdB3HuxR7ekUKQZRwoXC4fMxSs5eHREOXCGI3V0EXJQoOe4OqKiK0x10dkkHlLHOcrlgLjJhYOELMLQIv2vutkbNJw+shZNI7UwB8gLFlqFlyfywg7+DtA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=amazon.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AHB0RNhrl6dbsUUHjouMTPZc4uRHXaDoSf2qgo70dL4=; b=OhvLjZ5FuPg3k+TP9t19VYRDh5Uk4ogKma9bvVaAqdem/Al3HDgInyrbENBtL1uoBE185XaWwh63VSTfDcX/LWUGYxepdfwbHAWulF9F7a/j8bNrr5uEqOLY26hB7AjwnMuHZDuIRnwBFAqeOORmHUgjH4XeWNFlu3SnAef9TgfXy+jIccRMiaieHVYRRRmd33da1AXz6iJDvlIEBKJjx4XLAfrCe0ehnVvdTucudT9hbw73E+BKDb8EdXTr0tTQh+xK4IjUdFcBMTu9f0sL0CuzeGR3uS+3wB9W8e4TfWDXluCt1gyA8XwqYKfBfC+wPxvgaeqzyHIemwB09876kA== Received: from BY5PR04CA0005.namprd04.prod.outlook.com (2603:10b6:a03:1d0::15) by MW4PR12MB7381.namprd12.prod.outlook.com (2603:10b6:303:223::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7849.20; Mon, 12 Aug 2024 12:59:50 +0000 Received: from CO1PEPF000042AA.namprd03.prod.outlook.com (2603:10b6:a03:1d0:cafe::89) by BY5PR04CA0005.outlook.office365.com (2603:10b6:a03:1d0::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7849.22 via Frontend Transport; Mon, 12 Aug 2024 12:59:50 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by CO1PEPF000042AA.mail.protection.outlook.com (10.167.243.39) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7828.19 via Frontend Transport; Mon, 12 Aug 2024 12:59:49 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Mon, 12 Aug 2024 05:59:30 -0700 Received: from nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Mon, 12 Aug 2024 05:59:28 -0700 From: Xueming Li To: Shai Brandes CC: , dpdk stable Subject: patch 'net/ena: fix bad checksum handling' has been queued to stable release 23.11.2 Date: Mon, 12 Aug 2024 20:49:31 +0800 Message-ID: <20240812125035.389667-95-xuemingl@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240812125035.389667-1-xuemingl@nvidia.com> References: <20240712110153.309690-23-xuemingl@nvidia.com> <20240812125035.389667-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.231.35] X-ClientProxiedBy: rnnvmail201.nvidia.com (10.129.68.8) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1PEPF000042AA:EE_|MW4PR12MB7381:EE_ X-MS-Office365-Filtering-Correlation-Id: 7ea9955e-d8f2-4382-e107-08dcbacea693 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|1800799024|82310400026|36860700013|376014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?LP38Ia7zY4DQpWAytrQNBhf4Voi7pHk7Vq5U3FTynBtfwdt4swY9umh2QmH9?= =?us-ascii?Q?eIegS/IeQ4aqaqlsEcsNfoWk/v/matjFclo9OECSHlQTtIhUDTS6VM+PuAJC?= =?us-ascii?Q?oC909Pz3CqSYz8QW7OZPhpFRiViayc0/T9McJB7nWnKplbQDJJtNVE4fU0RZ?= =?us-ascii?Q?ITAA/9pjhaXj5fHoELrChnSHMSPn31LweXFIHqiCkE8d82mWFtnGGQHCirHk?= =?us-ascii?Q?sMT/kZ6w/gSVlejoRvd8rVrm62FmHEGm7iUncSshWthcOqJ8ezm7K+5J98Kk?= =?us-ascii?Q?LJNOiMwe0jXauk0C4/AUHheGcWKolxPfWCxi83hyIOlJijxsNJXgjXb9zeDM?= =?us-ascii?Q?T70zggiuQrsjJZUw4FpaR0FWE7so6y/9bYeb+q5LzKLauVK5BCYH0EsS1kbs?= =?us-ascii?Q?uTZCKDixp2xHQv57lJO/IRQeQH7aCxNVua55oAsT1+Mzbl653QsacMl0zh16?= =?us-ascii?Q?hFX5NLL26Yhn94T9PURowDg0YEYzl5LMwbrItrPxLuvJJP47QrDt3rGlS/jt?= =?us-ascii?Q?x5W8DsrCBYv5R4vlBbW6IP6fe6brNsAFcd8qQJSJGPD8M92IbTf9Aqp+7jk5?= =?us-ascii?Q?qoXfFXGXMtiujjAUpGYBTbdzCHmeVq42d7vBK3fX6/zfpvUNq0hXeDfMXT6d?= =?us-ascii?Q?HPFc6A28is9x+biSjtI6UpgV6KFNTLvoao13ozFWsbyWlHprISvv0NCGzyMj?= =?us-ascii?Q?EegGFRkeyyOniQug4pvkm0BEkZwLXCbeTCyg2/f+xmJ7DBuIWyd+HrLGechx?= =?us-ascii?Q?dzyP26MQKJv7z5AWsVtcMO8H3Ir5qIJVL/nAY7M7/Rc7ahaZGa4x8Nt7a/pI?= =?us-ascii?Q?YtydVpJGD5vucLMoygQ4rNjNY8sbayPPb6mWArNyf/e+ERa/TvXyDLcxsvyc?= =?us-ascii?Q?SfvmCFmcbMvX5KEQTEq4k9MS1Y5th2UjRkb0h43z0xdk+MoxriAhfYZZ1k7m?= =?us-ascii?Q?SuQMFiViNfrEgYH0Afeub/28H7a336WbYOmGD0WDI4zvUJeMF0FiJ3M7DZcu?= =?us-ascii?Q?A7udj3pkMK3wdSVJq46JjISsSLHGJjD6S5lPY+PX/ihCjMi/aS1HbJPHhWNh?= =?us-ascii?Q?XJKJMxoG5PyhHDkPkV7ky7GRAwRePorHz4Azaa+cGnOo+JuNCcRQmPSIfnXi?= =?us-ascii?Q?pNhFKfnBFbTSHsXpHRmjx8/DaWTZWaoLABzfXwV3brmZsv9X3vvHqmxAmkEg?= =?us-ascii?Q?3gd8Yt/NuedgmOfC7u8MiVmIa8kIKK0kh6MMcXvflOk9BI/O7LmVxYYoynsb?= =?us-ascii?Q?tOwjcP6kmjVoM/vT13XjN22lAFMO/f6TbtfoLsVaUknQyx4SSWoP3csZPfQJ?= =?us-ascii?Q?88BjDDNqM9R6TLN8x7MjfTATPP8Iq2ra50RkQ+dh7cFzfouq/YPfBNDEfzwB?= =?us-ascii?Q?pZye5muNIMEBEtB/WhK950g+kj0fhDPd07F3n08hMUG9ya0b2TQosaziPHPq?= =?us-ascii?Q?C90wUpja7WuOuwwNxd7miMkWGpPtba4s?= X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230040)(1800799024)(82310400026)(36860700013)(376014); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Aug 2024 12:59:49.8631 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7ea9955e-d8f2-4382-e107-08dcbacea693 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1PEPF000042AA.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR12MB7381 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 23.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 08/14/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=23.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=23.11-staging&id=db4ca6f1cbd6e5dd9ae133f7609a7538fd5c889c Thanks. Xueming Li --- >From db4ca6f1cbd6e5dd9ae133f7609a7538fd5c889c Mon Sep 17 00:00:00 2001 From: Shai Brandes Date: Tue, 2 Jul 2024 17:46:22 +0300 Subject: [PATCH] net/ena: fix bad checksum handling Cc: Xueming Li [ upstream commit fa4bb7025255036fcff9556c637efa2627ac4af4 ] Removed a workaround for a false L4 bad Rx csum indication from the device. The workaround was to set it as unknown so the application would check it instead. The issue was fixed in the device, thus the driver bad csum handling should be fixed in the PMD. Fixes: b2d2f1cf89a6 ("net/ena: fix checksum flag for L4") Signed-off-by: Shai Brandes --- drivers/net/ena/ena_ethdev.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c index e122a55fa4..676c8cbcc3 100644 --- a/drivers/net/ena/ena_ethdev.c +++ b/drivers/net/ena/ena_ethdev.c @@ -653,13 +653,7 @@ static inline void ena_rx_mbuf_prepare(struct ena_ring *rx_ring, } else { if (unlikely(ena_rx_ctx->l4_csum_err)) { ++rx_stats->l4_csum_bad; - /* - * For the L4 Rx checksum offload the HW may indicate - * bad checksum although it's valid. Because of that, - * we're setting the UNKNOWN flag to let the app - * re-verify the checksum. - */ - ol_flags |= RTE_MBUF_F_RX_L4_CKSUM_UNKNOWN; + ol_flags |= RTE_MBUF_F_RX_L4_CKSUM_BAD; } else { ++rx_stats->l4_csum_good; ol_flags |= RTE_MBUF_F_RX_L4_CKSUM_GOOD; -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-08-12 20:44:05.555819657 +0800 +++ 0094-net-ena-fix-bad-checksum-handling.patch 2024-08-12 20:44:02.365069347 +0800 @@ -1 +1 @@ -From fa4bb7025255036fcff9556c637efa2627ac4af4 Mon Sep 17 00:00:00 2001 +From db4ca6f1cbd6e5dd9ae133f7609a7538fd5c889c Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit fa4bb7025255036fcff9556c637efa2627ac4af4 ] @@ -13 +15,0 @@ -Cc: stable@dpdk.org @@ -21 +23 @@ -index 4e7171e629..b43b913903 100644 +index e122a55fa4..676c8cbcc3 100644 @@ -24 +26 @@ -@@ -674,13 +674,7 @@ static inline void ena_rx_mbuf_prepare(struct ena_ring *rx_ring, +@@ -653,13 +653,7 @@ static inline void ena_rx_mbuf_prepare(struct ena_ring *rx_ring,