From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CA9C4457A1 for ; Mon, 12 Aug 2024 15:00:14 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BB66E4065B; Mon, 12 Aug 2024 15:00:14 +0200 (CEST) Received: from NAM02-DM3-obe.outbound.protection.outlook.com (mail-dm3nam02on2079.outbound.protection.outlook.com [40.107.95.79]) by mails.dpdk.org (Postfix) with ESMTP id 6C53140654 for ; Mon, 12 Aug 2024 15:00:13 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=P7zcJMeJPG7At/CRYTvyP8WbKskWdEXwdmAg4COgbNERXMgAE8ynwi0iGvGrqLqC3DrALr+w/7CkxcliB3BXOUZ8bSIQmUEAG+HHOI/bXzocQm6cUYMgDXmBorm80fu20q8EFpZ9QdQFHKN+xfqGAonyHeXV3TSwTLuOPxOpjCupR+kDybdPSExeI+D4tZZmrATSKZf5hTwy54Ps2zaHz9NpOIlNbw2PSH+be05VscCkUgpF1r+U0PvSDbfK1M3lGHGfdvUvmh5yOD/BFcwE7xvBDCaViKCtMoAO2sxqmGw6ewmDlocDv9IdKxcq+V9bhqIOmRnd6FIRtY0tIkbkBg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bWJoA1rwjK+b0f2K6HuII0ghtNFLCmABZik+rFKx5ek=; b=kN+FopkXVoRFfzXPNYzydQvbT3W+lQJZeKfBsjNgu90sfit7n4km6mhvWcrIs/lE9arlO8z75W73N0bxI9SEg4Oy1FCjeL/0J8a0kI6PjpwQGbfqWZ+23w5CMi7PxbfTiSyN7KnggkwTVJQB7rt9hasjrJXOQb8kXdjAyWsNUq/0Txi09hEZwFFBZzfhlyHc4PD6vva32TkGL7t+L7kaxCQLr6CsrAxRsOaX86FxE1NphrnosFzOEL0r/D42Lr5FKVH7334SDigof9YGULe6Exgsfp1seDKhnnWBQOQZvjFw5/vN4edH42jwvrYDoxedgF47sCSD2efRAABYpq8yKg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=amazon.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bWJoA1rwjK+b0f2K6HuII0ghtNFLCmABZik+rFKx5ek=; b=lrCW7lSkHljbJnYKjDjKcPJ3OOIdn1GKQA4X6c2Yply+47IOhCzbNtU/AmZmTZ+gSyeO63Q6eITQx2/vkZRMwBkH2IinQycSNSQupHEzhNuwR5Qn8WcK1izUM232mHXX39zr38JJsfH1mK5UjrUAgXKC8TmRjMu/nU8UJ5PS8DB9xTirriQgWhul5/dJh8ymt+VRzGC+Sqgaq0N0dfIDbZ0Fo86YW+tTWLpW+Y7OP+AskkKJ1YCob65F2t+CWGyLXEsjb3MUNpKhFYQEc20M4DJlzVzeTp4q+ifp4pe5XUNPD5oMuV8LUghaSSHKAaEwJC+5ChQIJYcvjqn7h6BpOg== Received: from BYAPR05CA0018.namprd05.prod.outlook.com (2603:10b6:a03:c0::31) by IA0PR12MB8374.namprd12.prod.outlook.com (2603:10b6:208:40e::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7849.20; Mon, 12 Aug 2024 13:00:08 +0000 Received: from CO1PEPF000042AD.namprd03.prod.outlook.com (2603:10b6:a03:c0:cafe::58) by BYAPR05CA0018.outlook.office365.com (2603:10b6:a03:c0::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7875.13 via Frontend Transport; Mon, 12 Aug 2024 13:00:07 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by CO1PEPF000042AD.mail.protection.outlook.com (10.167.243.42) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7828.19 via Frontend Transport; Mon, 12 Aug 2024 13:00:07 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Mon, 12 Aug 2024 05:59:49 -0700 Received: from nvidia.com (10.126.230.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Mon, 12 Aug 2024 05:59:48 -0700 From: Xueming Li To: Shai Brandes CC: , dpdk stable Subject: patch 'net/ena: fix return value check' has been queued to stable release 23.11.2 Date: Mon, 12 Aug 2024 20:49:32 +0800 Message-ID: <20240812125035.389667-96-xuemingl@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240812125035.389667-1-xuemingl@nvidia.com> References: <20240712110153.309690-23-xuemingl@nvidia.com> <20240812125035.389667-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.230.35] X-ClientProxiedBy: rnnvmail201.nvidia.com (10.129.68.8) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1PEPF000042AD:EE_|IA0PR12MB8374:EE_ X-MS-Office365-Filtering-Correlation-Id: 68417883-8126-49e6-90a7-08dcbaceb12c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|82310400026|376014|36860700013|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?th0TPFNbJqF52sjvMfEYfrHxyOzeyPsOoq6sPHnoAndFiQ0KmAdD5WSoYTP8?= =?us-ascii?Q?sEBFP+k6o7YTaAsBr8kJ6beo8j7kNi5Rd+6DoCp9Bfuy7QtTHwFGY+plTx4x?= =?us-ascii?Q?qHmOKwKli61sdE3JjXjrS/1DW+Wr/cSNha2KSB4bgpQMu8/voqSmdi/5jO/W?= =?us-ascii?Q?UwXOPIMerIpYU/qbgFmAE7GeWVIuXDUP5X2Z0nAjXMJBIn5F6v/sAN4tz0+N?= =?us-ascii?Q?N9lf2f341rldqOUIa6CKqrHdRZ/EBp8y9VvA39CxagTAk9IS6fA9oi2miem4?= =?us-ascii?Q?v4fvY6f3yqmRejnCfPbgrYfGAV3HVbwZKBvnla1hVtTl4W7+nG1CVXZldyjr?= =?us-ascii?Q?jmNYFEPeO0RQHQN+8wSKCnyyymHQHB6COVJzpSzLOwah8Ay0lJbm0oDyPlaA?= =?us-ascii?Q?/yH21cMIFF0J7R2VZhcSRTyDih/3x4IggPM5nBa/Y2TPSXoViCoeTonN3Vhj?= =?us-ascii?Q?AhKUzDy7g2g7E3olGGW0djgAgGTrzzYK0LzC7iheXXv/XJkWT+HdNZ2HLrSC?= =?us-ascii?Q?m5HcHR+Bx8U8h26OABSP+QDzS0b4FkqZQguJwtt3G/ht83S6q0dL6IaCboih?= =?us-ascii?Q?nofCD6s/2A/aDLwC1P+GwRv2d3FAtKo5IooI9eFkNlhtIh5wuKvD8lMdvXV+?= =?us-ascii?Q?iR8TaR1khfW3w5CIdctCXOXBQIwBFZ/8h2CuNsshK61lgkybAMsZ0bjMI68A?= =?us-ascii?Q?yKFbgqKjEd6zu652VB8Yw4On+BOVRdFkdSmE6LVNT4i11gZncCp8o9DhG35y?= =?us-ascii?Q?+a03r8t96Q7N02al8P8K/MuMwRuOK1Tlz4BueX7PsQlG0Vkz+SOZYVsiaLJM?= =?us-ascii?Q?PfP6mcdf48PM+DK1QNP+mMWlbm/Q20tUJ1A73pBGJhfdj0kl8d9KUluJlkD+?= =?us-ascii?Q?THX3E9ab8WahRUvZKBHebmud9xQbZ/zbRXiLzdF7Yqx0B0Tl0Z2fS80iiti8?= =?us-ascii?Q?pVsHCZQF2oRlL4BtOZladkqT2OBlcoGCQ/z3qsQW65VUy4ZDGqdfXgIlB+Rz?= =?us-ascii?Q?WNN0btQZS/vvOMdOGE8gYJDlERezwd9faNM6E5KQiZE0pYC4rgB5VeHUf2TV?= =?us-ascii?Q?2BoC/7Mlv3R8e86zR8FuQ2nxEFssGw16/OlRO/lCsDyveyw1DfiPgtgHXKVo?= =?us-ascii?Q?zGxo3E5rkQ0FTA9uFaJgGtwTKIycsvmi5xyTeNl7+XI7FLtOtjEt0ko8qB+8?= =?us-ascii?Q?mjtlaJ9u3F4NXSN/ctYILoQkTisUiqIQ7vGtehG3dht0+6Mey2+HaapxyY62?= =?us-ascii?Q?YhtNyrTU/4LFzjRwibWodMeBKS8y7vQd7NaIBpSKq/NIdIBYP8/tV/nwGUbB?= =?us-ascii?Q?A1VbTecb3LRGq4TuHOBOJj61pnuS85JFh0BlZw67deDymfkfXdcO///nsrnJ?= =?us-ascii?Q?BwPJEAgG9fMvsWCr+EOngezbGfp+Pc5pOg+fuutc2Q/JJwLbIX/OoNrXnkrO?= =?us-ascii?Q?6Vj9zgVwvn/tB2xqr4ktXZ55PlG1TIk9?= X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230040)(82310400026)(376014)(36860700013)(1800799024); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Aug 2024 13:00:07.6410 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 68417883-8126-49e6-90a7-08dcbaceb12c X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1PEPF000042AD.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR12MB8374 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 23.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 08/14/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=23.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=23.11-staging&id=ffba3914ad7bc4a63b24e678d83e02dd87f652f9 Thanks. Xueming Li --- >From ffba3914ad7bc4a63b24e678d83e02dd87f652f9 Mon Sep 17 00:00:00 2001 From: Shai Brandes Date: Tue, 2 Jul 2024 17:46:23 +0300 Subject: [PATCH] net/ena: fix return value check Cc: Xueming Li [ upstream commit 8936b01a512a8e25a7369d282a17b9b09c55728b ] Removed the sign inversion for when checking if ena_com_set_host_attributes returns ENA_COM_UNSUPPORTED. ENA_COM_UNSUPPORTED is defined as -EOPNOTSUPP, so the extra sign inversion is wrong. Fixes: 3adcba9a8987 ("net/ena: update HAL to the newer version") Signed-off-by: Shai Brandes --- drivers/net/ena/ena_ethdev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c index 676c8cbcc3..6d8e36263b 100644 --- a/drivers/net/ena/ena_ethdev.c +++ b/drivers/net/ena/ena_ethdev.c @@ -791,7 +791,7 @@ static void ena_config_host_info(struct ena_com_dev *ena_dev) rc = ena_com_set_host_attributes(ena_dev); if (rc) { - if (rc == -ENA_COM_UNSUPPORTED) + if (rc == ENA_COM_UNSUPPORTED) PMD_DRV_LOG(WARNING, "Cannot set host attributes\n"); else PMD_DRV_LOG(ERR, "Cannot set host attributes\n"); @@ -835,7 +835,7 @@ static void ena_config_debug_area(struct ena_adapter *adapter) rc = ena_com_set_host_attributes(&adapter->ena_dev); if (rc) { - if (rc == -ENA_COM_UNSUPPORTED) + if (rc == ENA_COM_UNSUPPORTED) PMD_DRV_LOG(WARNING, "Cannot set host attributes\n"); else PMD_DRV_LOG(ERR, "Cannot set host attributes\n"); -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-08-12 20:44:05.582382555 +0800 +++ 0095-net-ena-fix-return-value-check.patch 2024-08-12 20:44:02.365069347 +0800 @@ -1 +1 @@ -From 8936b01a512a8e25a7369d282a17b9b09c55728b Mon Sep 17 00:00:00 2001 +From ffba3914ad7bc4a63b24e678d83e02dd87f652f9 Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit 8936b01a512a8e25a7369d282a17b9b09c55728b ] @@ -12 +14,0 @@ -Cc: stable@dpdk.org @@ -20 +22 @@ -index b43b913903..67a1d86f9a 100644 +index 676c8cbcc3..6d8e36263b 100644 @@ -23 +25 @@ -@@ -812,7 +812,7 @@ static void ena_config_host_info(struct ena_com_dev *ena_dev) +@@ -791,7 +791,7 @@ static void ena_config_host_info(struct ena_com_dev *ena_dev) @@ -32 +34 @@ -@@ -856,7 +856,7 @@ static void ena_config_debug_area(struct ena_adapter *adapter) +@@ -835,7 +835,7 @@ static void ena_config_debug_area(struct ena_adapter *adapter)