From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 44FEC457A1 for ; Mon, 12 Aug 2024 15:00:19 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4089A40668; Mon, 12 Aug 2024 15:00:19 +0200 (CEST) Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2047.outbound.protection.outlook.com [40.107.237.47]) by mails.dpdk.org (Postfix) with ESMTP id C107F40654 for ; Mon, 12 Aug 2024 15:00:16 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=MwwXv3B/+pu/WkwkAoS52XgNKejKCN5jbnF8A9c4IS8FxB71UlIN+hXs5VeI7r77tSrEDQZgDiq26Hq7lvRxcT6SdUu6pi8r6GZk1e1q7WGyyo9HOcDygF2vVBGNPFt0f5FbgAjoGauP2tu4ZdR8iexyqVnJw4zwFiRwXHlpZI5tjIPjR1lqAr/kxg4y4mYl+L5kO3KicPvoCyeJy0gtsnHgBGVxK8M6QNF6MRwAtIzITEPs84PYx2Ct281uwjPoAtrFqT+lEAYIsBo8monyaZ47jHHLkZU+nu4uAwplnyEK15uGU4kdQGWbJOsvPuz1UOu3l3C2oLdax60AmCkTwg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=B/sIo0Of7f+tg1UALCf4GQ5h1mhuyNbqZV9VZHbIO9M=; b=rnkAGbcXbf6BZq5jcaXHA0T4xn2/FQPsSJ/xN27vTh/jzw/hkyP1dU9jMvD87GJXLtVtd8JJhdDV2DVQ3oEYsAsP+uvSzN7u9KApNliVTPyBz0TWesx7phaHrkiWmt+Sus/yECwkQjzOL5LIOFoT1x+lIz6PJE9aSiLm2DqVJDneOvtZdf7wyAwekEwB4t2Y3Lul2hmWLKDQ/Eqn0MYx3GUBbqntKda2HmUzX5pDTWIvLX+hB/uDlDz8t/8EvCQfE1agz6Ei2ce/flNLJMmOx2HjShuKL8QbevyGpgWPfMtFaHH4UgQdj1os5P21vh16r5/fR7fyLBjmdI1df/c63Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=amazon.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=B/sIo0Of7f+tg1UALCf4GQ5h1mhuyNbqZV9VZHbIO9M=; b=oTOHRaH3ucEUGuFhdTlGQvJFK+gA9M6QbPJJKtcMakD7r/Yhf4fg+ywK4SSOrysqicpnZD5jacReauHNjUjO+XEBLvN5UcAR5Uf9LyntaTZ8SU+wn9fYSws8n4A8I4VV5kI7rYZtROi8WdD7SyPeYN//aWui9JLu42QonOOUuAbO0bwMtFHqBYXCAinnkxtFRmOjmc2FwAAXBfl0/JFQej1Fn1z2IW2GqyD2vSZtpmUv2hKq3eu4jPacoawev9Ssw6P6QOnSFOXc3eoM8+SzoUuAwL1gsUbyeUQP5Z2WE1PFUJGb6PWmYl+UlnxFgtUJNmIEmyALoIbpOff03H896A== Received: from BYAPR05CA0004.namprd05.prod.outlook.com (2603:10b6:a03:c0::17) by DS7PR12MB6167.namprd12.prod.outlook.com (2603:10b6:8:98::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7849.20; Mon, 12 Aug 2024 13:00:12 +0000 Received: from CO1PEPF000042AD.namprd03.prod.outlook.com (2603:10b6:a03:c0:cafe::81) by BYAPR05CA0004.outlook.office365.com (2603:10b6:a03:c0::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7875.15 via Frontend Transport; Mon, 12 Aug 2024 13:00:11 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by CO1PEPF000042AD.mail.protection.outlook.com (10.167.243.42) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7828.19 via Frontend Transport; Mon, 12 Aug 2024 13:00:11 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Mon, 12 Aug 2024 05:59:51 -0700 Received: from nvidia.com (10.126.230.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Mon, 12 Aug 2024 05:59:50 -0700 From: Xueming Li To: Shai Brandes CC: , dpdk stable Subject: patch 'net/ena: fix checksum handling' has been queued to stable release 23.11.2 Date: Mon, 12 Aug 2024 20:49:33 +0800 Message-ID: <20240812125035.389667-97-xuemingl@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240812125035.389667-1-xuemingl@nvidia.com> References: <20240712110153.309690-23-xuemingl@nvidia.com> <20240812125035.389667-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.230.35] X-ClientProxiedBy: rnnvmail201.nvidia.com (10.129.68.8) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1PEPF000042AD:EE_|DS7PR12MB6167:EE_ X-MS-Office365-Filtering-Correlation-Id: 12979ee1-4b46-4abc-77aa-08dcbaceb35a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|36860700013|376014|82310400026|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?gNUrxmulVi8TBmZJriSimacDKeyKbE18LLIZ0pmG4iJXbglq1sP41f8E4ktA?= =?us-ascii?Q?E77XZphi4OPMCKx+WhhUdEg0/zEnRAovK+MrHtMcrstH9j/AcDhZvW4d+8aC?= =?us-ascii?Q?+tpkwznNAZbS4Hr0U8WbNP195aGn76jQizLF46tKsOqisHUoo/E7GGElcn6N?= =?us-ascii?Q?1m0eqOMZ3g57yxAp+rjCmJQCwe7RQu/ad/R7Etf060PYmFKgetzZzNH6fiTm?= =?us-ascii?Q?HupJVd6skLzRXoDmDEBhA+35MAaaP9gbiZIfgVR5x/sHBJgL/Gs37zomzroe?= =?us-ascii?Q?XkAWbjnHmtHq6jNAIZcXoV8xD9cJvIxSuKlGOF8NgeHKAJUq/nuG11oI1Eh7?= =?us-ascii?Q?BqxhSNKWF4qkE7giwa4DKXyT4TSB1sLFeuh7xje3d24xDD+DaFzGujhQeogB?= =?us-ascii?Q?2KRacbazQpWuTfUw8ciq9vIMCib78xaHrkqZUtYSmer3N8Efvzv/dZxYbMPX?= =?us-ascii?Q?MZqMzPRrfV89gPq8dyTosvNgsrzMOWaiiGJGn1tzzUmiQeWM15ZSG8JdLT08?= =?us-ascii?Q?4nhVW5QXYs56y2pN3KdpC5L/NV/zR7kmTs9dOuWePQD0s59lz+d9SNu79EVW?= =?us-ascii?Q?tEi+tC2tCUpb4YArHFrTrhRNSqUzkzq8NtQSlI3C5jzm1WwLmMQ4wDV02xdt?= =?us-ascii?Q?IQhZB8O7JCKKyOQJc0Q/mzI6HWBechBIwhH7Rmj3bA2ZiSz+ElkLtbicIBNc?= =?us-ascii?Q?Jk4ibl1eKiCpG1oViQdJMvSHxhxHsEMIpVVB2acUedU7B6zBm2gVHG8bCpvg?= =?us-ascii?Q?937t7lebQzMWUN/QP4v8+bAQg79PjJEnW4dbasJCxyV+8LDeFMxR7vA7VF4M?= =?us-ascii?Q?jAncOqWV/DxrLjqo0HSUWt/+UD0+HqUIi9HgKqtxz0l8P6Y2xfL7ruO988bt?= =?us-ascii?Q?rZrmG5cwKtAOnebVq5HXxciPyz7uN7w8Oyw3Gmg8rDzJ5S27+HRXL4x6zOfd?= =?us-ascii?Q?0CcZiIsnqRyB5pARWQP6axCjYuhQf893UOcVn28OjCz89W+2QF+wGuvBCzNP?= =?us-ascii?Q?dXWJuz/Q/uxGKeJTIi8xdBE66TGPa66FPobUgNp8qw1pfUo4mrw8fA46KJVA?= =?us-ascii?Q?QWg5wIBu3aMt49wzsBUTfvUdoafwC+VimojlCIHroVFuHSFx+8j3J3VdPjGI?= =?us-ascii?Q?V7zWo+3aZVYgv9VBr8rhQouN5Nv4cANt6+QfvI0EWZ3wxxUEA+uEt6n9vKge?= =?us-ascii?Q?fpgK8Q1/JlwKHlnWbOGybTHPBoJPoahUEnhPbONSsiWOGp83t5Zi+x9EPeXI?= =?us-ascii?Q?NNy7UEEMITEEZdaDE0IAKh8hjwyoC3x2oxMcrVFVFY2zc4/UXItcSfwgfz8h?= =?us-ascii?Q?WxCXYd7xQTfyAkq5uy4rN9z2LaM0PhCGGYBCIEHLRhWAkJBfDqzHGR/0vD6V?= =?us-ascii?Q?A17Vb7mFEUaIdOCf5gD/CQIimpco4RjZ25WSZJeIa/KakyS+vA=3D=3D?= X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230040)(36860700013)(376014)(82310400026)(1800799024); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Aug 2024 13:00:11.2972 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 12979ee1-4b46-4abc-77aa-08dcbaceb35a X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1PEPF000042AD.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB6167 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 23.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 08/14/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=23.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=23.11-staging&id=316baf3f0b62c82bd5b4322c72e5f39ec0feaf79 Thanks. Xueming Li --- >From 316baf3f0b62c82bd5b4322c72e5f39ec0feaf79 Mon Sep 17 00:00:00 2001 From: Shai Brandes Date: Tue, 2 Jul 2024 17:46:24 +0300 Subject: [PATCH] net/ena: fix checksum handling Cc: Xueming Li [ upstream commit f66055c7564050e55c7eab147d039bf01048829a ] This change fixes an issue where a non tcp/udp packet can be indicated to have an invalid csum. If the device erroneously tries to verify the csum on a non tcp/udp packet it will result in false indication that there is a csum error. This change make the driver ignore the indication for csum error on such packets. Fixes: 84daba9962b5 ("net/ena: add extra Rx checksum related xstats") Signed-off-by: Shai Brandes --- drivers/net/ena/ena_ethdev.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c index 6d8e36263b..f3962aa76e 100644 --- a/drivers/net/ena/ena_ethdev.c +++ b/drivers/net/ena/ena_ethdev.c @@ -648,7 +648,8 @@ static inline void ena_rx_mbuf_prepare(struct ena_ring *rx_ring, packet_type |= RTE_PTYPE_L3_IPV6; } - if (!ena_rx_ctx->l4_csum_checked || ena_rx_ctx->frag) { + if (!ena_rx_ctx->l4_csum_checked || ena_rx_ctx->frag || + !(packet_type & (RTE_PTYPE_L4_TCP | RTE_PTYPE_L4_UDP))) { ol_flags |= RTE_MBUF_F_RX_L4_CKSUM_UNKNOWN; } else { if (unlikely(ena_rx_ctx->l4_csum_err)) { -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-08-12 20:44:05.609000453 +0800 +++ 0096-net-ena-fix-checksum-handling.patch 2024-08-12 20:44:02.375069349 +0800 @@ -1 +1 @@ -From f66055c7564050e55c7eab147d039bf01048829a Mon Sep 17 00:00:00 2001 +From 316baf3f0b62c82bd5b4322c72e5f39ec0feaf79 Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit f66055c7564050e55c7eab147d039bf01048829a ] @@ -13 +15,0 @@ -Cc: stable@dpdk.org @@ -21 +23 @@ -index 67a1d86f9a..a18c94df28 100644 +index 6d8e36263b..f3962aa76e 100644 @@ -24 +26 @@ -@@ -669,7 +669,8 @@ static inline void ena_rx_mbuf_prepare(struct ena_ring *rx_ring, +@@ -648,7 +648,8 @@ static inline void ena_rx_mbuf_prepare(struct ena_ring *rx_ring,