From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1E83C457A1 for ; Mon, 12 Aug 2024 15:00:17 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 170484067C; Mon, 12 Aug 2024 15:00:17 +0200 (CEST) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2072.outbound.protection.outlook.com [40.107.223.72]) by mails.dpdk.org (Postfix) with ESMTP id 2886D40654 for ; Mon, 12 Aug 2024 15:00:16 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=JSKVvtKaz/lTCRJklwAkrNvz5gDX3lHONIwwJGAw3KiWWQcMpIbCEtYSxnsupEmIyg67ClYwzoykdHOhuogjgX/RG7oQ09xiuWOvbk8B91h7seeqy1NDrip++vfRLlZowT9YS12Y5MFu6e3xw5yYHYaQSsy49Q/7ymVmoJTJF5nqnuxL0gM0aVcudqICTBXNBFRSf2LvqX+bOr5DBIC2Fc8ERiHEhxOoh0N8oOh4f94GQMTMOllIIidme70SssZSHNk8guBbCp5XM7iF80cvvUBJGeCohSDN5iHKxNVH1p1LwSW0ZMDT+lvXiRiya3U+l7AbMeASvCp96PuwXfb4PQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FCH7U/QkHCJJHcHSIUxawoCVE2bBBmJVWwHaLoGXTWw=; b=J9Dcg2bR3ygsE+OmspKOd8Sw1Eqmba1k76PnNfI78SQfdIIfoI+qIlJBrNJGD75A9sWeRNfXFLisMXLo8LCETLmZEYWBIUWRfdDVR60STsDRAyBqc3UYRH76nrsB0vPJGeeba6GkRy0oyeHegFa2q+k9pqBSCmyzK9Zp/S0YD6apeDLfIK+7NBuHEfyH/MjwMy0B5/v7LvYbqxS9im4DvTfb6x1eHAx1Cl8UI1hhmQ1FpGfmzBj/vfi++cR1CYMfopN8bOEYidJQmfrSvtfxO9aY0uIC5J5TvmMayEwabz7FVN7yX03650YSDOniycmfh9QLHZ678JqoxxCZRDQfmw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=gmail.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FCH7U/QkHCJJHcHSIUxawoCVE2bBBmJVWwHaLoGXTWw=; b=arMu0Xg6iGzCzSYIHkiJ0eUtYRLcAF5cCxfl05ZisXFD6RI2ABG2w8Vok+brKgLMniVSdvx8xltQA5BKv3y0YsxDT8Sl34XpbfQKfAXQC5xBBw4yZ+8NTzHD/vsy7SsJOOhVaPrPT1rnaPzoP8EwPJIA8UiXuKBzoXUosVRffMS5U6nKU4HhP8SIK0ITzI2YerAJvf07q5E4Kn7SWZJGpVRppu4WmRIwykkU4eKfI/fdTwEKlfBHUFjre/829izd1T7uvyuevb9Fi+nk43daEAinjSeqxZ4zMuCT/BIgvbwi1kRcJ+OD9AU1mvCe6wb66jzOrMyFNOVAPMaLWjy4lg== Received: from SJ0PR13CA0141.namprd13.prod.outlook.com (2603:10b6:a03:2c6::26) by LV3PR12MB9439.namprd12.prod.outlook.com (2603:10b6:408:20e::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7849.20; Mon, 12 Aug 2024 13:00:13 +0000 Received: from CO1PEPF000042A7.namprd03.prod.outlook.com (2603:10b6:a03:2c6:cafe::b7) by SJ0PR13CA0141.outlook.office365.com (2603:10b6:a03:2c6::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7849.22 via Frontend Transport; Mon, 12 Aug 2024 13:00:12 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by CO1PEPF000042A7.mail.protection.outlook.com (10.167.243.36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7828.19 via Frontend Transport; Mon, 12 Aug 2024 13:00:12 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Mon, 12 Aug 2024 05:59:53 -0700 Received: from nvidia.com (10.126.230.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Mon, 12 Aug 2024 05:59:51 -0700 From: Xueming Li To: Shreesh Adiga <16567adigashreesh@gmail.com> CC: , Joshua Washington , "dpdk stable" Subject: patch 'net/gve: fix RSS hash endianness in DQO format' has been queued to stable release 23.11.2 Date: Mon, 12 Aug 2024 20:49:34 +0800 Message-ID: <20240812125035.389667-98-xuemingl@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240812125035.389667-1-xuemingl@nvidia.com> References: <20240712110153.309690-23-xuemingl@nvidia.com> <20240812125035.389667-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.230.35] X-ClientProxiedBy: rnnvmail201.nvidia.com (10.129.68.8) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1PEPF000042A7:EE_|LV3PR12MB9439:EE_ X-MS-Office365-Filtering-Correlation-Id: 0c30d315-4ab1-4e38-5f4b-08dcbaceb3df X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|36860700013|376014|1800799024|82310400026; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?GqoofaoxUHJRXicPH43JIg23Udi4hsvy1EQEW+iewF7njyffsibNJqMoSU4F?= =?us-ascii?Q?cEm0aYiBXjfyI2UL4ZqSEhtw/mWhd7pdtNSRKWHEU2Sy73as66NeEm8AeFd6?= =?us-ascii?Q?il3eP82fnsFZfmACw0dq3y6nvqA4Fz2mV0xh6fCY+12eg7fyVhfgsxFj8wZA?= =?us-ascii?Q?iJ2V9s3swDJQ9lssZY79yYSh26wAX7e4pqSv+NNC9P3vf30eCiRgcgtxi4Ho?= =?us-ascii?Q?Y+ZpbSUprGHW7RRXxsi5wcaqSlW0seGRzVEJCmXVNqLSVHtGtifKPOp2Epl4?= =?us-ascii?Q?n3b4trnqHHd2KhSwcX/1Hy+x/3ASR66enHDDFWxtWM4HJTLVCbZiNsyMe3lN?= =?us-ascii?Q?lUGbu65u5Fi4u5JJFrBxhiVtpWRocsvoyTccf77mHa2j4jza2Katke1kVZQ9?= =?us-ascii?Q?eESjEm0wX7oM9sZ8cRnVB/7Ret38S5OUgFCusZAJInOg27i4lWUdh2oD97lz?= =?us-ascii?Q?zzs7Dx19OjqcLcbYuA05Cs+zTakAPf6UTjaAVCI+994ERsyLTYQwoef3zXl/?= =?us-ascii?Q?xp+7veaKMuHyFQAotYek56WAi6m3Kp59QWonH7DUM397hHrc7x4uYw5RObRJ?= =?us-ascii?Q?A76XMQIs/JZsVriPKsEiOlK/VSjAcoNneKfeW3CVIzWtgROup2n1Ml913aql?= =?us-ascii?Q?tzCOWOYaGLPFRQB7alNr6gGL1wKJfxTDBPUkYSRrAKHCt8xxy5BJ/OpD0VLJ?= =?us-ascii?Q?v/0Pga9hEUtgwl1QB9rRaB4F2EmM8ZSHJ2k784U3NvR9/VOokxO7O5YVUrDj?= =?us-ascii?Q?JJ/T6F7f5CV2yDgPVqoWUcl+3PmdDBZfWPoRmIeFIwB4lEjjIxj2rBuSyjdk?= =?us-ascii?Q?0nKwCz0+0XEsjWl5NIwZcrsZ7kjpmfN/G2w03ZJNyG2mGZVN6NDYiyuI2M+O?= =?us-ascii?Q?LhKgnIRYghfDWv7SmG3weoiRAjSL2alcW9s40pBb/AeKYYqXgO1/MWeTvBKX?= =?us-ascii?Q?GzAzGX/i/wT3na6stb7o/8dX+i7i22lF9UBCAX0Of5XcbZjmmAfFh6RqYxML?= =?us-ascii?Q?Xuce4K7+iAhQXBUxqpsURbd/kyyhKMiU9PwtsxOFarXUW6Sz1QXgb5OPJB4E?= =?us-ascii?Q?EfW+AYY7nKeHxeQRAeueUaC6vCJiPeYCuV0JpewsVqOn1m5fVwzDyjcqtuii?= =?us-ascii?Q?7uGzz2KTH8Yz+F7OVlEFbNkpGo+q0G21ppbQtHKF7r97w+42K4ze6/rRjXN5?= =?us-ascii?Q?W0DMCScAcWEZbrXK6Devy5pfeXa1jWzNylCwppPatFPnTLfACLsDLI72XVSt?= =?us-ascii?Q?f2AGX7Zo7is8qwpyH3oupz3yy4wlEQFLMzQldsVd0BpHgMb6mdYx3JXvWvk4?= =?us-ascii?Q?TRe3tJ6uhuv3TeAxLRQ3l9ikswBSvgV/I0nt4zRnC5Tf1w2MUDeMrphwnZOj?= =?us-ascii?Q?6UcCF5kf4iBN3+07UllNHqyPE6a1y9v20sRNsAfV1vzJGXMyxRbOM6dBYogS?= =?us-ascii?Q?9kVQ7k6lT8GdvLDRg0l4d650a9BxpYKV?= X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230040)(36860700013)(376014)(1800799024)(82310400026); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Aug 2024 13:00:12.1838 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0c30d315-4ab1-4e38-5f4b-08dcbaceb3df X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1PEPF000042A7.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV3PR12MB9439 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 23.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 08/14/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=23.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=23.11-staging&id=c90d304f0eed545d8f7ec36ceacf04778c856a7c Thanks. Xueming Li --- >From c90d304f0eed545d8f7ec36ceacf04778c856a7c Mon Sep 17 00:00:00 2001 From: Shreesh Adiga <16567adigashreesh@gmail.com> Date: Wed, 3 Jul 2024 19:01:53 +0530 Subject: [PATCH] net/gve: fix RSS hash endianness in DQO format Cc: Xueming Li [ upstream commit b0ab5e931135664a554e0fd1e28fe11ee73f4463 ] The hash field in struct gve_rx_compl_desc_dqo defined in gve_desc_dqo.h has the type __le32. Therefore the hash must be read in little endian rather than big endian. Bugzilla ID: 1441 Fixes: 45da16b5b181 ("net/gve: support basic Rx data path for DQO") Signed-off-by: Shreesh Adiga <16567adigashreesh@gmail.com> Acked-by: Joshua Washington --- .mailmap | 1 + drivers/net/gve/gve_rx_dqo.c | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/.mailmap b/.mailmap index 24c450efaa..38af1e8603 100644 --- a/.mailmap +++ b/.mailmap @@ -1319,6 +1319,7 @@ Shiyang He Shlomi Gridish Shougang Wang Shraddha Joshi +Shreesh Adiga <16567adigashreesh@gmail.com> Shreyansh Jain Shrikrishna Khare Shuai Zhu diff --git a/drivers/net/gve/gve_rx_dqo.c b/drivers/net/gve/gve_rx_dqo.c index 7c7a8c48d0..a56cdbf11b 100644 --- a/drivers/net/gve/gve_rx_dqo.c +++ b/drivers/net/gve/gve_rx_dqo.c @@ -127,7 +127,7 @@ gve_rx_burst_dqo(void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t nb_pkts) rxm->ol_flags = 0; rxm->ol_flags |= RTE_MBUF_F_RX_RSS_HASH; - rxm->hash.rss = rte_be_to_cpu_32(rx_desc->hash); + rxm->hash.rss = rte_le_to_cpu_32(rx_desc->hash); rx_pkts[nb_rx++] = rxm; bytes += pkt_len; -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-08-12 20:44:05.633803551 +0800 +++ 0097-net-gve-fix-RSS-hash-endianness-in-DQO-format.patch 2024-08-12 20:44:02.375069349 +0800 @@ -1 +1 @@ -From b0ab5e931135664a554e0fd1e28fe11ee73f4463 Mon Sep 17 00:00:00 2001 +From c90d304f0eed545d8f7ec36ceacf04778c856a7c Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit b0ab5e931135664a554e0fd1e28fe11ee73f4463 ] @@ -12 +14,0 @@ -Cc: stable@dpdk.org @@ -22 +24 @@ -index 874df4d162..9bc25b1521 100644 +index 24c450efaa..38af1e8603 100644 @@ -25 +27 @@ -@@ -1356,6 +1356,7 @@ Shiyang He +@@ -1319,6 +1319,7 @@ Shiyang He @@ -34 +36 @@ -index f08b58c78d..5efcce3312 100644 +index 7c7a8c48d0..a56cdbf11b 100644 @@ -37 +39 @@ -@@ -161,7 +161,7 @@ gve_rx_burst_dqo(void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t nb_pkts) +@@ -127,7 +127,7 @@ gve_rx_burst_dqo(void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t nb_pkts) @@ -39,2 +41,2 @@ - rxm->ol_flags |= RTE_MBUF_F_RX_RSS_HASH | - gve_parse_csum_ol_flags(rx_desc, rxq->hw); + + rxm->ol_flags |= RTE_MBUF_F_RX_RSS_HASH;