From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 79460457B5 for ; Wed, 14 Aug 2024 04:51:07 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 718E340647; Wed, 14 Aug 2024 04:51:07 +0200 (CEST) Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on2104.outbound.protection.outlook.com [40.107.96.104]) by mails.dpdk.org (Postfix) with ESMTP id B6C09402E0 for ; Wed, 14 Aug 2024 04:51:05 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=xjXGcAWFdV5UUTLjFMYrRCBZEMTmNWwO4+1fl06nKxP3RJnUD2MtpWjkGrrnOjicB7H1WoTB7Ei6cGqop2LYL4DJeGeFoZSFTvh8+Pl1cilY54680CFyttDCXV/gvXWc0eQK37Ui4rD+WHzxkOreRUXfeWivA8gbygcBTqt0Ml85pzA6UuoFzIgX+CDNApBKq8vmZcVidlsCE4UOQZeuqW2o5B4jaIK8SXRvXdDwYWkjg46hxVT9PvN2yEAZz5WFYCOcZrkGudT93U+64Kw+8c9vjraARR+SyStehFzcFeOSEmL7fj6o2Y5e7n7GODrQLACjKio40Ay4oeDPBqcdAg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TmlB7ogTtf1w6KYSyM6ej47gwfK97txkaTmzAbruv4o=; b=BP/LDL6qzofHkH06kWRSyn2sMteuC1lg0tHCwlUPtdXvoJXYYPZuiJhvCii0GzIOM4LjRPPs6c7/K6jGhDM++GqUp050fiXwc2b1EaO6VKM38JbM5xv546mAgnJfnoCPnu8+y/IPqdTpPN6xkoLW/NwbA9SpOyMhsCLzPl9/lfH+8OetUG/BE+zp06TYpSvzu0nSZlMpNWNJQUza4s3s05hIklqcrKXD2h+j5YhFFeLqkf6Og8o0J0NW6hNvb3Uloj4ftQ5/9gMvJnwDVuvMpMSCkLBMUXKwW1OjENzdLnSjB3j2NxP2NdY/vOfusjuNi57xx8ZKZ6xKPGe6g17sMg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com; dkim=pass header.d=corigine.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TmlB7ogTtf1w6KYSyM6ej47gwfK97txkaTmzAbruv4o=; b=XB5mJe8plslQU58PHKCd9b6GUcXC1YfmUnUEpubSFAn1bvyRzCLYYLQC7a0XoiP8KLq50zFsOvuCG9GZobtWmscuWcjyBm3MhSvaGeTyI2eRh7Z/7HeegbsvoOsxcp9Z1k1WbdQeg/qEDz/0LYBIXOZnXnMrBWW+ZTlhvW6MeJc= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=corigine.com; Received: from SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) by IA2PR13MB6807.namprd13.prod.outlook.com (2603:10b6:208:4a8::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7849.22; Wed, 14 Aug 2024 02:51:02 +0000 Received: from SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::b900:5f05:766f:833]) by SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::b900:5f05:766f:833%4]) with mapi id 15.20.7849.019; Wed, 14 Aug 2024 02:51:02 +0000 From: Chaoyong He To: stable@dpdk.org Cc: oss-drivers@corigine.com, Chaoyong He Subject: [PATCH 23.11 2/2] net/nfp: forbid offload flow rules with empty action list Date: Wed, 14 Aug 2024 10:50:38 +0800 Message-Id: <20240814025038.1698473-3-chaoyong.he@corigine.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20240814025038.1698473-1-chaoyong.he@corigine.com> References: <20240814025038.1698473-1-chaoyong.he@corigine.com> Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: SI2PR01CA0052.apcprd01.prod.exchangelabs.com (2603:1096:4:193::11) To SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR13MB5545:EE_|IA2PR13MB6807:EE_ X-MS-Office365-Filtering-Correlation-Id: 9fec75ee-f4aa-45cf-fc50-08dcbc0beef9 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|376014|366016|1800799024|52116014|38350700014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?D2eCYhz/GwvqezoJg+W9C1eL6nc8WdXhU3S1+SCKNZSG6aGQzlw1I626myE2?= =?us-ascii?Q?ijAgLNKOSy0+XZhZLwmpEI9TnX7Hg2i4Lsq11dtBqmE6FsKePp9rhyr5O2Wn?= =?us-ascii?Q?JM9WNSNcwiy17L9ukbJlH+A0xOcxGh4C52Ez4XM/vWV2AR3A4ATTj9kUcSOD?= =?us-ascii?Q?n9XZDvVfREpitH3j38qaB+CNA5cxCaPKA6xIy/nacG42SJbC89CvaIcq82Q7?= =?us-ascii?Q?SAebmLCtZ/pYxfL99kuAeDHoYYWpGn+QqNEutl0a/MIOzm+wdGnGw94BfjUY?= =?us-ascii?Q?xpVDGPkOFW5TBTnkUziqZfrexXyXiAzRwgHk4XbaLPi6du3RWqsRuINg16xk?= =?us-ascii?Q?Ibuh8SVmVaITwED73TYhXMqhocCXQMSnriiGpY5h/5oXj7YidPfMLfz1idHd?= =?us-ascii?Q?K9jJF7DVPv8fxtne1UmFqjIVTgO6gEtnqFs1oirRdHhxCy9j+aUHASbU2Gek?= =?us-ascii?Q?NIVpCOz6BpuwxTkRfOxAYYWzLt0br6rDik2+zwsz5bhvK6oVYeauTMAA3R3B?= =?us-ascii?Q?fR47v4eFo9c84okgkfw0OK0fZwCSXjUycn84OTEVoIIafXIgPtWg3sLX6o3T?= =?us-ascii?Q?K4RO10buzVoxbSB5y3E+KsblyNxMP2rjHjzLFHzOn5yodn/XyGK6XfSv2caf?= =?us-ascii?Q?17gbdkAHJUSImR6ECPo4serywe99f0gc+8BkJXMkKQS0Vzb3p+OxtD1PFIjq?= =?us-ascii?Q?51L2RLjif4EFABWOnX4vyuXCCHLcYb7SGsf+dyBzGoDHE6NQ7K0kmGHtMByd?= =?us-ascii?Q?9p2avOJjv8M1zUjqWYF5U6Gk+zhskHtolJ1d54ueSI4HJX6kMvuILSDivPC0?= =?us-ascii?Q?37iGR02KqOpuB+n/Npub5qdBvyLE/UNXozb/5YbigpcXdabMgp4QgrpT4osR?= =?us-ascii?Q?SddQIUN84U3BsIVfI40YkUzv1brPTntInvA6FFKjT6sUueWYa7AC0ZY4wxg+?= =?us-ascii?Q?psJBtnMdd1LdazPPuQ9huUo+wgdBFnAZmXKmADCcooIV8j7Jy89VvMX5Br6v?= =?us-ascii?Q?tRVAy9ruGwk1peE0p0Sq1PD/nmjd0NZOj/yAx981aAUinvAXIpvISVp2BZOz?= =?us-ascii?Q?EbURz+5u1vFAWfFyeCCFEe3rZH568A/MvjRvTa3hgED6SIxZvu/UeKjjacN7?= =?us-ascii?Q?k0+oYTWZ9ZnQM9GGRZPeQTwGte2jTfeT8yAhX5KNgxHl2b0rcozxALg7OcAQ?= =?us-ascii?Q?OANdOTIlRkEaHRZOLkoybGRm1lYU4uBKMMzphUy7LyIyl795KdgBICpni2Ym?= =?us-ascii?Q?eQUvFyypUl4rWa5+bnN7Gutlp6rEWp0Ovo27QwijgqjK3N1ct5pYAcRPjMG6?= =?us-ascii?Q?l6XcNxk1L+TdLWiiFWV6aUfsZJP2f3Az/UQjwlhyg6SqVkC99zfuSvUqJ0+e?= =?us-ascii?Q?PDoRiUM=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR13MB5545.namprd13.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(366016)(1800799024)(52116014)(38350700014); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?toYZFelLnW//EY+2M0oRKxIoP2/ggV3HY7Dc/vOXmyxymTJ4I2hBPAWgM8Gc?= =?us-ascii?Q?mAD0yuFoG6xXvEkTvuJeLNeZcS7gVrT5THHSLDCEE37LOm5mSS+E5lzsOh+o?= =?us-ascii?Q?1smPkj8a86YYe+YDLheuNY0DMIV9+WQL0FhdVaRwsBmCTD7tM0p+BxrH3wRy?= =?us-ascii?Q?v1TEnLSyNAa1PBZlU1pA+noHX/onKioOdffU/O0SAtCfrDSHE0W4i8MRT4Ax?= =?us-ascii?Q?STgBU0u0e2GA/gHE6HyqlpYo9oPJQe2TtUtWxywqZXehRbl71c5UG+QlwhXb?= =?us-ascii?Q?8MaefCes1j5Ov3PmSdqs6xt+//jdJBmu0oS+nheao9pGZdbI50gFCxzTmbwT?= =?us-ascii?Q?pyVnorYCkrIN3gJXWScqei6Z++WB8c7moptUBbHmX7El5sHOHUfWlBFA3jP1?= =?us-ascii?Q?0OZpK5SwgIZuHnJtYWvjr2nAVD1AuX1AllrHb8X0CQq4N1Hqtw4dh8RoHbAJ?= =?us-ascii?Q?sShy+S6NsLSqV082RSOScUjoUh/hkFM9rHdzhlkEG2JDeLz/LNIOjPKorEH0?= =?us-ascii?Q?iDt3EMfeesuvMu+hPxjNF4Lv7ozhiWPsyW0J/+1xoqsBRkWKExj60+EwBlr2?= =?us-ascii?Q?zu7TkN2+A9kj48jDzSYIP9U592KJr53lLYdLYU7F29Eajx8f8DTa0Uad5Z6G?= =?us-ascii?Q?cnsSTKPp0wlgZM/JCXQiavt3aWaCpuzJorM8FHfH2ok9ohFQoLr02S2Ll3JP?= =?us-ascii?Q?aX1L36I22gItX8CLoDOSU+P2NQ/pc7hl3RFnyyL9WrrrJSOARFVPPsBDbiGo?= =?us-ascii?Q?xFm50X0FEcF8L3YXM8X9p7eHrsnqGBkDuJF/pqkwdiuyz/uQez4hzPaV/tDg?= =?us-ascii?Q?CwKA3prJGG4VJG+BF0loy7ODtivE9hC9eJqcjOXFdsPgzX8euZJS8WoGJI+o?= =?us-ascii?Q?jfXuLuWZ4ISq3yLd+K3pJkL8d8pizFl8UXwpQgu3hP3pYbNwnBYHKKSH9aYT?= =?us-ascii?Q?iP7K78L+hq42EmMkIa+N9/BjMYW1f5rb/XDfDhCzQXSWaVT7KcunbsmQsTMe?= =?us-ascii?Q?5OAQNvbD5DBQvD0JtcFCFhTceFdZ7A0+HFCDN1c2R9OrO4D7rneEQzguAReP?= =?us-ascii?Q?eb5q9eurRxbvNAjsW+GFcD+YICOvjUE+us37kJpwFJSAowtLyjFchMI690PM?= =?us-ascii?Q?ZHIuonyp/x25sLpMqHd+hU60TIepXDrgESmOO+yBF5v6U1h6gskglbcHRmxK?= =?us-ascii?Q?K/QycRE+4jrNTQI/oxAmGcTvd5SLdBhYVBdjq3a3GPcsGv2SP7sWj01Ih20n?= =?us-ascii?Q?/Ha2l0y0kJe+QLVj0okg1/FiBPgVdJsIX3Obw5aoGQpiaINQFEu/iBGdwWlz?= =?us-ascii?Q?scwRMy7jC3xTW72ciMRVDAUebu7T9xhKASs24EFK0UHnx08Y5J1efQIYiGhR?= =?us-ascii?Q?n2dFqai3XvfTQW+7oHiynp7HzOjD360/0DrIyrXvWpVUPVCUmDUbQczAxkvK?= =?us-ascii?Q?NOjN7yULI6hQ29oD7FVMUjy6zlk6q07+Ybyrf0StriMqC7mAlbaejr9SrOBx?= =?us-ascii?Q?K2Tw1xS6E3TB5TtSTQfaWjqGhEXzwvOslcCfEOEKUUo8Jz3ZlDVCkjpVqaNG?= =?us-ascii?Q?KsTbvuA5G6h+BO+Fjyu784N2YOmcMEf9zURtpk+9eds3A3yagO762vmEEUIt?= =?us-ascii?Q?Iw=3D=3D?= X-OriginatorOrg: corigine.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9fec75ee-f4aa-45cf-fc50-08dcbc0beef9 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR13MB5545.namprd13.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Aug 2024 02:51:02.2659 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 53TF+yPB0wXhSLjj3yWgd7J720vyPon5N1VzLKAU37Op1OuDp2zJCrCjnXsn83yB490Agb9c4aFNnzpPikiFM7VDWtr53KNw8uT/omFaQZ0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA2PR13MB6807 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org [ upstream commit 78bbab16282a2b6b8b3983677b7b1a32543b909b ] The original logic allow offload flow rules with empty action list, but the matched packets will be drop by the flower firmware. Fix this by forbidding offload this type flow rules. Fixes: 4d946034bf9c ("net/nfp: support basic flow actions") Signed-off-by: Chaoyong He --- drivers/net/nfp/nfp_flow.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/net/nfp/nfp_flow.c b/drivers/net/nfp/nfp_flow.c index 9ad434affb..91ebee5db4 100644 --- a/drivers/net/nfp/nfp_flow.c +++ b/drivers/net/nfp/nfp_flow.c @@ -3741,6 +3741,11 @@ nfp_flow_compile_action(struct nfp_flower_representor *representor, total_actions++; } + if (nfp_flow->install_flag && total_actions == 0) { + PMD_DRV_LOG(ERR, "The action list is empty"); + return -ENOTSUP; + } + if (drop_flag) nfp_flow_meta->shortcut = rte_cpu_to_be_32(NFP_FL_SC_ACT_DROP); else if (total_actions > 1) -- 2.39.1