From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C7DA645804 for ; Fri, 23 Aug 2024 18:23:17 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C27014337C; Fri, 23 Aug 2024 18:23:17 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 25ACA4336F for ; Fri, 23 Aug 2024 18:23:17 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1724430196; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PlpibJSgN6+7SZsSyI7BDrPPIkQ3GZQGFh9c7QA5uUg=; b=ZnkY3JP+925NTYEj0PYpHAft2MRIDoqHZCco++aodBOIFInWxcD2ZMOYa+8YqN3thP7RVA wEwfcIeLB4moHeBR8U6UlsOs009bEUD5Hfb7q6QT+CIYBLmCgsFl5pLu2imR8x2D73lWy4 o45Z8z4K0uN5AeAHTtetXbIotxl8Y54= Received: from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-615-78P1HF8mNUeICnEG2IOcaQ-1; Fri, 23 Aug 2024 12:23:13 -0400 X-MC-Unique: 78P1HF8mNUeICnEG2IOcaQ-1 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id B651F1955D4B; Fri, 23 Aug 2024 16:23:12 +0000 (UTC) Received: from rh.redhat.com (unknown [10.39.193.224]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 72B651956053; Fri, 23 Aug 2024 16:23:11 +0000 (UTC) From: Kevin Traynor To: Jiawen Wu Cc: dpdk stable Subject: patch 'net/ngbe: fix hotplug remove' has been queued to stable release 21.11.8 Date: Fri, 23 Aug 2024 17:18:50 +0100 Message-ID: <20240823161929.1004778-102-ktraynor@redhat.com> In-Reply-To: <20240823161929.1004778-1-ktraynor@redhat.com> References: <20240823161929.1004778-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.8 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 08/28/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/7436ea6a3aca1bde021b5a66916c54cc1c277035 Thanks. Kevin --- >From 7436ea6a3aca1bde021b5a66916c54cc1c277035 Mon Sep 17 00:00:00 2001 From: Jiawen Wu Date: Tue, 18 Jun 2024 15:11:42 +0800 Subject: [PATCH] net/ngbe: fix hotplug remove [ upstream commit c602202c346663572043b408a27cb98e20f31886 ] This bug occurs in OpenvSwitch. After adding a port bound to vfio-pci to ovs, detach it from ovs and then unbind it from vfio-pci(that is hotplug) will cause operating system to get stuck. Fixes: 6ee7e574cd48 ("net/ngbe: support probe and remove") Signed-off-by: Jiawen Wu --- drivers/net/ngbe/ngbe_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ngbe/ngbe_ethdev.c b/drivers/net/ngbe/ngbe_ethdev.c index 3038694042..7f7bedddba 100644 --- a/drivers/net/ngbe/ngbe_ethdev.c +++ b/drivers/net/ngbe/ngbe_ethdev.c @@ -527,5 +527,5 @@ static int eth_ngbe_pci_remove(struct rte_pci_device *pci_dev) return 0; - return rte_eth_dev_destroy(ethdev, eth_ngbe_dev_uninit); + return rte_eth_dev_pci_generic_remove(pci_dev, eth_ngbe_dev_uninit); } -- 2.46.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-08-23 17:18:12.720641784 +0100 +++ 0102-net-ngbe-fix-hotplug-remove.patch 2024-08-23 17:18:09.830430490 +0100 @@ -1 +1 @@ -From c602202c346663572043b408a27cb98e20f31886 Mon Sep 17 00:00:00 2001 +From 7436ea6a3aca1bde021b5a66916c54cc1c277035 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit c602202c346663572043b408a27cb98e20f31886 ] + @@ -11 +12,0 @@ -Cc: stable@dpdk.org @@ -19 +20 @@ -index 2a858b76d0..9d75e222c3 100644 +index 3038694042..7f7bedddba 100644 @@ -22 +23 @@ -@@ -548,5 +548,5 @@ static int eth_ngbe_pci_remove(struct rte_pci_device *pci_dev) +@@ -527,5 +527,5 @@ static int eth_ngbe_pci_remove(struct rte_pci_device *pci_dev)