From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3CCC045804 for ; Fri, 23 Aug 2024 18:23:31 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 37C2F4338D; Fri, 23 Aug 2024 18:23:31 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 8102543380 for ; Fri, 23 Aug 2024 18:23:29 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1724430209; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dcChetJ69odxirVQYddiiEH/b+r/MbeLi/vkdLJSDwQ=; b=NK0tEGl96P9EnjT0JB7PsBebLi8iQ3CSmNJcVba3brPTYq9dbB3i7kDiQKUnJg7Ksqf55N uGQWiYppl6Fw4Y0yrgYhottxpbgQmEDS4kK4MTQ6KH/+SoH398dse8FdHqc6LdH6hfzL8z LDOyKdLBVaiD7JXZ5UG/1cpLu+RFwpA= Received: from mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-530-UDCXv_XGMPC5eGZ7n1gCgg-1; Fri, 23 Aug 2024 12:23:25 -0400 X-MC-Unique: UDCXv_XGMPC5eGZ7n1gCgg-1 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 0663C19560B0; Fri, 23 Aug 2024 16:23:25 +0000 (UTC) Received: from rh.redhat.com (unknown [10.39.193.224]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id A01B41956053; Fri, 23 Aug 2024 16:23:23 +0000 (UTC) From: Kevin Traynor To: Shai Brandes Cc: dpdk stable Subject: patch 'net/ena: fix bad checksum handling' has been queued to stable release 21.11.8 Date: Fri, 23 Aug 2024 17:18:57 +0100 Message-ID: <20240823161929.1004778-109-ktraynor@redhat.com> In-Reply-To: <20240823161929.1004778-1-ktraynor@redhat.com> References: <20240823161929.1004778-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.8 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 08/28/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/082bd6be7b93ae090f2bdcc55fddc48c3bf16c2f Thanks. Kevin --- >From 082bd6be7b93ae090f2bdcc55fddc48c3bf16c2f Mon Sep 17 00:00:00 2001 From: Shai Brandes Date: Tue, 2 Jul 2024 17:46:22 +0300 Subject: [PATCH] net/ena: fix bad checksum handling [ upstream commit fa4bb7025255036fcff9556c637efa2627ac4af4 ] Removed a workaround for a false L4 bad Rx csum indication from the device. The workaround was to set it as unknown so the application would check it instead. The issue was fixed in the device, thus the driver bad csum handling should be fixed in the PMD. Fixes: b2d2f1cf89a6 ("net/ena: fix checksum flag for L4") Signed-off-by: Shai Brandes --- drivers/net/ena/ena_ethdev.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c index 1c61f793e6..84c41f1b9d 100644 --- a/drivers/net/ena/ena_ethdev.c +++ b/drivers/net/ena/ena_ethdev.c @@ -311,11 +311,5 @@ static inline void ena_rx_mbuf_prepare(struct rte_mbuf *mbuf, else if (unlikely(ena_rx_ctx->l4_csum_err)) - /* - * For the L4 Rx checksum offload the HW may indicate - * bad checksum although it's valid. Because of that, - * we're setting the UNKNOWN flag to let the app - * re-verify the checksum. - */ - ol_flags |= RTE_MBUF_F_RX_L4_CKSUM_UNKNOWN; + ol_flags |= RTE_MBUF_F_RX_L4_CKSUM_BAD; else ol_flags |= RTE_MBUF_F_RX_L4_CKSUM_GOOD; -- 2.46.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-08-23 17:18:12.913173354 +0100 +++ 0109-net-ena-fix-bad-checksum-handling.patch 2024-08-23 17:18:09.849430556 +0100 @@ -1 +1 @@ -From fa4bb7025255036fcff9556c637efa2627ac4af4 Mon Sep 17 00:00:00 2001 +From 082bd6be7b93ae090f2bdcc55fddc48c3bf16c2f Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit fa4bb7025255036fcff9556c637efa2627ac4af4 ] + @@ -13 +14,0 @@ -Cc: stable@dpdk.org @@ -21 +22 @@ -index 4e7171e629..b43b913903 100644 +index 1c61f793e6..84c41f1b9d 100644 @@ -24,3 +25,3 @@ -@@ -675,11 +675,5 @@ static inline void ena_rx_mbuf_prepare(struct ena_ring *rx_ring, - if (unlikely(ena_rx_ctx->l4_csum_err)) { - ++rx_stats->l4_csum_bad; +@@ -311,11 +311,5 @@ static inline void ena_rx_mbuf_prepare(struct rte_mbuf *mbuf, + else + if (unlikely(ena_rx_ctx->l4_csum_err)) @@ -35,2 +36,2 @@ - } else { - ++rx_stats->l4_csum_good; + else + ol_flags |= RTE_MBUF_F_RX_L4_CKSUM_GOOD;