From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6792C45804 for ; Fri, 23 Aug 2024 18:20:06 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 60A7F43389; Fri, 23 Aug 2024 18:20:06 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 5BB664338D for ; Fri, 23 Aug 2024 18:20:05 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1724430004; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Cje6z0imh+lnXGsCQigSOYfhqaiU5K6lZB969q2I/j0=; b=a2Xsg0l/oCDmoWdSaaXuDSGysPtMUSms/bvAadxJJo4AqkG1oHDKgW3YI2fAAGrPgaB4WN Bl252B8E8DKZHP2M++qYJ9BzK95/i0Kf17NTxyLXThSzQf4sterK2puzLxUDwoxwNXY/IP VUCETNH5e5HIRfkp9IlmYat4z/zGP28= Received: from mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-561-dnFoVO1rNFKV6j5D26YlRg-1; Fri, 23 Aug 2024 12:20:03 -0400 X-MC-Unique: dnFoVO1rNFKV6j5D26YlRg-1 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id A766719560A2; Fri, 23 Aug 2024 16:20:02 +0000 (UTC) Received: from rh.redhat.com (unknown [10.39.193.224]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 64AB01956053; Fri, 23 Aug 2024 16:20:00 +0000 (UTC) From: Kevin Traynor To: Jie Hai Cc: dpdk stable Subject: patch 'net/hns3: disable SCTP verification tag for RSS hash input' has been queued to stable release 21.11.8 Date: Fri, 23 Aug 2024 17:17:19 +0100 Message-ID: <20240823161929.1004778-11-ktraynor@redhat.com> In-Reply-To: <20240823161929.1004778-1-ktraynor@redhat.com> References: <20240823161929.1004778-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.8 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 08/28/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/8fb5749bc60ae63b56825ae4ac6358e8c4eb66b8 Thanks. Kevin --- >From 8fb5749bc60ae63b56825ae4ac6358e8c4eb66b8 Mon Sep 17 00:00:00 2001 From: Jie Hai Date: Wed, 3 Apr 2024 18:16:23 +0800 Subject: [PATCH] net/hns3: disable SCTP verification tag for RSS hash input [ upstream commit bb1f4717636f5b7d27f4f2fe30469b69d8910bd0 ] When the symmetric RSS algorithm is used, the same packet is expected to be hashed to the same queue in the upstream and downstream directions. The problem is that it could map the packets in the same SCTP connection to different NIC RX queues depending on the direction of packets. This is because the verification Tag is used as the RSS hash input for the SCTP packets, and the value depends on the peer end of the SCTP connection and could not be symmetrically used in the hardware-implemented RSS algorithm. In addition, the ethdev framework doesn't support setting SCTP V-tag as the RSS hash input. So disable it for all RSS hash algorithms. Signed-off-by: Jie Hai --- drivers/net/hns3/hns3_rss.c | 6 ++---- drivers/net/hns3/hns3_rss.h | 6 ++---- 2 files changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/net/hns3/hns3_rss.c b/drivers/net/hns3/hns3_rss.c index b587954508..3fce50519f 100644 --- a/drivers/net/hns3/hns3_rss.c +++ b/drivers/net/hns3/hns3_rss.c @@ -154,6 +154,5 @@ static const struct { BIT_ULL(HNS3_RSS_FIELD_IPV4_SCTP_EN_IP_D) | BIT_ULL(HNS3_RSS_FIELD_IPV4_SCTP_EN_SCTP_S) | - BIT_ULL(HNS3_RSS_FIELD_IPV4_SCTP_EN_SCTP_D) | - BIT_ULL(HNS3_RSS_FIELD_IPV4_SCTP_EN_SCTP_VER), + BIT_ULL(HNS3_RSS_FIELD_IPV4_SCTP_EN_SCTP_D), HNS3_RSS_TUPLE_IPV4_SCTP_M }, @@ -275,6 +274,5 @@ static const struct { BIT_ULL(HNS3_RSS_FIELD_IPV6_SCTP_EN_IP_D) | BIT_ULL(HNS3_RSS_FIELD_IPV6_SCTP_EN_SCTP_D) | - BIT_ULL(HNS3_RSS_FIELD_IPV6_SCTP_EN_SCTP_S) | - BIT_ULL(HNS3_RSS_FIELD_IPV6_SCTP_EN_SCTP_VER), + BIT_ULL(HNS3_RSS_FIELD_IPV6_SCTP_EN_SCTP_S), HNS3_RSS_TUPLE_IPV6_SCTP_M }, }; diff --git a/drivers/net/hns3/hns3_rss.h b/drivers/net/hns3/hns3_rss.h index 5c0f0b75f0..94c667dad6 100644 --- a/drivers/net/hns3/hns3_rss.h +++ b/drivers/net/hns3/hns3_rss.h @@ -49,5 +49,4 @@ enum hns3_tuple_field { HNS3_RSS_FIELD_IPV4_SCTP_EN_IP_D, HNS3_RSS_FIELD_IPV4_SCTP_EN_IP_S, - HNS3_RSS_FIELD_IPV4_SCTP_EN_SCTP_VER, /* IPV4 ENABLE FIELD */ @@ -74,5 +73,4 @@ enum hns3_tuple_field { HNS3_RSS_FIELD_IPV6_SCTP_EN_IP_D, HNS3_RSS_FIELD_IPV6_SCTP_EN_IP_S, - HNS3_RSS_FIELD_IPV6_SCTP_EN_SCTP_VER, /* IPV6 ENABLE FIELD */ @@ -96,10 +94,10 @@ enum hns3_tuple_field { #define HNS3_RSS_TUPLE_IPV4_TCP_M GENMASK(3, 0) #define HNS3_RSS_TUPLE_IPV4_UDP_M GENMASK(11, 8) -#define HNS3_RSS_TUPLE_IPV4_SCTP_M GENMASK(20, 16) +#define HNS3_RSS_TUPLE_IPV4_SCTP_M GENMASK(19, 16) #define HNS3_RSS_TUPLE_IPV4_NONF_M GENMASK(25, 24) #define HNS3_RSS_TUPLE_IPV4_FLAG_M GENMASK(27, 26) #define HNS3_RSS_TUPLE_IPV6_TCP_M GENMASK(35, 32) #define HNS3_RSS_TUPLE_IPV6_UDP_M GENMASK(43, 40) -#define HNS3_RSS_TUPLE_IPV6_SCTP_M GENMASK(52, 48) +#define HNS3_RSS_TUPLE_IPV6_SCTP_M GENMASK(51, 48) #define HNS3_RSS_TUPLE_IPV6_NONF_M GENMASK(57, 56) #define HNS3_RSS_TUPLE_IPV6_FLAG_M GENMASK(59, 58) -- 2.46.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-08-23 17:18:10.357716442 +0100 +++ 0011-net-hns3-disable-SCTP-verification-tag-for-RSS-hash-.patch 2024-08-23 17:18:09.624429770 +0100 @@ -1 +1 @@ -From bb1f4717636f5b7d27f4f2fe30469b69d8910bd0 Mon Sep 17 00:00:00 2001 +From 8fb5749bc60ae63b56825ae4ac6358e8c4eb66b8 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit bb1f4717636f5b7d27f4f2fe30469b69d8910bd0 ] + @@ -21,2 +22,0 @@ -Cc: stable@dpdk.org - @@ -30 +30 @@ -index 15feb26043..3eae4caf52 100644 +index b587954508..3fce50519f 100644 @@ -50 +50 @@ -index 9d182a8025..0755760b45 100644 +index 5c0f0b75f0..94c667dad6 100644 @@ -53 +53 @@ -@@ -50,5 +50,4 @@ enum hns3_tuple_field { +@@ -49,5 +49,4 @@ enum hns3_tuple_field { @@ -59 +59 @@ -@@ -75,5 +74,4 @@ enum hns3_tuple_field { +@@ -74,5 +73,4 @@ enum hns3_tuple_field { @@ -65 +65 @@ -@@ -97,10 +95,10 @@ enum hns3_tuple_field { +@@ -96,10 +94,10 @@ enum hns3_tuple_field {