From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1D4E145804 for ; Fri, 23 Aug 2024 18:23:31 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C39474336D; Fri, 23 Aug 2024 18:23:30 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 56338402BE for ; Fri, 23 Aug 2024 18:23:29 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1724430208; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YMEycWAB9/5lWEdFcAhqopiOqSxcEkr7+Y6i/BWHT2k=; b=IMuFX19dNnl29W8bFq4PZmZO/epMiVpkPJo0fMXuOqPNyQ7BqOpDgE+o+R7ibmWN4Y2TQH y+rgJGFjrNwJ318HSjQhMu8XXpnt50fUTukxb5HGSSofwoee3YjVwHsfQaAhkqweeJm30t I7+7XLCEWtqoenX5e1P3k2RUuAmhHCc= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-235-c3oKKYcMPZ6X-s3VAO2qmw-1; Fri, 23 Aug 2024 12:23:27 -0400 X-MC-Unique: c3oKKYcMPZ6X-s3VAO2qmw-1 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id BBD761955D47; Fri, 23 Aug 2024 16:23:26 +0000 (UTC) Received: from rh.redhat.com (unknown [10.39.193.224]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 699651956053; Fri, 23 Aug 2024 16:23:25 +0000 (UTC) From: Kevin Traynor To: Shai Brandes Cc: dpdk stable Subject: patch 'net/ena: fix return value check' has been queued to stable release 21.11.8 Date: Fri, 23 Aug 2024 17:18:58 +0100 Message-ID: <20240823161929.1004778-110-ktraynor@redhat.com> In-Reply-To: <20240823161929.1004778-1-ktraynor@redhat.com> References: <20240823161929.1004778-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.8 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 08/28/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/d8768012e6fb8f6866c298cc2d7a59c3576f129d Thanks. Kevin --- >From d8768012e6fb8f6866c298cc2d7a59c3576f129d Mon Sep 17 00:00:00 2001 From: Shai Brandes Date: Tue, 2 Jul 2024 17:46:23 +0300 Subject: [PATCH] net/ena: fix return value check [ upstream commit 8936b01a512a8e25a7369d282a17b9b09c55728b ] Removed the sign inversion for when checking if ena_com_set_host_attributes returns ENA_COM_UNSUPPORTED. ENA_COM_UNSUPPORTED is defined as -EOPNOTSUPP, so the extra sign inversion is wrong. Fixes: 3adcba9a8987 ("net/ena: update HAL to the newer version") Signed-off-by: Shai Brandes --- drivers/net/ena/ena_ethdev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c index 84c41f1b9d..e810f2673c 100644 --- a/drivers/net/ena/ena_ethdev.c +++ b/drivers/net/ena/ena_ethdev.c @@ -444,5 +444,5 @@ static void ena_config_host_info(struct ena_com_dev *ena_dev) rc = ena_com_set_host_attributes(ena_dev); if (rc) { - if (rc == -ENA_COM_UNSUPPORTED) + if (rc == ENA_COM_UNSUPPORTED) PMD_DRV_LOG(WARNING, "Cannot set host attributes\n"); else @@ -484,5 +484,5 @@ static void ena_config_debug_area(struct ena_adapter *adapter) rc = ena_com_set_host_attributes(&adapter->ena_dev); if (rc) { - if (rc == -ENA_COM_UNSUPPORTED) + if (rc == ENA_COM_UNSUPPORTED) PMD_DRV_LOG(WARNING, "Cannot set host attributes\n"); else -- 2.46.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-08-23 17:18:12.940228884 +0100 +++ 0110-net-ena-fix-return-value-check.patch 2024-08-23 17:18:09.851430563 +0100 @@ -1 +1 @@ -From 8936b01a512a8e25a7369d282a17b9b09c55728b Mon Sep 17 00:00:00 2001 +From d8768012e6fb8f6866c298cc2d7a59c3576f129d Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 8936b01a512a8e25a7369d282a17b9b09c55728b ] + @@ -12 +13,0 @@ -Cc: stable@dpdk.org @@ -20 +21 @@ -index b43b913903..67a1d86f9a 100644 +index 84c41f1b9d..e810f2673c 100644 @@ -23 +24 @@ -@@ -813,5 +813,5 @@ static void ena_config_host_info(struct ena_com_dev *ena_dev) +@@ -444,5 +444,5 @@ static void ena_config_host_info(struct ena_com_dev *ena_dev) @@ -30 +31 @@ -@@ -857,5 +857,5 @@ static void ena_config_debug_area(struct ena_adapter *adapter) +@@ -484,5 +484,5 @@ static void ena_config_debug_area(struct ena_adapter *adapter)