From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 46A0945804 for ; Fri, 23 Aug 2024 18:23:44 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 422684339C; Fri, 23 Aug 2024 18:23:44 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 4EEA34339A for ; Fri, 23 Aug 2024 18:23:43 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1724430222; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kW8nS9UvMWIaiZWXELWej0x2e21EGD9cMhAUyQylxoI=; b=AiHOm89UrJ/SDPrDi1VvWA6QDSn5VT1Pr20793uEyoMR7kjvoTkWSJic4tKZoaxh2UnlZh 4UqstDW7urN9EjK6u9Yi4CPTBtS7vYTW87T0HWL07Bjs7sZ+5se2+FaCOT/lzr+7MKlzY2 mQ75xlU0CnxeOmi/no+g1Fare/AG1RQ= Received: from mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-679-z0SgQzsmMpCJbK1IpaK3KA-1; Fri, 23 Aug 2024 12:23:41 -0400 X-MC-Unique: z0SgQzsmMpCJbK1IpaK3KA-1 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 91FF61955D47; Fri, 23 Aug 2024 16:23:40 +0000 (UTC) Received: from rh.redhat.com (unknown [10.39.193.224]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id DEFEC1956053; Fri, 23 Aug 2024 16:23:38 +0000 (UTC) From: Kevin Traynor To: Gregory Etelson Cc: Dariusz Sosnowski , dpdk stable Subject: patch 'net/mlx5: fix Arm build with GCC 9.1' has been queued to stable release 21.11.8 Date: Fri, 23 Aug 2024 17:19:05 +0100 Message-ID: <20240823161929.1004778-117-ktraynor@redhat.com> In-Reply-To: <20240823161929.1004778-1-ktraynor@redhat.com> References: <20240823161929.1004778-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.8 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 08/28/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/9cc6a96d8a1d75fda4f8b398b18afc1087da5bc2 Thanks. Kevin --- >From 9cc6a96d8a1d75fda4f8b398b18afc1087da5bc2 Mon Sep 17 00:00:00 2001 From: Gregory Etelson Date: Sun, 7 Jul 2024 12:57:23 +0300 Subject: [PATCH] net/mlx5: fix Arm build with GCC 9.1 [ upstream commit 42d6a9084f55281a70bece647803cddbeb8aaec8 ] GCC has introduced a bugfix in 9.1 that changed GCC ABI in ARM setups https://gcc.gnu.org/gcc-9/changes.html ``` On Arm targets (arm*-*-*), a bug in the implementation of the procedure call standard (AAPCS) in the GCC 6, 7 and 8 releases has been fixed a structure containing a bit-field based on a 64-bit integral type and where no other element in a structure required 64-bit alignment could be passed incorrectly to functions. This is an ABI change. If the option -Wpsabi is enabled (on by default) the compiler will emit a diagnostic note for code that might be affected. ``` This fixes the PMD compilation in the INTEGRITY flow item. Fixes: 23b0a8b298b1 ("net/mlx5: fix integrity item validation and translation") Signed-off-by: Gregory Etelson Acked-by: Dariusz Sosnowski --- drivers/net/mlx5/mlx5_flow_dv.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/mlx5/mlx5_flow_dv.c b/drivers/net/mlx5/mlx5_flow_dv.c index ff6713225c..b54b4793cc 100644 --- a/drivers/net/mlx5/mlx5_flow_dv.c +++ b/drivers/net/mlx5/mlx5_flow_dv.c @@ -6585,9 +6585,11 @@ flow_dv_validate_attributes(struct rte_eth_dev *dev, static int -validate_integrity_bits(const struct rte_flow_item_integrity *mask, +validate_integrity_bits(const void *arg, int64_t pattern_flags, uint64_t l3_flags, uint64_t l4_flags, uint64_t ip4_flag, struct rte_flow_error *error) { + const struct rte_flow_item_integrity *mask = arg; + if (mask->l3_ok && !(pattern_flags & l3_flags)) return rte_flow_error_set(error, EINVAL, -- 2.46.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-08-23 17:18:13.229321708 +0100 +++ 0117-net-mlx5-fix-Arm-build-with-GCC-9.1.patch 2024-08-23 17:18:09.873430640 +0100 @@ -1 +1 @@ -From 42d6a9084f55281a70bece647803cddbeb8aaec8 Mon Sep 17 00:00:00 2001 +From 9cc6a96d8a1d75fda4f8b398b18afc1087da5bc2 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 42d6a9084f55281a70bece647803cddbeb8aaec8 ] + @@ -22 +23,0 @@ -Cc: stable@dpdk.org @@ -31 +32 @@ -index 8a0d58cb05..89057edbcf 100644 +index ff6713225c..b54b4793cc 100644 @@ -34 +35 @@ -@@ -7397,9 +7397,11 @@ flow_dv_validate_attributes(struct rte_eth_dev *dev, +@@ -6585,9 +6585,11 @@ flow_dv_validate_attributes(struct rte_eth_dev *dev,