From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BCEA245804 for ; Fri, 23 Aug 2024 18:23:52 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B81814336F; Fri, 23 Aug 2024 18:23:52 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 002AE4336D for ; Fri, 23 Aug 2024 18:23:50 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1724430230; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eA3WQrsb9wfI4gS55ehlNdqdEfOoxzmULYUR2oMDg10=; b=Ce9kmDl91PvKtEfzQcDqR4+mlsdJ3+s1Sz9L9uz4rPze0x4h59HFBeisRM4decyMPjQCLF dXAu3J1CNnRHomRpWdQg46osuxRGyu+BX1cIuJBx6XwJdx6D17rYUgjSJimF0GWWbpzTZD rnt+z23nEEuHxB4G9wSIz8WlObiw++Q= Received: from mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-471-QIKWC_NdOdWdVx_HoHd9Wg-1; Fri, 23 Aug 2024 12:23:47 -0400 X-MC-Unique: QIKWC_NdOdWdVx_HoHd9Wg-1 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 8116F19560B0; Fri, 23 Aug 2024 16:23:46 +0000 (UTC) Received: from rh.redhat.com (unknown [10.39.193.224]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 270511956053; Fri, 23 Aug 2024 16:23:44 +0000 (UTC) From: Kevin Traynor To: Bing Zhao Cc: Viacheslav Ovsiienko , dpdk stable Subject: patch 'net/mlx5: fix uplink port probing in bonding mode' has been queued to stable release 21.11.8 Date: Fri, 23 Aug 2024 17:19:08 +0100 Message-ID: <20240823161929.1004778-120-ktraynor@redhat.com> In-Reply-To: <20240823161929.1004778-1-ktraynor@redhat.com> References: <20240823161929.1004778-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.8 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 08/28/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/427eaf0b16fdc712925c703902bc21de279f9756 Thanks. Kevin --- >From 427eaf0b16fdc712925c703902bc21de279f9756 Mon Sep 17 00:00:00 2001 From: Bing Zhao Date: Wed, 17 Jul 2024 19:35:41 +0300 Subject: [PATCH] net/mlx5: fix uplink port probing in bonding mode [ upstream commit 39d4ec8f36192b9dafbad4994cbe37f7674c7190 ] In the HW-LAG bonding mode, the representor port can be from both slave PFs. When probing a representor (REP), the UPLINK (proxy) port always needs to be probed firstly before any REP port. In the current implementation, when probing a device with the following format: -a 0000:XX:00.0,dv_flow_en=N,representor=pf1vfy Since the REP belongs to the 2nd PF in the bonding, the UPLINK would not be added into the probing ports list. 1. In dv_flow_en=1 mode, the REP itself can be probed. But it didn't obey the rules and the behaviors were inconsistent. a. When probing the REP from 1st PFs, the UPLINK was also probed. b. When detaching the UPLINK, all REPs were detached. 2. In dv_flow_en=2 mode, since some resources can only be allocated / created on the proxy port, the probing would get a failure. By removing the unneeded check of the bonding PF device index, the UPLINK will always try to be probed with any format. Fixes: 2e569a370395 ("net/mlx5: add VF LAG mode bonding device recognition") Signed-off-by: Bing Zhao Acked-by: Viacheslav Ovsiienko --- drivers/net/mlx5/linux/mlx5_os.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/mlx5/linux/mlx5_os.c b/drivers/net/mlx5/linux/mlx5_os.c index 1e1de4b547..841512faa3 100644 --- a/drivers/net/mlx5/linux/mlx5_os.c +++ b/drivers/net/mlx5/linux/mlx5_os.c @@ -2293,6 +2293,5 @@ mlx5_os_pci_probe_pf(struct mlx5_common_device *cdev, list[ns].info.representor = 0; } - if (list[ns].info.port_name == bd) - ns++; + ns++; break; case MLX5_PHYS_PORT_NAME_TYPE_PFHPF: -- 2.46.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-08-23 17:18:13.327859673 +0100 +++ 0120-net-mlx5-fix-uplink-port-probing-in-bonding-mode.patch 2024-08-23 17:18:09.877430654 +0100 @@ -1 +1 @@ -From 39d4ec8f36192b9dafbad4994cbe37f7674c7190 Mon Sep 17 00:00:00 2001 +From 427eaf0b16fdc712925c703902bc21de279f9756 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 39d4ec8f36192b9dafbad4994cbe37f7674c7190 ] + @@ -29 +30,0 @@ -Cc: stable@dpdk.org @@ -38 +39 @@ -index 5e950e9be1..11336c430b 100644 +index 1e1de4b547..841512faa3 100644 @@ -41 +42 @@ -@@ -2474,6 +2474,5 @@ mlx5_os_pci_probe_pf(struct mlx5_common_device *cdev, +@@ -2293,6 +2293,5 @@ mlx5_os_pci_probe_pf(struct mlx5_common_device *cdev,