From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E038E45804 for ; Fri, 23 Aug 2024 18:23:52 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DB7F443392; Fri, 23 Aug 2024 18:23:52 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 3DFA04338B for ; Fri, 23 Aug 2024 18:23:51 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1724430230; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8zo48mz5Vo2PKE1B7azsMquPvfHfYj9i9b4pOxnGCIo=; b=SA0lb7pF3//c2OIVqGUNe9mOJx475MmOLIRaYubrLujYT5PPjxP11B/vxlf5XguWd1BPWs vb12dJG6NX97LD5mN9kGB1PkYap8GktLV5Ay77FE85H6iHMn9IeFfFvBSq+kBoFF26i1Xo Ul456dIKmU9rwnY4Mqag0lJ/8CBgN1A= Received: from mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-68-atduqhHBO6mu9lcY0Kn37g-1; Fri, 23 Aug 2024 12:23:49 -0400 X-MC-Unique: atduqhHBO6mu9lcY0Kn37g-1 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 9CD0319560B0; Fri, 23 Aug 2024 16:23:48 +0000 (UTC) Received: from rh.redhat.com (unknown [10.39.193.224]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 1A05F1956053; Fri, 23 Aug 2024 16:23:46 +0000 (UTC) From: Kevin Traynor To: Bing Zhao Cc: Viacheslav Ovsiienko , dpdk stable Subject: patch 'common/mlx5: remove unneeded field when modify RQ table' has been queued to stable release 21.11.8 Date: Fri, 23 Aug 2024 17:19:09 +0100 Message-ID: <20240823161929.1004778-121-ktraynor@redhat.com> In-Reply-To: <20240823161929.1004778-1-ktraynor@redhat.com> References: <20240823161929.1004778-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.8 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 08/28/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/48208624917631c76dddca76da5c2d35419ea845 Thanks. Kevin --- >From 48208624917631c76dddca76da5c2d35419ea845 Mon Sep 17 00:00:00 2001 From: Bing Zhao Date: Wed, 17 Jul 2024 19:37:19 +0300 Subject: [PATCH] common/mlx5: remove unneeded field when modify RQ table [ upstream commit 463e5abe09362f1d20d0ec99b5969549d51167d6 ] The attribute "rqt_max_size" of the RQT(RQ table) context is only needed by when creating a new one. When modifying an old one, there is no need to set this attribute. The firmware usually ignored this unneeded field. When enabling some extra check, an error will be returned to prevent the code from continuing to run. In the meanwhile, this field will always be set to the maximal one fetched from the capability without any change. Removing the value set and leave it to 0 will help to solve the potential failure. Fixes: e1da60a8a6e9 ("common/mlx5: add DevX command to modify RQT") Signed-off-by: Bing Zhao Acked-by: Viacheslav Ovsiienko --- drivers/common/mlx5/mlx5_devx_cmds.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/common/mlx5/mlx5_devx_cmds.c b/drivers/common/mlx5/mlx5_devx_cmds.c index a9d81b34ce..aa55d577f2 100644 --- a/drivers/common/mlx5/mlx5_devx_cmds.c +++ b/drivers/common/mlx5/mlx5_devx_cmds.c @@ -1626,5 +1626,4 @@ mlx5_devx_cmd_modify_rqt(struct mlx5_devx_obj *rqt, rqt_ctx = MLX5_ADDR_OF(modify_rqt_in, in, rqt_context); MLX5_SET(rqtc, rqt_ctx, list_q_type, rqt_attr->rq_type); - MLX5_SET(rqtc, rqt_ctx, rqt_max_size, rqt_attr->rqt_max_size); MLX5_SET(rqtc, rqt_ctx, rqt_actual_size, rqt_attr->rqt_actual_size); for (i = 0; i < rqt_attr->rqt_actual_size; i++) -- 2.46.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-08-23 17:18:13.354651078 +0100 +++ 0121-common-mlx5-remove-unneeded-field-when-modify-RQ-tab.patch 2024-08-23 17:18:09.878430657 +0100 @@ -1 +1 @@ -From 463e5abe09362f1d20d0ec99b5969549d51167d6 Mon Sep 17 00:00:00 2001 +From 48208624917631c76dddca76da5c2d35419ea845 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 463e5abe09362f1d20d0ec99b5969549d51167d6 ] + @@ -19 +20,0 @@ -Cc: stable@dpdk.org @@ -28 +29 @@ -index 8e12ac50de..9710dcedd3 100644 +index a9d81b34ce..aa55d577f2 100644 @@ -31 +32 @@ -@@ -1915,5 +1915,4 @@ mlx5_devx_cmd_modify_rqt(struct mlx5_devx_obj *rqt, +@@ -1626,5 +1626,4 @@ mlx5_devx_cmd_modify_rqt(struct mlx5_devx_obj *rqt,