From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5772845804 for ; Fri, 23 Aug 2024 18:24:02 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 532F94336F; Fri, 23 Aug 2024 18:24:02 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 41E684336D for ; Fri, 23 Aug 2024 18:24:01 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1724430240; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Zbn92JzF5qzzY0yJ4Z2BExf8DFAW7GwB5h74kdhjdtA=; b=GcYpX0NszI8eA1U79wmzuqEzcXnvHRfxi0THCqqYho7rT0R7KDrFg5svs6Ff1HlpAK5FT3 1igiyPJmH8XFy/QKqn5u8GkxEQ3cjsbiNS4pJpqo+Gh4hfGxu0bgZfwBJMKrC0VHITcNz/ kZHbBvy3x5VwA7qaSkuUqqWNxJavnlA= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-135-73hw3V-KODu1W0a2oLh9AA-1; Fri, 23 Aug 2024 12:23:57 -0400 X-MC-Unique: 73hw3V-KODu1W0a2oLh9AA-1 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 958B21955BF2; Fri, 23 Aug 2024 16:23:56 +0000 (UTC) Received: from rh.redhat.com (unknown [10.39.193.224]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id E0A2D1956053; Fri, 23 Aug 2024 16:23:54 +0000 (UTC) From: Kevin Traynor To: Ferruh Yigit Cc: Raslan Darawsheh , Ali Alnubani , dpdk stable Subject: patch 'app/testpmd: fix build on signed comparison' has been queued to stable release 21.11.8 Date: Fri, 23 Aug 2024 17:19:13 +0100 Message-ID: <20240823161929.1004778-125-ktraynor@redhat.com> In-Reply-To: <20240823161929.1004778-1-ktraynor@redhat.com> References: <20240823161929.1004778-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.8 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 08/28/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/b3996257669c9d0e9e716452e92ada9477e3a56c Thanks. Kevin --- >From b3996257669c9d0e9e716452e92ada9477e3a56c Mon Sep 17 00:00:00 2001 From: Ferruh Yigit Date: Mon, 22 Jul 2024 03:52:29 -0700 Subject: [PATCH] app/testpmd: fix build on signed comparison [ upstream commit 1f47f469aac68bc88be24e530b4267d03537de12 ] Build error: .../app/test-pmd/config.c: In function 'icmp_echo_config_setup': .../app/test-pmd/config.c:5159:30: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare] if ((nb_txq * nb_fwd_ports) < nb_fwd_lcores) ^ All 'nb_txq', 'nb_fwd_ports' & 'nb_fwd_lcores' are unsigned variables, but the warning is related to the integer promotion rules of C: 'nb_txq' -> uint16_t, promoted to 'int' 'nb_fwd_ports' -> uint16_t, promoted to 'int' (nb_txq * nb_fwd_ports) -> result 'int' nb_fwd_lcores -> 'uint32_t' Ends up comparing 'int' vs 'uint32_t'. Fixing by adding the casting back which was initially part of the patch. Fixes: 2bf44dd14fa5 ("app/testpmd: fix lcore ID restriction") Reported-by: Raslan Darawsheh Signed-off-by: Ferruh Yigit Tested-by: Ali Alnubani --- app/test-pmd/config.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index 3afa65036c..e060a1de49 100644 --- a/app/test-pmd/config.c +++ b/app/test-pmd/config.c @@ -3519,5 +3519,5 @@ icmp_echo_config_setup(void) uint16_t sm_id; - if ((nb_txq * nb_fwd_ports) < nb_fwd_lcores) + if ((lcoreid_t)(nb_txq * nb_fwd_ports) < nb_fwd_lcores) cur_fwd_config.nb_fwd_lcores = (lcoreid_t) (nb_txq * nb_fwd_ports); -- 2.46.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-08-23 17:18:13.464627618 +0100 +++ 0125-app-testpmd-fix-build-on-signed-comparison.patch 2024-08-23 17:18:09.890430699 +0100 @@ -1 +1 @@ -From 1f47f469aac68bc88be24e530b4267d03537de12 Mon Sep 17 00:00:00 2001 +From b3996257669c9d0e9e716452e92ada9477e3a56c Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 1f47f469aac68bc88be24e530b4267d03537de12 ] + @@ -24 +25,0 @@ -Cc: stable@dpdk.org @@ -34 +35 @@ -index 66c3a68c1d..6f0beafa27 100644 +index 3afa65036c..e060a1de49 100644 @@ -37 +38 @@ -@@ -5157,5 +5157,5 @@ icmp_echo_config_setup(void) +@@ -3519,5 +3519,5 @@ icmp_echo_config_setup(void)