From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4576045804 for ; Fri, 23 Aug 2024 18:24:14 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3E67943390; Fri, 23 Aug 2024 18:24:14 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 717264336D for ; Fri, 23 Aug 2024 18:24:12 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1724430252; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=c/iLJRsSZZtnFivPCqVrOJ/40be9Li86VIlhMhe0now=; b=EcH4L/HTHT9Ew0CPuNivcrHLcJwGhoAF/teKaAdj4kdRaMVDdEBBKpohkpH8wcD4fuyATq ZhcFmBCbOADifXrsB9JQiADGufPtcBOVDgG2JNBX6IDIRgRlGxaIQQixgbiyghZY2ttUEl L2NyueC1cPdO1YU/il1udZvDeImGZPM= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-687-o8K9uiibNQWRhEz2aaCEqA-1; Fri, 23 Aug 2024 12:24:10 -0400 X-MC-Unique: o8K9uiibNQWRhEz2aaCEqA-1 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id D785C1956064; Fri, 23 Aug 2024 16:24:09 +0000 (UTC) Received: from rh.redhat.com (unknown [10.39.193.224]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 39B1919560A3; Fri, 23 Aug 2024 16:24:07 +0000 (UTC) From: Kevin Traynor To: Mingjin Ye Cc: Anatoly Burakov , dpdk stable Subject: patch 'bus/vdev: fix device reinitialization' has been queued to stable release 21.11.8 Date: Fri, 23 Aug 2024 17:19:19 +0100 Message-ID: <20240823161929.1004778-131-ktraynor@redhat.com> In-Reply-To: <20240823161929.1004778-1-ktraynor@redhat.com> References: <20240823161929.1004778-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.8 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 08/28/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/a12d1910bc56029b39db32f42ecfcd7b2ab739dc Thanks. Kevin --- >From a12d1910bc56029b39db32f42ecfcd7b2ab739dc Mon Sep 17 00:00:00 2001 From: Mingjin Ye Date: Tue, 16 Jul 2024 09:53:28 +0000 Subject: [PATCH] bus/vdev: fix device reinitialization [ upstream commit 1bd1ab6fd010837773473d821f9284369b37264c ] In secondary processes, insert_vdev() may be called multiple times on the same device due to multi-process hot-plugging of the vdev bus and EAL parameters to add the same vdev. In this case, when rte_devargs_insert() is called, the devargs->name reference will be invalidated because rte_devargs_insert() destroys the just-allocated devargs and replaces the pointer from the devargs list. As a result, the reference to devargs->name stored in dev->device.name will be invalid. This patch fixes the issue by setting the device name after calling rte_devargs_insert(). Fixes: cdb068f031c6 ("bus/vdev: scan by multi-process channel") Signed-off-by: Mingjin Ye Reviewed-by: Anatoly Burakov --- drivers/bus/vdev/vdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/bus/vdev/vdev.c b/drivers/bus/vdev/vdev.c index 272ea704e5..c040a6d09e 100644 --- a/drivers/bus/vdev/vdev.c +++ b/drivers/bus/vdev/vdev.c @@ -290,5 +290,4 @@ insert_vdev(const char *name, const char *args, dev->device.bus = &rte_vdev_bus; dev->device.numa_node = SOCKET_ID_ANY; - dev->device.name = devargs->name; if (find_vdev(name)) { @@ -305,4 +304,5 @@ insert_vdev(const char *name, const char *args, rte_devargs_insert(&devargs); dev->device.devargs = devargs; + dev->device.name = devargs->name; TAILQ_INSERT_TAIL(&vdev_device_list, dev, next); -- 2.46.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-08-23 17:18:13.618398777 +0100 +++ 0131-bus-vdev-fix-device-reinitialization.patch 2024-08-23 17:18:09.893430710 +0100 @@ -1 +1 @@ -From 1bd1ab6fd010837773473d821f9284369b37264c Mon Sep 17 00:00:00 2001 +From a12d1910bc56029b39db32f42ecfcd7b2ab739dc Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 1bd1ab6fd010837773473d821f9284369b37264c ] + @@ -20 +21,0 @@ -Cc: stable@dpdk.org @@ -29 +30 @@ -index 38d05a9fe9..ec7abe7cda 100644 +index 272ea704e5..c040a6d09e 100644 @@ -32 +33 @@ -@@ -289,5 +289,4 @@ insert_vdev(const char *name, const char *args, +@@ -290,5 +290,4 @@ insert_vdev(const char *name, const char *args, @@ -38 +39 @@ -@@ -304,4 +303,5 @@ insert_vdev(const char *name, const char *args, +@@ -305,4 +304,5 @@ insert_vdev(const char *name, const char *args,