From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B50D645804 for ; Fri, 23 Aug 2024 18:20:29 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B09CE4337C; Fri, 23 Aug 2024 18:20:29 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id C8BD54336D for ; Fri, 23 Aug 2024 18:20:27 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1724430027; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=iAwxFhlQy6BnPZwYpgzkeAWBMs7XshKuY8ogsmu6ZDc=; b=dc/TvzC0YXLeiqB4Ntq+y/XpDv87A2YVsxGaMeVDKs+3+zgXvphzMVZiaZrFcWsEygsUcK psNEgasrdaoCdNDXuRVwxYjVqLc0JToCDOOvpqCuRFwCqhMrN+y6tFikvxxMhmjM1jsPxN MRr16hw48Y3EumKhp32btcoaY3V9BKA= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-374-OCPxyNp8OTKRQxkeRcXiSQ-1; Fri, 23 Aug 2024 12:20:24 -0400 X-MC-Unique: OCPxyNp8OTKRQxkeRcXiSQ-1 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 1C86119560AB; Fri, 23 Aug 2024 16:20:23 +0000 (UTC) Received: from rh.redhat.com (unknown [10.39.193.224]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id A8CDD1956053; Fri, 23 Aug 2024 16:20:21 +0000 (UTC) From: Kevin Traynor To: Venkat Kumar Ande Cc: Selwin Sebastian , dpdk stable Subject: patch 'net/axgbe: disable interrupts during device removal' has been queued to stable release 21.11.8 Date: Fri, 23 Aug 2024 17:17:29 +0100 Message-ID: <20240823161929.1004778-21-ktraynor@redhat.com> In-Reply-To: <20240823161929.1004778-1-ktraynor@redhat.com> References: <20240823161929.1004778-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.8 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 08/28/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/a14247758ae4d076545ec3006060d274f26d3c6a Thanks. Kevin --- >From a14247758ae4d076545ec3006060d274f26d3c6a Mon Sep 17 00:00:00 2001 From: Venkat Kumar Ande Date: Tue, 4 Jun 2024 17:41:37 +0530 Subject: [PATCH] net/axgbe: disable interrupts during device removal [ upstream commit 7b7288b08760204139085174ba00a2863dfdbbec ] Hardware interrupts are enabled during the init, however, they are not disabled during close. Disable all hardware interrupts during close operation to avoid any issues. Fixes: 9e890103267e ("net/axgbe: add Rx/Tx setup") Signed-off-by: Venkat Kumar Ande Acked-by: Selwin Sebastian --- drivers/net/axgbe/axgbe_ethdev.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/net/axgbe/axgbe_ethdev.c b/drivers/net/axgbe/axgbe_ethdev.c index a7812f03c1..4dd634414c 100644 --- a/drivers/net/axgbe/axgbe_ethdev.c +++ b/drivers/net/axgbe/axgbe_ethdev.c @@ -2333,4 +2333,5 @@ axgbe_dev_close(struct rte_eth_dev *eth_dev) { struct rte_pci_device *pci_dev; + struct axgbe_port *pdata; PMD_INIT_FUNC_TRACE(); @@ -2339,4 +2340,5 @@ axgbe_dev_close(struct rte_eth_dev *eth_dev) return 0; + pdata = eth_dev->data->dev_private; pci_dev = RTE_DEV_TO_PCI(eth_dev->device); axgbe_dev_clear_queues(eth_dev); @@ -2348,4 +2350,7 @@ axgbe_dev_close(struct rte_eth_dev *eth_dev) (void *)eth_dev); + /* Disable all interrupts in the hardware */ + XP_IOWRITE(pdata, XP_INT_EN, 0x0); + return 0; } -- 2.46.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-08-23 17:18:10.625874394 +0100 +++ 0021-net-axgbe-disable-interrupts-during-device-removal.patch 2024-08-23 17:18:09.641429829 +0100 @@ -1 +1 @@ -From 7b7288b08760204139085174ba00a2863dfdbbec Mon Sep 17 00:00:00 2001 +From a14247758ae4d076545ec3006060d274f26d3c6a Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 7b7288b08760204139085174ba00a2863dfdbbec ] + @@ -13 +14,0 @@ -Cc: stable@dpdk.org @@ -22 +23 @@ -index dd681f15a0..e5d8f7db02 100644 +index a7812f03c1..4dd634414c 100644 @@ -25 +26 @@ -@@ -2412,4 +2412,5 @@ axgbe_dev_close(struct rte_eth_dev *eth_dev) +@@ -2333,4 +2333,5 @@ axgbe_dev_close(struct rte_eth_dev *eth_dev) @@ -31 +32 @@ -@@ -2418,4 +2419,5 @@ axgbe_dev_close(struct rte_eth_dev *eth_dev) +@@ -2339,4 +2340,5 @@ axgbe_dev_close(struct rte_eth_dev *eth_dev) @@ -37 +38 @@ -@@ -2427,4 +2429,7 @@ axgbe_dev_close(struct rte_eth_dev *eth_dev) +@@ -2348,4 +2350,7 @@ axgbe_dev_close(struct rte_eth_dev *eth_dev)