From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D5E9A45804 for ; Fri, 23 Aug 2024 18:20:44 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D03DD4337B; Fri, 23 Aug 2024 18:20:44 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 05FAA4336F for ; Fri, 23 Aug 2024 18:20:42 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1724430042; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wZ8EUMpVMn4yB2+BWg505i3abmEkuMxvoM+UvIYdKhk=; b=NJ167FkopLuBKF9lWcu6UUw0pxmTEvgknAvZEM6QPIE8tQ8+bcRq1v7JaLGBbyxEMLH9nR fySBnli9Lg4Tg1qoXF6D+ktVWkU4DYy3DWOe/essWZ6CgvxXRQWP7ADJgewVP+NCIoO20w kBdI3Vin0glOAsrs+I9OSjW8qsWnGqs= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-111-_pJK8jPQNs61oizgeZV9uQ-1; Fri, 23 Aug 2024 12:20:41 -0400 X-MC-Unique: _pJK8jPQNs61oizgeZV9uQ-1 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 995B41955F65; Fri, 23 Aug 2024 16:20:40 +0000 (UTC) Received: from rh.redhat.com (unknown [10.39.193.224]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 95BC51955F54; Fri, 23 Aug 2024 16:20:38 +0000 (UTC) From: Kevin Traynor To: David Marchand Cc: Ferruh Yigit , Ali Alnubani , dpdk stable Subject: patch 'app/testpmd: fix outer IP checksum offload' has been queued to stable release 21.11.8 Date: Fri, 23 Aug 2024 17:17:37 +0100 Message-ID: <20240823161929.1004778-29-ktraynor@redhat.com> In-Reply-To: <20240823161929.1004778-1-ktraynor@redhat.com> References: <20240823161929.1004778-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.8 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 08/28/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/ce87e585c5c8da834f48cf3bca758b29b0f1a1b1 Thanks. Kevin --- >From ce87e585c5c8da834f48cf3bca758b29b0f1a1b1 Mon Sep 17 00:00:00 2001 From: David Marchand Date: Thu, 18 Apr 2024 10:20:17 +0200 Subject: [PATCH] app/testpmd: fix outer IP checksum offload [ upstream commit b9d859d8a671ec4516face2eba24434b955a9ac1 ] Resetting the outer IP checksum to 0 is not something mandated by the mbuf API and is done by rte_eth_tx_prepare(), or per driver if needed. Fixes: 4fb7e803eb1a ("ethdev: add Tx preparation") Signed-off-by: David Marchand Acked-by: Ferruh Yigit Tested-by: Ali Alnubani --- app/test-pmd/csumonly.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/app/test-pmd/csumonly.c b/app/test-pmd/csumonly.c index 5e494c4129..b314b15e0c 100644 --- a/app/test-pmd/csumonly.c +++ b/app/test-pmd/csumonly.c @@ -563,13 +563,15 @@ process_outer_cksums(void *outer_l3_hdr, struct testpmd_offload_info *info, if (info->outer_ethertype == _htons(RTE_ETHER_TYPE_IPV4)) { - ipv4_hdr->hdr_checksum = 0; ol_flags |= RTE_MBUF_F_TX_OUTER_IPV4; - if (tx_offloads & RTE_ETH_TX_OFFLOAD_OUTER_IPV4_CKSUM) + if (tx_offloads & RTE_ETH_TX_OFFLOAD_OUTER_IPV4_CKSUM) { ol_flags |= RTE_MBUF_F_TX_OUTER_IP_CKSUM; - else + } else { + ipv4_hdr->hdr_checksum = 0; ipv4_hdr->hdr_checksum = rte_ipv4_cksum(ipv4_hdr); - } else + } + } else { ol_flags |= RTE_MBUF_F_TX_OUTER_IPV6; + } if (info->outer_l4_proto != IPPROTO_UDP) -- 2.46.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-08-23 17:18:10.836070522 +0100 +++ 0029-app-testpmd-fix-outer-IP-checksum-offload.patch 2024-08-23 17:18:09.649429857 +0100 @@ -1 +1 @@ -From b9d859d8a671ec4516face2eba24434b955a9ac1 Mon Sep 17 00:00:00 2001 +From ce87e585c5c8da834f48cf3bca758b29b0f1a1b1 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit b9d859d8a671ec4516face2eba24434b955a9ac1 ] + @@ -10 +11,0 @@ -Cc: stable@dpdk.org @@ -20 +21 @@ -index 6711dda42e..f5125c2788 100644 +index 5e494c4129..b314b15e0c 100644 @@ -23 +24 @@ -@@ -584,13 +584,15 @@ process_outer_cksums(void *outer_l3_hdr, struct testpmd_offload_info *info, +@@ -563,13 +563,15 @@ process_outer_cksums(void *outer_l3_hdr, struct testpmd_offload_info *info,