From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4D2E145804 for ; Fri, 23 Aug 2024 18:21:02 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 48AED402BE; Fri, 23 Aug 2024 18:21:02 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id E06C740295 for ; Fri, 23 Aug 2024 18:21:00 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1724430060; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ER0oCSWs6S1FlwH2Iid7Qbq3QQeWx3XyfLE8z6hBpYo=; b=dm8hRK8ihEwv181hUbcDOPae5HS5RHRelL7UIsjos8gH40BwJdhRMHDy3Er42pGlbrk5IF Fy93ari7OY/V/2HvWhZEEYXwHp35b07cGDxSppn5Ev/xzuuvBFmEQ8C4RjdxHjSenhkjsT mmXvh3aArwD2+8FzKs2fMqNhz26ZL+8= Received: from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-34-A6Q3jPENOjqv0MDLRyOXUg-1; Fri, 23 Aug 2024 12:20:57 -0400 X-MC-Unique: A6Q3jPENOjqv0MDLRyOXUg-1 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 5927E1955D4C; Fri, 23 Aug 2024 16:20:56 +0000 (UTC) Received: from rh.redhat.com (unknown [10.39.193.224]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id DBACE1956053; Fri, 23 Aug 2024 16:20:54 +0000 (UTC) From: Kevin Traynor To: Satha Rao Cc: Maxime Coquelin , dpdk stable Subject: patch 'net/virtio: fix MAC table update' has been queued to stable release 21.11.8 Date: Fri, 23 Aug 2024 17:17:44 +0100 Message-ID: <20240823161929.1004778-36-ktraynor@redhat.com> In-Reply-To: <20240823161929.1004778-1-ktraynor@redhat.com> References: <20240823161929.1004778-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.8 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 08/28/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/8863a119d089aabf270fe1953edff174b6e7f8fa Thanks. Kevin --- >From 8863a119d089aabf270fe1953edff174b6e7f8fa Mon Sep 17 00:00:00 2001 From: Satha Rao Date: Thu, 30 May 2024 13:40:39 -0400 Subject: [PATCH] net/virtio: fix MAC table update [ upstream commit 7698e655516c54558a43b8aaed1bff69928d96fb ] Don't send NULL MAC addresses in MAC table update. Fixes: 1b306359e58c ("virtio: suport multiple MAC addresses") Signed-off-by: Satha Rao Reviewed-by: Maxime Coquelin --- drivers/net/virtio/virtio_ethdev.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c index c6155e9ae5..ea7e712590 100644 --- a/drivers/net/virtio/virtio_ethdev.c +++ b/drivers/net/virtio/virtio_ethdev.c @@ -1323,4 +1323,6 @@ virtio_mac_addr_add(struct rte_eth_dev *dev, struct rte_ether_addr *mac_addr, = rte_is_multicast_ether_addr(addr) ? mc : uc; + if (rte_is_zero_ether_addr(addr)) + break; memcpy(&tbl->macs[tbl->entries++], addr, RTE_ETHER_ADDR_LEN); } -- 2.46.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-08-23 17:18:11.025710555 +0100 +++ 0036-net-virtio-fix-MAC-table-update.patch 2024-08-23 17:18:09.676429952 +0100 @@ -1 +1 @@ -From 7698e655516c54558a43b8aaed1bff69928d96fb Mon Sep 17 00:00:00 2001 +From 8863a119d089aabf270fe1953edff174b6e7f8fa Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 7698e655516c54558a43b8aaed1bff69928d96fb ] + @@ -9 +10,0 @@ -Cc: stable@dpdk.org @@ -18 +19 @@ -index 517585740e..70d4839def 100644 +index c6155e9ae5..ea7e712590 100644 @@ -21 +22 @@ -@@ -914,4 +914,6 @@ virtio_mac_addr_add(struct rte_eth_dev *dev, struct rte_ether_addr *mac_addr, +@@ -1323,4 +1323,6 @@ virtio_mac_addr_add(struct rte_eth_dev *dev, struct rte_ether_addr *mac_addr,