From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E872945804 for ; Fri, 23 Aug 2024 18:21:08 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E34D343382; Fri, 23 Aug 2024 18:21:08 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id E1386402BE for ; Fri, 23 Aug 2024 18:21:07 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1724430067; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=X0p+3Fb9oqzPtugi5xEEBfyav2xIP+fKh4ZgeIgqRJw=; b=PqkkAGPpGMrgKUtyuVrYxDaI8Mi8Yc8wprAr5pGmuN9s6z48lmmkom5XldJ4q73w4XQGt5 DctJMLL55hv/E/ts5LyDvl4Fe85bF3T/oFAQJ31tP6zsgerMrW8IYo/NhTuEChL8U5ojc6 G3I1jjYXoVTpPd0ctsD+OZlu5r7JWps= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-643-IDfscYbDMt26AOXr2UHGbQ-1; Fri, 23 Aug 2024 12:21:06 -0400 X-MC-Unique: IDfscYbDMt26AOXr2UHGbQ-1 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 285251956048; Fri, 23 Aug 2024 16:21:05 +0000 (UTC) Received: from rh.redhat.com (unknown [10.39.193.224]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 1004B1955F45; Fri, 23 Aug 2024 16:21:02 +0000 (UTC) From: Kevin Traynor To: Stephen Hemminger Cc: Jun Wang , Bruce Richardson , dpdk stable Subject: patch 'net/ixgbe: do not update link status in secondary process' has been queued to stable release 21.11.8 Date: Fri, 23 Aug 2024 17:17:48 +0100 Message-ID: <20240823161929.1004778-40-ktraynor@redhat.com> In-Reply-To: <20240823161929.1004778-1-ktraynor@redhat.com> References: <20240823161929.1004778-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.8 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 08/28/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/1d72c067059e2731649c2458a5820d2093328a7b Thanks. Kevin --- >From 1d72c067059e2731649c2458a5820d2093328a7b Mon Sep 17 00:00:00 2001 From: Stephen Hemminger Date: Wed, 20 Mar 2024 10:33:04 -0700 Subject: [PATCH] net/ixgbe: do not update link status in secondary process [ upstream commit 5ffd40b85febd2a80b88b4cfbf4e1dd7e5f059c5 ] The code to update link status is not safe in secondary process. If called from secondary it will crash, example from dumpcap: ixgbe_dev_link_update_share() ixgbe_dev_link_update() rte_eth_link_get() Fixes: af75078fece3 ("first public release") Reported-by: Jun Wang Signed-off-by: Stephen Hemminger Acked-by: Bruce Richardson --- drivers/net/ixgbe/ixgbe_ethdev.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c index 96dc34eb83..1c65cf77f5 100644 --- a/drivers/net/ixgbe/ixgbe_ethdev.c +++ b/drivers/net/ixgbe/ixgbe_ethdev.c @@ -4286,4 +4286,7 @@ ixgbe_dev_link_update_share(struct rte_eth_dev *dev, u32 esdp_reg; + if (rte_eal_process_type() != RTE_PROC_PRIMARY) + return -1; + memset(&link, 0, sizeof(link)); link.link_status = RTE_ETH_LINK_DOWN; -- 2.46.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-08-23 17:18:11.131644456 +0100 +++ 0040-net-ixgbe-do-not-update-link-status-in-secondary-pro.patch 2024-08-23 17:18:09.685429983 +0100 @@ -1 +1 @@ -From 5ffd40b85febd2a80b88b4cfbf4e1dd7e5f059c5 Mon Sep 17 00:00:00 2001 +From 1d72c067059e2731649c2458a5820d2093328a7b Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 5ffd40b85febd2a80b88b4cfbf4e1dd7e5f059c5 ] + @@ -13 +14,0 @@ -Cc: stable@dpdk.org @@ -23 +24 @@ -index bbdc996f31..a6916da0c5 100644 +index 96dc34eb83..1c65cf77f5 100644 @@ -26 +27 @@ -@@ -4294,4 +4294,7 @@ ixgbe_dev_link_update_share(struct rte_eth_dev *dev, +@@ -4286,4 +4286,7 @@ ixgbe_dev_link_update_share(struct rte_eth_dev *dev,