From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 374D545804 for ; Fri, 23 Aug 2024 18:21:13 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 320F743380; Fri, 23 Aug 2024 18:21:13 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 24EDF40295 for ; Fri, 23 Aug 2024 18:21:12 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1724430071; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5guFVIipfzZEJOXpkK47bnJDrUsozUDPRujdCW3o27A=; b=R4NAjtVIM7eVyKXVKKoUIkimjgNX7EhyWzdreqeLnFHHHA8R/M4M4sUubYWL326t4j8ryz N4+K6cXCjUA5pxOOGtWBcCvnFIl82/WonyUUtD6Fy9+II2vBmKI4IX1esuhDXcxcNMJ0ZC EUGMejs640O7COZHZLw0l0kSoUUyk8E= Received: from mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-252-BoWtpXjYOz2wQRmbJ3GhYw-1; Fri, 23 Aug 2024 12:21:10 -0400 X-MC-Unique: BoWtpXjYOz2wQRmbJ3GhYw-1 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 06E0E1955D4D; Fri, 23 Aug 2024 16:21:09 +0000 (UTC) Received: from rh.redhat.com (unknown [10.39.193.224]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 8A9291956053; Fri, 23 Aug 2024 16:21:07 +0000 (UTC) From: Kevin Traynor To: Anatoly Burakov Cc: Bruce Richardson , dpdk stable Subject: patch 'net/e1000/base: fix link power down' has been queued to stable release 21.11.8 Date: Fri, 23 Aug 2024 17:17:50 +0100 Message-ID: <20240823161929.1004778-42-ktraynor@redhat.com> In-Reply-To: <20240823161929.1004778-1-ktraynor@redhat.com> References: <20240823161929.1004778-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.8 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 08/28/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/f7f0ac1a361cdd631aabfc999e5aa6fe5329f017 Thanks. Kevin --- >From f7f0ac1a361cdd631aabfc999e5aa6fe5329f017 Mon Sep 17 00:00:00 2001 From: Anatoly Burakov Date: Tue, 14 May 2024 16:17:16 +0100 Subject: [PATCH] net/e1000/base: fix link power down [ upstream commit a8218d09e3aaae5307325ff4b2f92ed4a3c37a8c ] Current code is a result of work to reduce duplication between various device models. However, the logic that was replaced did not exactly match the new logic, and as a result the link power down was not working correctly for some NICs, and the link remained up even when the interface is down. Fix it to correctly power down the link under all circumstances that were supported by old logic. Fixes: 44dddd14059f ("net/e1000/base: remove duplicated codes") Signed-off-by: Anatoly Burakov Acked-by: Bruce Richardson --- drivers/net/e1000/base/e1000_base.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/e1000/base/e1000_base.c b/drivers/net/e1000/base/e1000_base.c index ab73e1e59e..3ec32e7240 100644 --- a/drivers/net/e1000/base/e1000_base.c +++ b/drivers/net/e1000/base/e1000_base.c @@ -108,5 +108,5 @@ void e1000_power_down_phy_copper_base(struct e1000_hw *hw) /* If the management interface is not enabled, then power down */ - if (phy->ops.check_reset_block(hw)) + if (!(e1000_enable_mng_pass_thru(hw) || phy->ops.check_reset_block(hw))) e1000_power_down_phy_copper(hw); } -- 2.46.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-08-23 17:18:11.190839759 +0100 +++ 0042-net-e1000-base-fix-link-power-down.patch 2024-08-23 17:18:09.689429997 +0100 @@ -1 +1 @@ -From a8218d09e3aaae5307325ff4b2f92ed4a3c37a8c Mon Sep 17 00:00:00 2001 +From f7f0ac1a361cdd631aabfc999e5aa6fe5329f017 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit a8218d09e3aaae5307325ff4b2f92ed4a3c37a8c ] + @@ -16 +17,0 @@ -Cc: stable@dpdk.org