From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F047545804 for ; Fri, 23 Aug 2024 18:21:26 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EAC83402BE; Fri, 23 Aug 2024 18:21:26 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 8EAF740295 for ; Fri, 23 Aug 2024 18:21:24 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1724430084; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qc0WytHFpix1hgDIiGbHBSo5K6pDd4vP40JPd/lQMR8=; b=fzvhoLFp1aRGdbM6UrGSQUDduXRDU6OGdd624AbpA90ASmHhxgyWtvxvuoQCRUAtKS0HpF Li0mwwLQlOI1ew3b5ejjOA6mGEH/ZM5oy+jtk9N8nnWnzKVfLit7/TTrXvovRwjQrBYEs4 OBZvcR7VvmQHlOvbormbe0kgKqfUwEg= Received: from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-608-stahZ9MuMw2CWrV-fBIQxA-1; Fri, 23 Aug 2024 12:21:22 -0400 X-MC-Unique: stahZ9MuMw2CWrV-fBIQxA-1 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 9A6CF1955D55; Fri, 23 Aug 2024 16:21:21 +0000 (UTC) Received: from rh.redhat.com (unknown [10.39.193.224]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 728C81956053; Fri, 23 Aug 2024 16:21:20 +0000 (UTC) From: Kevin Traynor To: Rahul Bhansali Cc: dpdk stable Subject: patch 'net/cnxk: fix promiscuous state after MAC change' has been queued to stable release 21.11.8 Date: Fri, 23 Aug 2024 17:17:56 +0100 Message-ID: <20240823161929.1004778-48-ktraynor@redhat.com> In-Reply-To: <20240823161929.1004778-1-ktraynor@redhat.com> References: <20240823161929.1004778-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.8 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 08/28/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/6fa9a2e32d563133cdc17e957dc4916ddaf7b032 Thanks. Kevin --- >From 6fa9a2e32d563133cdc17e957dc4916ddaf7b032 Mon Sep 17 00:00:00 2001 From: Rahul Bhansali Date: Tue, 28 May 2024 14:02:46 +0530 Subject: [PATCH] net/cnxk: fix promiscuous state after MAC change [ upstream commit 5f1bce00fddffc63e5634891df2b02859c010944 ] If promiscuous mode is enabled and default MAC address is set again then promiscuous mode gets disabled in hardware. This change will restore promiscuous behavior after configuring default MAC address. Fixes: 5fe86db2a0dd ("net/cnxk: support MAC address set") Signed-off-by: Rahul Bhansali --- drivers/net/cnxk/cnxk_ethdev_ops.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/net/cnxk/cnxk_ethdev_ops.c b/drivers/net/cnxk/cnxk_ethdev_ops.c index 67c0dd8865..84124c84a6 100644 --- a/drivers/net/cnxk/cnxk_ethdev_ops.c +++ b/drivers/net/cnxk/cnxk_ethdev_ops.c @@ -341,4 +341,11 @@ cnxk_nix_mac_addr_set(struct rte_eth_dev *eth_dev, struct rte_ether_addr *addr) goto exit; } + + if (eth_dev->data->promiscuous) { + rc = roc_nix_mac_promisc_mode_enable(nix, true); + if (rc) + plt_err("Failed to setup promisc mode in mac, rc=%d(%s)", rc, + roc_error_msg_get(rc)); + } } -- 2.46.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-08-23 17:18:11.351443060 +0100 +++ 0048-net-cnxk-fix-promiscuous-state-after-MAC-change.patch 2024-08-23 17:18:09.701430039 +0100 @@ -1 +1 @@ -From 5f1bce00fddffc63e5634891df2b02859c010944 Mon Sep 17 00:00:00 2001 +From 6fa9a2e32d563133cdc17e957dc4916ddaf7b032 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 5f1bce00fddffc63e5634891df2b02859c010944 ] + @@ -13 +14,0 @@ -Cc: stable@dpdk.org @@ -21 +22 @@ -index c8260fcb9c..b1093dd584 100644 +index 67c0dd8865..84124c84a6 100644 @@ -24 +25 @@ -@@ -452,4 +452,11 @@ cnxk_nix_mac_addr_set(struct rte_eth_dev *eth_dev, struct rte_ether_addr *addr) +@@ -341,4 +341,11 @@ cnxk_nix_mac_addr_set(struct rte_eth_dev *eth_dev, struct rte_ether_addr *addr)