From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D0A3F45804 for ; Fri, 23 Aug 2024 18:21:38 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CB14E402BE; Fri, 23 Aug 2024 18:21:38 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 31BDE40295 for ; Fri, 23 Aug 2024 18:21:37 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1724430096; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=E6HztbbKk8zIlbvGeoRXRiqmvqivFSSyJBkvvqT7FrM=; b=g6kRZ6FiWfTGu8ypkJwct6pk+w+3jTvNXmBexCXdJbV4hXFSLBG2uQoYR3jX1O2ifdgrZ4 A4DzylNLIjBtgEAdwCmgXT/gCqCbOdRITB9rT38b/bJm/cs6SKSkte6nUvy64uKqbMj++9 u1+JiSKd3G9AUvXcdVP7MzdTsispBTY= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-544-ljU4C_xgN52tVtnL7LOOSA-1; Fri, 23 Aug 2024 12:21:33 -0400 X-MC-Unique: ljU4C_xgN52tVtnL7LOOSA-1 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id BFB871955BED; Fri, 23 Aug 2024 16:21:32 +0000 (UTC) Received: from rh.redhat.com (unknown [10.39.193.224]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id E5B521956053; Fri, 23 Aug 2024 16:21:30 +0000 (UTC) From: Kevin Traynor To: David Marchand Cc: Christian Ehrhardt , Bruce Richardson , dpdk stable Subject: patch 'telemetry: lower log level on socket error' has been queued to stable release 21.11.8 Date: Fri, 23 Aug 2024 17:18:01 +0100 Message-ID: <20240823161929.1004778-53-ktraynor@redhat.com> In-Reply-To: <20240823161929.1004778-1-ktraynor@redhat.com> References: <20240823161929.1004778-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.8 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 08/28/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/90859e988cf31f52ae430750f633014c9d8bcc8c Thanks. Kevin --- >From 90859e988cf31f52ae430750f633014c9d8bcc8c Mon Sep 17 00:00:00 2001 From: David Marchand Date: Thu, 6 Jun 2024 14:26:54 +0200 Subject: [PATCH] telemetry: lower log level on socket error [ upstream commit 80b7993ba1b45d8aad7c294a7aaf66f4cdf860a5 ] When starting two DPDK programs using the same DPDK prefix (like for example OVS and testpmd, both running as primary processes in --in-memory mode), the first DPDK process of the two spews some error log when the second starts: TELEMETRY: Socket write base info to client failed This is because telemetry init involves trying to connect on existing sockets to check if it can take over an existing socket file. On the other hand, this error log provides no helpful information. Lower this log to debug level. Fixes: e14bb5f10509 ("telemetry: fix connected clients count") Reported-by: Christian Ehrhardt Signed-off-by: David Marchand Acked-by: Bruce Richardson --- lib/telemetry/telemetry.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/telemetry/telemetry.c b/lib/telemetry/telemetry.c index 36cdec26ef..74315714ea 100644 --- a/lib/telemetry/telemetry.c +++ b/lib/telemetry/telemetry.c @@ -379,5 +379,5 @@ client_handler(void *sock_id) telemetry_version, getpid(), MAX_OUTPUT_LEN); if (write(s, info_str, strlen(info_str)) < 0) { - TMTY_LOG(ERR, "Socket write base info to client failed\n"); + TMTY_LOG(DEBUG, "Socket write base info to client failed\n"); goto exit; } -- 2.46.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-08-23 17:18:11.483095893 +0100 +++ 0053-telemetry-lower-log-level-on-socket-error.patch 2024-08-23 17:18:09.715430088 +0100 @@ -1 +1 @@ -From 80b7993ba1b45d8aad7c294a7aaf66f4cdf860a5 Mon Sep 17 00:00:00 2001 +From 90859e988cf31f52ae430750f633014c9d8bcc8c Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 80b7993ba1b45d8aad7c294a7aaf66f4cdf860a5 ] + @@ -20 +21,0 @@ -Cc: stable@dpdk.org @@ -30 +31 @@ -index 1663bd8c68..509fae76ec 100644 +index 36cdec26ef..74315714ea 100644 @@ -33 +34 @@ -@@ -383,5 +383,5 @@ client_handler(void *sock_id) +@@ -379,5 +379,5 @@ client_handler(void *sock_id) @@ -36,2 +37,2 @@ -- TMTY_LOG_LINE(ERR, "Socket write base info to client failed"); -+ TMTY_LOG_LINE(DEBUG, "Socket write base info to client failed"); +- TMTY_LOG(ERR, "Socket write base info to client failed\n"); ++ TMTY_LOG(DEBUG, "Socket write base info to client failed\n");