From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 01F3E45807 for ; Fri, 23 Aug 2024 18:21:39 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F17F643384; Fri, 23 Aug 2024 18:21:38 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 47983402BE for ; Fri, 23 Aug 2024 18:21:37 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1724430096; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nx8iiVt6RSzAWSfoKZLPbEOTtLRG+vA/1i5iNCblTEc=; b=KzPU6OCCIUwxMraol9jaBJ5OZ8x6qZewT7zfOOMyzp/IsI/bmV6JmxNwwiJ49XTMJ/oRFF u38pyJwf6sDAYoJ5+l/vaX7ebod8aBjBSp0OiRk42xYXoKen6A5ftdKW21ufxnvm0kGleB C+zqdYw0sz0ZWa0WPPMGL544frgngu0= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-624-Tb3K-66lPfGkbcdwo-Uung-1; Fri, 23 Aug 2024 12:21:35 -0400 X-MC-Unique: Tb3K-66lPfGkbcdwo-Uung-1 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id C39C11956080; Fri, 23 Aug 2024 16:21:34 +0000 (UTC) Received: from rh.redhat.com (unknown [10.39.193.224]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 41DD11956053; Fri, 23 Aug 2024 16:21:33 +0000 (UTC) From: Kevin Traynor To: Hernan Vargas Cc: Maxime Coquelin , dpdk stable Subject: patch 'app/bbdev: fix interrupt tests' has been queued to stable release 21.11.8 Date: Fri, 23 Aug 2024 17:18:02 +0100 Message-ID: <20240823161929.1004778-54-ktraynor@redhat.com> In-Reply-To: <20240823161929.1004778-1-ktraynor@redhat.com> References: <20240823161929.1004778-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.8 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 08/28/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/967cb3d5bdde40398f8f964d261ce434876bd9c6 Thanks. Kevin --- >From 967cb3d5bdde40398f8f964d261ce434876bd9c6 Mon Sep 17 00:00:00 2001 From: Hernan Vargas Date: Mon, 24 Jun 2024 08:02:31 -0700 Subject: [PATCH] app/bbdev: fix interrupt tests [ upstream commit fdcee665c5066cd1300d08b85d159ccabf9f3657 ] Fix possible error with regards to setting the burst size from the enqueue thread. Fixes: b2e2aec3239e ("app/bbdev: enhance interrupt test") Signed-off-by: Hernan Vargas Reviewed-by: Maxime Coquelin --- app/test-bbdev/test_bbdev_perf.c | 72 ++++++++++++++++---------------- 1 file changed, 36 insertions(+), 36 deletions(-) diff --git a/app/test-bbdev/test_bbdev_perf.c b/app/test-bbdev/test_bbdev_perf.c index 3f2bac6136..c15ed34b46 100644 --- a/app/test-bbdev/test_bbdev_perf.c +++ b/app/test-bbdev/test_bbdev_perf.c @@ -2820,4 +2820,13 @@ throughput_intr_lcore_ldpc_dec(void *arg) num_to_enq = num_to_process - enqueued; + /* Write to thread burst_sz current number of enqueued + * descriptors. It ensures that proper number of + * descriptors will be dequeued in callback + * function - needed for last batch in case where + * the number of operations is not a multiple of + * burst size. + */ + __atomic_store_n(&tp->burst_sz, num_to_enq, __ATOMIC_RELAXED); + enq = 0; do { @@ -2829,13 +2838,4 @@ throughput_intr_lcore_ldpc_dec(void *arg) enqueued += enq; - /* Write to thread burst_sz current number of enqueued - * descriptors. It ensures that proper number of - * descriptors will be dequeued in callback - * function - needed for last batch in case where - * the number of operations is not a multiple of - * burst size. - */ - __atomic_store_n(&tp->burst_sz, num_to_enq, __ATOMIC_RELAXED); - /* Wait until processing of previous batch is * completed @@ -2908,4 +2908,13 @@ throughput_intr_lcore_dec(void *arg) num_to_enq = num_to_process - enqueued; + /* Write to thread burst_sz current number of enqueued + * descriptors. It ensures that proper number of + * descriptors will be dequeued in callback + * function - needed for last batch in case where + * the number of operations is not a multiple of + * burst size. + */ + __atomic_store_n(&tp->burst_sz, num_to_enq, __ATOMIC_RELAXED); + enq = 0; do { @@ -2916,13 +2925,4 @@ throughput_intr_lcore_dec(void *arg) enqueued += enq; - /* Write to thread burst_sz current number of enqueued - * descriptors. It ensures that proper number of - * descriptors will be dequeued in callback - * function - needed for last batch in case where - * the number of operations is not a multiple of - * burst size. - */ - __atomic_store_n(&tp->burst_sz, num_to_enq, __ATOMIC_RELAXED); - /* Wait until processing of previous batch is * completed @@ -2994,4 +2994,13 @@ throughput_intr_lcore_enc(void *arg) num_to_enq = num_to_process - enqueued; + /* Write to thread burst_sz current number of enqueued + * descriptors. It ensures that proper number of + * descriptors will be dequeued in callback + * function - needed for last batch in case where + * the number of operations is not a multiple of + * burst size. + */ + __atomic_store_n(&tp->burst_sz, num_to_enq, __ATOMIC_RELAXED); + enq = 0; do { @@ -3002,13 +3011,4 @@ throughput_intr_lcore_enc(void *arg) enqueued += enq; - /* Write to thread burst_sz current number of enqueued - * descriptors. It ensures that proper number of - * descriptors will be dequeued in callback - * function - needed for last batch in case where - * the number of operations is not a multiple of - * burst size. - */ - __atomic_store_n(&tp->burst_sz, num_to_enq, __ATOMIC_RELAXED); - /* Wait until processing of previous batch is * completed @@ -3082,4 +3082,13 @@ throughput_intr_lcore_ldpc_enc(void *arg) num_to_enq = num_to_process - enqueued; + /* Write to thread burst_sz current number of enqueued + * descriptors. It ensures that proper number of + * descriptors will be dequeued in callback + * function - needed for last batch in case where + * the number of operations is not a multiple of + * burst size. + */ + __atomic_store_n(&tp->burst_sz, num_to_enq, __ATOMIC_RELAXED); + enq = 0; do { @@ -3091,13 +3100,4 @@ throughput_intr_lcore_ldpc_enc(void *arg) enqueued += enq; - /* Write to thread burst_sz current number of enqueued - * descriptors. It ensures that proper number of - * descriptors will be dequeued in callback - * function - needed for last batch in case where - * the number of operations is not a multiple of - * burst size. - */ - __atomic_store_n(&tp->burst_sz, num_to_enq, __ATOMIC_RELAXED); - /* Wait until processing of previous batch is * completed -- 2.46.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-08-23 17:18:11.505582303 +0100 +++ 0054-app-bbdev-fix-interrupt-tests.patch 2024-08-23 17:18:09.718430098 +0100 @@ -1 +1 @@ -From fdcee665c5066cd1300d08b85d159ccabf9f3657 Mon Sep 17 00:00:00 2001 +From 967cb3d5bdde40398f8f964d261ce434876bd9c6 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit fdcee665c5066cd1300d08b85d159ccabf9f3657 ] + @@ -10 +11,0 @@ -Cc: stable@dpdk.org @@ -15,2 +16,2 @@ - app/test-bbdev/test_bbdev_perf.c | 120 +++++++++++++++---------------- - 1 file changed, 60 insertions(+), 60 deletions(-) + app/test-bbdev/test_bbdev_perf.c | 72 ++++++++++++++++---------------- + 1 file changed, 36 insertions(+), 36 deletions(-) @@ -19 +20 @@ -index 9841464922..20cd8df19b 100644 +index 3f2bac6136..c15ed34b46 100644 @@ -22,61 +23 @@ -@@ -3420,4 +3420,14 @@ throughput_intr_lcore_ldpc_dec(void *arg) - num_to_enq = num_to_process - enqueued; - -+ /* Write to thread burst_sz current number of enqueued -+ * descriptors. It ensures that proper number of -+ * descriptors will be dequeued in callback -+ * function - needed for last batch in case where -+ * the number of operations is not a multiple of -+ * burst size. -+ */ -+ rte_atomic_store_explicit(&tp->burst_sz, num_to_enq, -+ rte_memory_order_relaxed); -+ - enq = 0; - do { -@@ -3429,14 +3439,4 @@ throughput_intr_lcore_ldpc_dec(void *arg) - enqueued += enq; - -- /* Write to thread burst_sz current number of enqueued -- * descriptors. It ensures that proper number of -- * descriptors will be dequeued in callback -- * function - needed for last batch in case where -- * the number of operations is not a multiple of -- * burst size. -- */ -- rte_atomic_store_explicit(&tp->burst_sz, num_to_enq, -- rte_memory_order_relaxed); -- - /* Wait until processing of previous batch is - * completed -@@ -3515,4 +3515,14 @@ throughput_intr_lcore_dec(void *arg) - num_to_enq = num_to_process - enqueued; - -+ /* Write to thread burst_sz current number of enqueued -+ * descriptors. It ensures that proper number of -+ * descriptors will be dequeued in callback -+ * function - needed for last batch in case where -+ * the number of operations is not a multiple of -+ * burst size. -+ */ -+ rte_atomic_store_explicit(&tp->burst_sz, num_to_enq, -+ rte_memory_order_relaxed); -+ - enq = 0; - do { -@@ -3523,14 +3533,4 @@ throughput_intr_lcore_dec(void *arg) - enqueued += enq; - -- /* Write to thread burst_sz current number of enqueued -- * descriptors. It ensures that proper number of -- * descriptors will be dequeued in callback -- * function - needed for last batch in case where -- * the number of operations is not a multiple of -- * burst size. -- */ -- rte_atomic_store_explicit(&tp->burst_sz, num_to_enq, -- rte_memory_order_relaxed); -- - /* Wait until processing of previous batch is - * completed -@@ -3604,4 +3604,14 @@ throughput_intr_lcore_enc(void *arg) +@@ -2820,4 +2820,13 @@ throughput_intr_lcore_ldpc_dec(void *arg) @@ -92,2 +33 @@ -+ rte_atomic_store_explicit(&tp->burst_sz, num_to_enq, -+ rte_memory_order_relaxed); ++ __atomic_store_n(&tp->burst_sz, num_to_enq, __ATOMIC_RELAXED); @@ -97 +37 @@ -@@ -3612,14 +3622,4 @@ throughput_intr_lcore_enc(void *arg) +@@ -2829,13 +2838,4 @@ throughput_intr_lcore_ldpc_dec(void *arg) @@ -107,2 +47 @@ -- rte_atomic_store_explicit(&tp->burst_sz, num_to_enq, -- rte_memory_order_relaxed); +- __atomic_store_n(&tp->burst_sz, num_to_enq, __ATOMIC_RELAXED); @@ -112 +51 @@ -@@ -3695,4 +3695,14 @@ throughput_intr_lcore_ldpc_enc(void *arg) +@@ -2908,4 +2908,13 @@ throughput_intr_lcore_dec(void *arg) @@ -122,2 +61 @@ -+ rte_atomic_store_explicit(&tp->burst_sz, num_to_enq, -+ rte_memory_order_relaxed); ++ __atomic_store_n(&tp->burst_sz, num_to_enq, __ATOMIC_RELAXED); @@ -127 +65 @@ -@@ -3704,14 +3714,4 @@ throughput_intr_lcore_ldpc_enc(void *arg) +@@ -2916,13 +2925,4 @@ throughput_intr_lcore_dec(void *arg) @@ -137,2 +75 @@ -- rte_atomic_store_explicit(&tp->burst_sz, num_to_enq, -- rte_memory_order_relaxed); +- __atomic_store_n(&tp->burst_sz, num_to_enq, __ATOMIC_RELAXED); @@ -142 +79 @@ -@@ -3787,4 +3787,14 @@ throughput_intr_lcore_fft(void *arg) +@@ -2994,4 +2994,13 @@ throughput_intr_lcore_enc(void *arg) @@ -152,2 +89 @@ -+ rte_atomic_store_explicit(&tp->burst_sz, num_to_enq, -+ rte_memory_order_relaxed); ++ __atomic_store_n(&tp->burst_sz, num_to_enq, __ATOMIC_RELAXED); @@ -157 +93 @@ -@@ -3795,14 +3805,4 @@ throughput_intr_lcore_fft(void *arg) +@@ -3002,13 +3011,4 @@ throughput_intr_lcore_enc(void *arg) @@ -167,2 +103 @@ -- rte_atomic_store_explicit(&tp->burst_sz, num_to_enq, -- rte_memory_order_relaxed); +- __atomic_store_n(&tp->burst_sz, num_to_enq, __ATOMIC_RELAXED); @@ -172 +107 @@ -@@ -3873,4 +3873,14 @@ throughput_intr_lcore_mldts(void *arg) +@@ -3082,4 +3082,13 @@ throughput_intr_lcore_ldpc_enc(void *arg) @@ -182,2 +117 @@ -+ rte_atomic_store_explicit(&tp->burst_sz, num_to_enq, -+ rte_memory_order_relaxed); ++ __atomic_store_n(&tp->burst_sz, num_to_enq, __ATOMIC_RELAXED); @@ -187 +121 @@ -@@ -3880,14 +3890,4 @@ throughput_intr_lcore_mldts(void *arg) +@@ -3091,13 +3100,4 @@ throughput_intr_lcore_ldpc_enc(void *arg) @@ -197,2 +131 @@ -- rte_atomic_store_explicit(&tp->burst_sz, num_to_enq, -- rte_memory_order_relaxed); +- __atomic_store_n(&tp->burst_sz, num_to_enq, __ATOMIC_RELAXED);