From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4808045804 for ; Fri, 23 Aug 2024 18:21:53 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 428214337C; Fri, 23 Aug 2024 18:21:53 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 78A5540295 for ; Fri, 23 Aug 2024 18:21:50 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1724430110; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ehCD58UBmDDE1+o4+eZq0IPlI/CzPDr4gdZ+K12rMmE=; b=WWK4XO5v6X7B5KYDs2NENVgGgx1VjTQF82O0Pgd1EmpnoSCwqMrcuqH/I/6IAGD+Tex7wl sOym72/XkMYDmi9aqHTdkBDJmCEsLhhyK5PmlrvmquOaBlVi2cj/fTcK4la79HdqHLprHe 5zinS/JiBaui6cZvaPDK8s4I15ivJQ8= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-270-rW3fwcqCNWSLWy6Rrus5tA-1; Fri, 23 Aug 2024 12:21:48 -0400 X-MC-Unique: rW3fwcqCNWSLWy6Rrus5tA-1 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id E563B1956064; Fri, 23 Aug 2024 16:21:47 +0000 (UTC) Received: from rh.redhat.com (unknown [10.39.193.224]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 7D9C91956053; Fri, 23 Aug 2024 16:21:46 +0000 (UTC) From: Kevin Traynor To: Hemant Agrawal Cc: Maxime Coquelin , dpdk stable Subject: patch 'baseband/la12xx: forbid secondary process' has been queued to stable release 21.11.8 Date: Fri, 23 Aug 2024 17:18:08 +0100 Message-ID: <20240823161929.1004778-60-ktraynor@redhat.com> In-Reply-To: <20240823161929.1004778-1-ktraynor@redhat.com> References: <20240823161929.1004778-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.8 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 08/28/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/f7e28211b7e68e46b3142e62955dd45114429456 Thanks. Kevin --- >From f7e28211b7e68e46b3142e62955dd45114429456 Mon Sep 17 00:00:00 2001 From: Hemant Agrawal Date: Tue, 2 Jul 2024 11:39:21 +0530 Subject: [PATCH] baseband/la12xx: forbid secondary process [ upstream commit 95547dc69119154c85abfa7e8523e83a7ac05c9e ] The la12xx driver do not have any checks for secondary process and it causes the system to try to initialize the driver, causing segmentation faults. LA12xx driver do not support multi-processing. Return when not called from Primary process. Fixes: f218a1f92017 ("baseband/la12xx: introduce NXP LA12xx driver") Signed-off-by: Hemant Agrawal Reviewed-by: Maxime Coquelin --- drivers/baseband/la12xx/bbdev_la12xx.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/baseband/la12xx/bbdev_la12xx.c b/drivers/baseband/la12xx/bbdev_la12xx.c index 4b05b5d3f2..dfebcd5c81 100644 --- a/drivers/baseband/la12xx/bbdev_la12xx.c +++ b/drivers/baseband/la12xx/bbdev_la12xx.c @@ -1077,4 +1077,7 @@ la12xx_bbdev_remove(struct rte_vdev_device *vdev) PMD_INIT_FUNC_TRACE(); + if (rte_eal_process_type() != RTE_PROC_PRIMARY) + return 0; + if (vdev == NULL) return -EINVAL; -- 2.46.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-08-23 17:18:11.647768757 +0100 +++ 0060-baseband-la12xx-forbid-secondary-process.patch 2024-08-23 17:18:09.723430116 +0100 @@ -1 +1 @@ -From 95547dc69119154c85abfa7e8523e83a7ac05c9e Mon Sep 17 00:00:00 2001 +From f7e28211b7e68e46b3142e62955dd45114429456 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 95547dc69119154c85abfa7e8523e83a7ac05c9e ] + @@ -13 +14,0 @@ -Cc: stable@dpdk.org @@ -22 +23 @@ -index bb754a5395..1a56e73abd 100644 +index 4b05b5d3f2..dfebcd5c81 100644 @@ -25 +26 @@ -@@ -1085,4 +1085,7 @@ la12xx_bbdev_remove(struct rte_vdev_device *vdev) +@@ -1077,4 +1077,7 @@ la12xx_bbdev_remove(struct rte_vdev_device *vdev)