From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CFAE145804 for ; Fri, 23 Aug 2024 18:22:28 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C9EA14337C; Fri, 23 Aug 2024 18:22:28 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id E5A7E402BE for ; Fri, 23 Aug 2024 18:22:26 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1724430146; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Jz0qEijIqF6WRzHlvSIpVKjXGqtlseg40WDwZXg5LVk=; b=SYEIiOeOYTvD943wHGp0p9zCuqGkVTZD2rVSjpVGiQBBsbqP9syZd24xECVhYXFwLetB7R gbyJjmIAvQlsKnLNtYy0nASvPZ7DkQEdJGfaPfT24aVFLrgVTdSbJcBCYy8tjK+FnsdMsV XAb3l90EIO9RqORRdp22bV24nrt3lC4= Received: from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-677-ZzNltpTQPO-w4GFsaOiaEg-1; Fri, 23 Aug 2024 12:22:23 -0400 X-MC-Unique: ZzNltpTQPO-w4GFsaOiaEg-1 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 4240F1955D4C; Fri, 23 Aug 2024 16:22:22 +0000 (UTC) Received: from rh.redhat.com (unknown [10.39.193.224]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id F0EC71956053; Fri, 23 Aug 2024 16:22:20 +0000 (UTC) From: Kevin Traynor To: Apeksha Gupta Cc: Vanshika Shukla , dpdk stable Subject: patch 'bus/dpaa: fix memory leak in bus scan' has been queued to stable release 21.11.8 Date: Fri, 23 Aug 2024 17:18:25 +0100 Message-ID: <20240823161929.1004778-77-ktraynor@redhat.com> In-Reply-To: <20240823161929.1004778-1-ktraynor@redhat.com> References: <20240823161929.1004778-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.8 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 08/28/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/705e44a778bea66a1c694c841a275d236620cafc Thanks. Kevin --- >From 705e44a778bea66a1c694c841a275d236620cafc Mon Sep 17 00:00:00 2001 From: Apeksha Gupta Date: Wed, 10 Jul 2024 14:25:28 +0530 Subject: [PATCH] bus/dpaa: fix memory leak in bus scan [ upstream commit de0833ffe31739fd40789b1580025bc849d8871f ] Resource leak: variable dev is going out of scope leaks the storage. Coverity issue: 373703 Fixes: d61138d4f0e2 ("drivers: remove direct access to interrupt handle") Signed-off-by: Apeksha Gupta Signed-off-by: Vanshika Shukla --- drivers/bus/dpaa/dpaa_bus.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/bus/dpaa/dpaa_bus.c b/drivers/bus/dpaa/dpaa_bus.c index 79926c73bb..81ac971fbe 100644 --- a/drivers/bus/dpaa/dpaa_bus.c +++ b/drivers/bus/dpaa/dpaa_bus.c @@ -179,4 +179,5 @@ dpaa_create_device_list(void) DPAA_BUS_LOG(ERR, "Failed to allocate intr handle"); ret = -ENOMEM; + free(dev); goto cleanup; } @@ -230,4 +231,5 @@ dpaa_create_device_list(void) DPAA_BUS_LOG(ERR, "Failed to allocate intr handle"); ret = -ENOMEM; + free(dev); goto cleanup; } -- 2.46.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-08-23 17:18:12.061869638 +0100 +++ 0077-bus-dpaa-fix-memory-leak-in-bus-scan.patch 2024-08-23 17:18:09.754430224 +0100 @@ -1 +1 @@ -From de0833ffe31739fd40789b1580025bc849d8871f Mon Sep 17 00:00:00 2001 +From 705e44a778bea66a1c694c841a275d236620cafc Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit de0833ffe31739fd40789b1580025bc849d8871f ] + @@ -11 +12,0 @@ -Cc: stable@dpdk.org @@ -20 +21 @@ -index b8f41ec069..1f6997c77e 100644 +index 79926c73bb..81ac971fbe 100644 @@ -23 +24 @@ -@@ -189,4 +189,5 @@ dpaa_create_device_list(void) +@@ -179,4 +179,5 @@ dpaa_create_device_list(void) @@ -29 +30 @@ -@@ -240,4 +241,5 @@ dpaa_create_device_list(void) +@@ -230,4 +231,5 @@ dpaa_create_device_list(void)