From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7BAB145804 for ; Fri, 23 Aug 2024 18:22:32 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7583243396; Fri, 23 Aug 2024 18:22:32 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 08F8643386 for ; Fri, 23 Aug 2024 18:22:30 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1724430150; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uxsajFQJNU7/QzgbxMKKHxu5jGuR4Ku53V3wilRO1Bw=; b=gsVR1WkMhyLNfHaQy1MgxqqlZhiStmWQ7jELxOem2rFBNAqV4hEFkVFnxIkUxCZKGldAsf S0H04oF70pdS0f8ywa/4Qu2nQOi5X25iwwGU2x3GrGk+Fm+8te2DW7tSKjkV1sGEi2+oN3 P3Ok94Uv/Wagot1sa121ToyN0KViMe4= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-303-NrnDbT7JOR6iMDPRwL9n3A-1; Fri, 23 Aug 2024 12:22:27 -0400 X-MC-Unique: NrnDbT7JOR6iMDPRwL9n3A-1 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 29BA61955F65; Fri, 23 Aug 2024 16:22:26 +0000 (UTC) Received: from rh.redhat.com (unknown [10.39.193.224]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id BD4E11956053; Fri, 23 Aug 2024 16:22:24 +0000 (UTC) From: Kevin Traynor To: Apeksha Gupta Cc: Vanshika Shukla , dpdk stable Subject: patch 'common/dpaax: fix node array overrun' has been queued to stable release 21.11.8 Date: Fri, 23 Aug 2024 17:18:27 +0100 Message-ID: <20240823161929.1004778-79-ktraynor@redhat.com> In-Reply-To: <20240823161929.1004778-1-ktraynor@redhat.com> References: <20240823161929.1004778-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.8 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 08/28/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/1c47e6f9d235054461e5c0673939d2c0ff4e6463 Thanks. Kevin --- >From 1c47e6f9d235054461e5c0673939d2c0ff4e6463 Mon Sep 17 00:00:00 2001 From: Apeksha Gupta Date: Wed, 10 Jul 2024 14:25:30 +0530 Subject: [PATCH] common/dpaax: fix node array overrun [ upstream commit fae5c5cf59b13efa1fe40d9dd75e0c8731dc46b1 ] Out-of-bounds read, overrunning dynamic array nodes at offset corresponding to index variable j. Fixes: 2f3d633aa593 ("common/dpaax: add library for PA/VA translation table") Signed-off-by: Apeksha Gupta Signed-off-by: Vanshika Shukla --- drivers/common/dpaax/dpaax_iova_table.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/common/dpaax/dpaax_iova_table.c b/drivers/common/dpaax/dpaax_iova_table.c index d2a78f4c19..860e702333 100644 --- a/drivers/common/dpaax/dpaax_iova_table.c +++ b/drivers/common/dpaax/dpaax_iova_table.c @@ -140,8 +140,10 @@ read_memory_node(unsigned int *count) DPAAX_DEBUG("Device-tree memory node data:"); - do { + + while (j > 0) { + --j; DPAAX_DEBUG(" %08" PRIx64 " %08zu", nodes[j].addr, nodes[j].len); - } while (--j); + } cleanup: -- 2.46.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-08-23 17:18:12.106571153 +0100 +++ 0079-common-dpaax-fix-node-array-overrun.patch 2024-08-23 17:18:09.755430228 +0100 @@ -1 +1 @@ -From fae5c5cf59b13efa1fe40d9dd75e0c8731dc46b1 Mon Sep 17 00:00:00 2001 +From 1c47e6f9d235054461e5c0673939d2c0ff4e6463 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit fae5c5cf59b13efa1fe40d9dd75e0c8731dc46b1 ] + @@ -10 +11,0 @@ -Cc: stable@dpdk.org