From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5516545804 for ; Fri, 23 Aug 2024 18:22:32 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4EC434336F; Fri, 23 Aug 2024 18:22:32 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id EEC68402BE for ; Fri, 23 Aug 2024 18:22:30 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1724430150; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=k0PhNq8CciZSEu+xEnfPqRCBLgLZnIz84csmCoEHEic=; b=F6HWItmNitJzHzelaV4ttEBIol7KsNIziI9FGL6dg7aJX/0EmGPLY78L0iW88mEB+jKjoY Ra4e2b1MoqsIyu3bYq4s63mSEFW47DWQx9L7pZJqhaP26a/iAXwL1qqT1mfSjjTBcYFQgQ zoaZBVB8tDyNDRCLcbvG2aF3Gd8oV+c= Received: from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-651-2YXnrFFBMY2AVitBqUnkrA-1; Fri, 23 Aug 2024 12:22:29 -0400 X-MC-Unique: 2YXnrFFBMY2AVitBqUnkrA-1 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 0C8981955D4A; Fri, 23 Aug 2024 16:22:28 +0000 (UTC) Received: from rh.redhat.com (unknown [10.39.193.224]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id C905D1956053; Fri, 23 Aug 2024 16:22:26 +0000 (UTC) From: Kevin Traynor To: Rohit Raj Cc: Vanshika Shukla , dpdk stable Subject: patch 'bus/dpaa: remove redundant file descriptor check' has been queued to stable release 21.11.8 Date: Fri, 23 Aug 2024 17:18:28 +0100 Message-ID: <20240823161929.1004778-80-ktraynor@redhat.com> In-Reply-To: <20240823161929.1004778-1-ktraynor@redhat.com> References: <20240823161929.1004778-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.8 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 08/28/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/bcfe3d206a8f4f8b160f57f0578cc88ed589ef2c Thanks. Kevin --- >From bcfe3d206a8f4f8b160f57f0578cc88ed589ef2c Mon Sep 17 00:00:00 2001 From: Rohit Raj Date: Wed, 10 Jul 2024 14:25:31 +0530 Subject: [PATCH] bus/dpaa: remove redundant file descriptor check [ upstream commit 0ca2093f6b3608467bebe9caf27ce98671fb3381 ] This patch removes the redundant file descriptor check. Coverity issue: 425715 Fixes: 2f3d633aa593 ("common/dpaax: add library for PA/VA translation table") Signed-off-by: Rohit Raj Signed-off-by: Vanshika Shukla --- drivers/bus/dpaa/base/qbman/process.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/bus/dpaa/base/qbman/process.c b/drivers/bus/dpaa/base/qbman/process.c index 9bc92681cd..72fa639987 100644 --- a/drivers/bus/dpaa/base/qbman/process.c +++ b/drivers/bus/dpaa/base/qbman/process.c @@ -2,5 +2,5 @@ * * Copyright 2011-2016 Freescale Semiconductor Inc. - * Copyright 2017,2020 NXP + * Copyright 2017,2020,2022,2024 NXP * */ @@ -28,13 +28,14 @@ static int check_fd(void) int ret; - if (fd >= 0) - return 0; ret = pthread_mutex_lock(&fd_init_lock); assert(!ret); + /* check again with the lock held */ if (fd < 0) fd = open(PROCESS_PATH, O_RDWR); + ret = pthread_mutex_unlock(&fd_init_lock); assert(!ret); + return (fd >= 0) ? 0 : -ENODEV; } -- 2.46.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-08-23 17:18:12.128347905 +0100 +++ 0080-bus-dpaa-remove-redundant-file-descriptor-check.patch 2024-08-23 17:18:09.755430228 +0100 @@ -1 +1 @@ -From 0ca2093f6b3608467bebe9caf27ce98671fb3381 Mon Sep 17 00:00:00 2001 +From bcfe3d206a8f4f8b160f57f0578cc88ed589ef2c Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 0ca2093f6b3608467bebe9caf27ce98671fb3381 ] + @@ -10 +11,0 @@ -Cc: stable@dpdk.org @@ -19 +20 @@ -index 59e0d641ce..2d805c5bd9 100644 +index 9bc92681cd..72fa639987 100644 @@ -29 +30 @@ -@@ -29,13 +29,14 @@ static int check_fd(void) +@@ -28,13 +28,14 @@ static int check_fd(void)