From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 43D7B45804 for ; Fri, 23 Aug 2024 18:23:01 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3F4E34336F; Fri, 23 Aug 2024 18:23:01 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 6F9C7402BE for ; Fri, 23 Aug 2024 18:22:59 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1724430179; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QqMotNGuVmE9ZWoYF8Cv/8TYCggWvcGEU7d8Vuy+6hE=; b=XJ11OmchxFe25zbtQNIuftveTqIB9C1T1FIXcDxxw7ef21irpEk8OGHTGHAXi2nm7Cy9f4 MrAMbQTMdvIrDzs/YmHvFkltSNZShG8fZ2vaeVOcj8e2zNrag7MgiqrPOiGsYULBhf0jd1 4yUaPRKMVx9RtiiChyUWq5hnYl57wXA= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-653-eeZAy7FfOd2K0MmCBiFfaQ-1; Fri, 23 Aug 2024 12:22:56 -0400 X-MC-Unique: eeZAy7FfOd2K0MmCBiFfaQ-1 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 0E15E1955F43; Fri, 23 Aug 2024 16:22:55 +0000 (UTC) Received: from rh.redhat.com (unknown [10.39.193.224]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 865471956053; Fri, 23 Aug 2024 16:22:53 +0000 (UTC) From: Kevin Traynor To: Dengdui Huang Cc: Aman Singh , dpdk stable Subject: patch 'app/testpmd: handle IEEE1588 init failure' has been queued to stable release 21.11.8 Date: Fri, 23 Aug 2024 17:18:40 +0100 Message-ID: <20240823161929.1004778-92-ktraynor@redhat.com> In-Reply-To: <20240823161929.1004778-1-ktraynor@redhat.com> References: <20240823161929.1004778-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.8 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 08/28/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/af2127b83fe7a4f1b77ec920889f6ce86a2894ed Thanks. Kevin --- >From af2127b83fe7a4f1b77ec920889f6ce86a2894ed Mon Sep 17 00:00:00 2001 From: Dengdui Huang Date: Sat, 30 Mar 2024 15:44:09 +0800 Subject: [PATCH] app/testpmd: handle IEEE1588 init failure [ upstream commit 80071a1c8ed669298434c56efe4ca0839f2a970e ] When the port's timestamping function failed to initialize (for example, the device does not support PTP), the packets received by the hardware do not contain the timestamp. In this case, IEEE1588 packet forwarding should not start. This patch fix it. Plus, adding a failure message when failed to disable PTP. Fixes: a78040c990cb ("app/testpmd: update forward engine beginning") Signed-off-by: Dengdui Huang Acked-by: Aman Singh --- app/test-pmd/ieee1588fwd.c | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/app/test-pmd/ieee1588fwd.c b/app/test-pmd/ieee1588fwd.c index 896d5ef26a..8d9ce4d6ce 100644 --- a/app/test-pmd/ieee1588fwd.c +++ b/app/test-pmd/ieee1588fwd.c @@ -202,6 +202,11 @@ static int port_ieee1588_fwd_begin(portid_t pi) { - rte_eth_timesync_enable(pi); - return 0; + int ret; + + ret = rte_eth_timesync_enable(pi); + if (ret) + printf("Port %u enable PTP failed, ret = %d\n", pi, ret); + + return ret; } @@ -209,5 +214,9 @@ static void port_ieee1588_fwd_end(portid_t pi) { - rte_eth_timesync_disable(pi); + int ret; + + ret = rte_eth_timesync_disable(pi); + if (ret) + printf("Port %u disable PTP failed, ret = %d\n", pi, ret); } -- 2.46.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-08-23 17:18:12.435691671 +0100 +++ 0092-app-testpmd-handle-IEEE1588-init-failure.patch 2024-08-23 17:18:09.791430353 +0100 @@ -1 +1 @@ -From 80071a1c8ed669298434c56efe4ca0839f2a970e Mon Sep 17 00:00:00 2001 +From af2127b83fe7a4f1b77ec920889f6ce86a2894ed Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 80071a1c8ed669298434c56efe4ca0839f2a970e ] + @@ -15 +16,0 @@ -Cc: stable@dpdk.org @@ -24 +25 @@ -index 3371771751..afea7735c7 100644 +index 896d5ef26a..8d9ce4d6ce 100644 @@ -27 +28 @@ -@@ -198,6 +198,11 @@ static int +@@ -202,6 +202,11 @@ static int @@ -41 +42 @@ -@@ -205,5 +210,9 @@ static void +@@ -209,5 +214,9 @@ static void