From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 25287458BC for ; Sat, 31 Aug 2024 19:10:49 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EF494402A7; Sat, 31 Aug 2024 19:10:48 +0200 (CEST) Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) by mails.dpdk.org (Postfix) with ESMTP id E94BB40263 for ; Sat, 31 Aug 2024 19:10:47 +0200 (CEST) Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-20551e2f1f8so3343185ad.2 for ; Sat, 31 Aug 2024 10:10:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1725124247; x=1725729047; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=sDUO96VV0QFvdJOAUR4A4IbTlJOrAHeCTToXP5NtdDo=; b=LhwV9eQvsfr8JDCBg1cPgOHhS1AFhRMSTXH0CYkH2sjJGZpiyMjiSL3hdv8kW/T+ZV zILQXgxsDFJnbxo4xNMZmxhc1XIyIpR2GFAgpX13p0AHAJFyC0uSbTLCe4UdiB2eXjwe 3LMN7VX0Ye7Avt21EiIFq39qxaQZfRhbWsHycmaYX9tIYEHBozqGC5lVooXjIATVkUe/ VB28IhyooYsNLjE2MXJyJmmR7ASY/MOwBcvpZeQhHg66jJlEjNKXM8u+2L3e1eJe8BFC /XF3Gd1R0ZzUgOUpEQWH409H31hHvmCSs0VCDp7ADgn7nN9Uoi55mxgSlo9dDGzfbtit ACLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725124247; x=1725729047; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=sDUO96VV0QFvdJOAUR4A4IbTlJOrAHeCTToXP5NtdDo=; b=lererXCKKLUrGxH3/GuuQ9vnHfQkOOdsIgnjyoVwRX7psIqkOoOsKag/5azINLhSDH 0f1saJwmvZnCk/iBj9VuMbYQ2e3NRPxMZbxKamhWL97ZSJRLhSbnAn1U5nXpurMECque QbtBrykVtHQ/glkZWIfpY4w/4+gO4soAh3NnSm2J5/tRJ2C7eJEUL2I+EJiZEU+kmiKq yXXpJCjhj1wnLa8MmoLezLqztE7tXymlJrBW92jbBmSqJXrmpy+yw56QrsBg72inqNw/ 3qz6zpQwZMfi/NHugQjNSe2prXKHjW2WZ+QoF01ga5s+SljSI4I2A8mM3V3tXOrw0J19 gCoA== X-Forwarded-Encrypted: i=1; AJvYcCUaW8HVOMuwis0Rf2shtIRPWC02FZ7BFjnO3GDKYG4h3UQgRRFPM+HAVC0X6jxGz+1bpXJBbmg=@dpdk.org X-Gm-Message-State: AOJu0YzqTHn8nYRsPMQH1hIcx/4QU9yJnuRmdj6OJ2rsN287i5LOQzEu KM/ad5ktVUGZPsr3LxVpLOTZ1Sa5AWyGoa+q6f7TQF5G9+FVo/P/3VZWwKE1yDQ= X-Google-Smtp-Source: AGHT+IFB537BP8DMMX0Shcd0qTkQS41nYZlYU4PImcUKEfogjSr4MXPbwPWr++WAMy+kAUWK1IxZeg== X-Received: by 2002:a17:902:e80a:b0:205:5410:5738 with SMTP id d9443c01a7336-205541057camr13689295ad.27.1725124246918; Sat, 31 Aug 2024 10:10:46 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-205152cf12bsm43141735ad.83.2024.08.31.10.10.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 31 Aug 2024 10:10:46 -0700 (PDT) From: Stephen Hemminger To: Kevin Traynor Cc: Stephen Hemminger , stable@dpdk.org, Chengwen Feng Subject: [PATCH 1/5] cmdline: make rdline status not private Date: Sat, 31 Aug 2024 10:09:25 -0700 Message-ID: <20240831171035.27505-2-stephen@networkplumber.org> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20240831171035.27505-1-stephen@networkplumber.org> References: <20240831171035.27505-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org The function cmdline_poll() returns values from rdline_status enum but that was moved to being defined only in cmdline_private.h. For proper use of the API the return value needs to be visible to callers. This was not a problem before because cmdline_poll() was not used anywhere. Fixes: f8f8dc289095 ("cmdline: make struct rdline opaque") Cc: stable@dpdk.org Signed-off-by: Stephen Hemminger Acked-by: Chengwen Feng (cherry picked from commit 1ac8dd1d1b62c59cd440e5529e3bd5a500e72f76) --- lib/cmdline/cmdline.h | 6 ++++++ lib/cmdline/cmdline_private.h | 6 ------ 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/lib/cmdline/cmdline.h b/lib/cmdline/cmdline.h index 96674dfda2..b14355ef51 100644 --- a/lib/cmdline/cmdline.h +++ b/lib/cmdline/cmdline.h @@ -23,6 +23,12 @@ extern "C" { #endif +enum rdline_status { + RDLINE_INIT, + RDLINE_RUNNING, + RDLINE_EXITED +}; + struct cmdline; struct cmdline *cmdline_new(cmdline_parse_ctx_t *ctx, const char *prompt, int s_in, int s_out); diff --git a/lib/cmdline/cmdline_private.h b/lib/cmdline/cmdline_private.h index c2e906d8de..a3271c7693 100644 --- a/lib/cmdline/cmdline_private.h +++ b/lib/cmdline/cmdline_private.h @@ -23,12 +23,6 @@ #define RDLINE_HISTORY_BUF_SIZE BUFSIZ #define RDLINE_HISTORY_MAX_LINE 64 -enum rdline_status { - RDLINE_INIT, - RDLINE_RUNNING, - RDLINE_EXITED -}; - struct rdline { enum rdline_status status; /* rdline bufs */ -- 2.45.2