From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 602CD45A9F for ; Wed, 2 Oct 2024 20:39:46 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 990E440672; Wed, 2 Oct 2024 20:39:42 +0200 (CEST) Received: from mail-pf1-f176.google.com (mail-pf1-f176.google.com [209.85.210.176]) by mails.dpdk.org (Postfix) with ESMTP id DA7704065F for ; Wed, 2 Oct 2024 20:39:35 +0200 (CEST) Received: by mail-pf1-f176.google.com with SMTP id d2e1a72fcca58-71b070ff24dso158422b3a.2 for ; Wed, 02 Oct 2024 11:39:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1727894375; x=1728499175; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=tvq5E5KXslKNmPC408QbgP3MTNkCviUF5WUYmeRxPkg=; b=LBAY0bPP0nlvD4VGgM+SsuLcn8mOp7NFCQ0JNh/57rOAb17/jUtsEBIpJQR8X/PBbN ktlV4AbcIvvn3I+9CkZ+4v5HwbPpgmJttbPcVwIAO54u/mAKBX0zz+bZkp3LRCsTlFSh F9IovUoSyGO4Co4wHQvxIgWdYpIRSmTITNYeJV+zVFarkOVljWYIW/1IeUdnwAabloow 9EVV0CQZTktH9ZrS+tK9Ge6eHAddwLYvp4T57DIBJbdh+G+EJsCjpDGbf1C4c9xHttyA 0hU3MoRWgdYz+CrOQbvwvR5UD2Z0j17gArk5r7BCaOMVa1k8ngYvR80MLmO5HKq9QOFV 9mEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727894375; x=1728499175; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=tvq5E5KXslKNmPC408QbgP3MTNkCviUF5WUYmeRxPkg=; b=hUgbIuxXtwxKm5Bl245VKJlvFXwVtyTOrTECJrdRu0yhcMNNqKVbe3O5YswsfRI3C+ iyOhs21jpF4GmJ5NmtEERP2wDo1At+BySPmfyfhJfYZxnY4ev+29FodzqgGNj9gCJxZl T1v3Sz1DryHNKJdlQeZoCiuyjgh9M4c7t3NonQnTcYtRf2i1ISssH/gGJjRZC7akz3tr NZdambBtS4YQe+cllpC2Q5DGuH9MeDJx935FFzR1R+4h7rHXqgdj+WJsb+qZIP/xeK/B q/84VhZVyW0dJ0adfs9y0w3BOtvinC/XB2ePF1xj+hq4I5jc5n1P8Kcl7h+ZkrWuuEip /9ww== X-Forwarded-Encrypted: i=1; AJvYcCWR3YRoZfN02jVl5FqoeaQgoghdnMFw2EfkA7g6dWBaPIbu90Lg3f/HrQe6w66IrXh6pZjJkjk=@dpdk.org X-Gm-Message-State: AOJu0Yz8Lc3YDArMMcUtWfuHKpk7bdWB0kmLWeDiSSXhsKW1ZLEUtot3 +3AteP96aqWBB1mn26Y8LFiSmx5jpY+e3+ygzSKihTgJ+1QG6zFaknOfo7DJU5h/GNBIuoE51ax g X-Google-Smtp-Source: AGHT+IH4F3YmVOkED5fyBIaoESMR9bz0Y4TWJjegHu7iS1orgDMabLVUoK+lvlA2EVQl8rOXsKW5QQ== X-Received: by 2002:a05:6a00:2283:b0:718:e164:91fd with SMTP id d2e1a72fcca58-71dc5c6767emr5996899b3a.11.1727894374952; Wed, 02 Oct 2024 11:39:34 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-71b2649b0bdsm10104362b3a.34.2024.10.02.11.39.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Oct 2024 11:39:34 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , stable@dpdk.org, Wei Zhao Subject: [PATCH v7 08/16] net/e1000: fix use-after-free Date: Wed, 2 Oct 2024 11:37:46 -0700 Message-ID: <20241002183918.161656-9-stephen@networkplumber.org> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20241002183918.161656-1-stephen@networkplumber.org> References: <20240927204742.546164-1-stephen@networkplumber.org> <20241002183918.161656-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org The driver cleanup code was freeing the filter object then dereferencing it. Bugzilla ID: 1550 Fixes: 6a4d050e2855 ("net/igb: flush all the filter") Cc: stable@dpdk.org Signed-off-by: Stephen Hemminger --- drivers/net/e1000/igb_ethdev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/e1000/igb_ethdev.c b/drivers/net/e1000/igb_ethdev.c index 095be27b08..973d0d2407 100644 --- a/drivers/net/e1000/igb_ethdev.c +++ b/drivers/net/e1000/igb_ethdev.c @@ -3907,11 +3907,11 @@ igb_delete_2tuple_filter(struct rte_eth_dev *dev, filter_info->twotuple_mask &= ~(1 << filter->index); TAILQ_REMOVE(&filter_info->twotuple_list, filter, entries); - rte_free(filter); E1000_WRITE_REG(hw, E1000_TTQF(filter->index), E1000_TTQF_DISABLE_MASK); E1000_WRITE_REG(hw, E1000_IMIR(filter->index), 0); E1000_WRITE_REG(hw, E1000_IMIREXT(filter->index), 0); + rte_free(filter); return 0; } @@ -4348,7 +4348,6 @@ igb_delete_5tuple_filter_82576(struct rte_eth_dev *dev, filter_info->fivetuple_mask &= ~(1 << filter->index); TAILQ_REMOVE(&filter_info->fivetuple_list, filter, entries); - rte_free(filter); E1000_WRITE_REG(hw, E1000_FTQF(filter->index), E1000_FTQF_VF_BP | E1000_FTQF_MASK); @@ -4357,6 +4356,7 @@ igb_delete_5tuple_filter_82576(struct rte_eth_dev *dev, E1000_WRITE_REG(hw, E1000_SPQF(filter->index), 0); E1000_WRITE_REG(hw, E1000_IMIR(filter->index), 0); E1000_WRITE_REG(hw, E1000_IMIREXT(filter->index), 0); + rte_free(filter); return 0; } -- 2.45.2