* [PATCH v1 1/1] baseband/acc: fix ring memory allocation logic [not found] <20241030185614.1605876-1-nicolas.chautru@intel.com> @ 2024-10-30 18:56 ` Nicolas Chautru 2024-11-05 13:55 ` Maxime Coquelin 0 siblings, 1 reply; 2+ messages in thread From: Nicolas Chautru @ 2024-10-30 18:56 UTC (permalink / raw) To: dev, maxime.coquelin Cc: hemant.agrawal, hernan.vargas, Nicolas Chautru, stable Allowing ring memory allocation whose end address is aligned with 64 MB. Previous logic was off by one. Fixes: 060e76729302 ("baseband/acc100: add queue configuration") Cc: stable@dpdk.org Signed-off-by: Nicolas Chautru <nicolas.chautru@intel.com> --- drivers/baseband/acc/acc_common.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/baseband/acc/acc_common.h b/drivers/baseband/acc/acc_common.h index 4c60b7896b..55b43bab4e 100644 --- a/drivers/baseband/acc/acc_common.h +++ b/drivers/baseband/acc/acc_common.h @@ -800,7 +800,7 @@ alloc_sw_rings_min_mem(struct rte_bbdev *dev, struct acc_device *d, /* Check if the end of the sw ring memory block is before the * start of next 64MB aligned mem address */ - if (sw_ring_iova_end_addr < next_64mb_align_addr_iova) { + if (sw_ring_iova_end_addr <= next_64mb_align_addr_iova) { d->sw_rings_iova = sw_rings_base_iova; d->sw_rings = sw_rings_base; d->sw_rings_base = sw_rings_base; -- 2.34.1 ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH v1 1/1] baseband/acc: fix ring memory allocation logic 2024-10-30 18:56 ` [PATCH v1 1/1] baseband/acc: fix ring memory allocation logic Nicolas Chautru @ 2024-11-05 13:55 ` Maxime Coquelin 0 siblings, 0 replies; 2+ messages in thread From: Maxime Coquelin @ 2024-11-05 13:55 UTC (permalink / raw) To: Nicolas Chautru, dev; +Cc: hemant.agrawal, hernan.vargas, stable Hi Nicolas, On 10/30/24 19:56, Nicolas Chautru wrote: > Allowing ring memory allocation whose end address is aligned with 64 MB. > Previous logic was off by one. > > Fixes: 060e76729302 ("baseband/acc100: add queue configuration") > Cc: stable@dpdk.org > > Signed-off-by: Nicolas Chautru <nicolas.chautru@intel.com> > --- > drivers/baseband/acc/acc_common.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/baseband/acc/acc_common.h b/drivers/baseband/acc/acc_common.h > index 4c60b7896b..55b43bab4e 100644 > --- a/drivers/baseband/acc/acc_common.h > +++ b/drivers/baseband/acc/acc_common.h > @@ -800,7 +800,7 @@ alloc_sw_rings_min_mem(struct rte_bbdev *dev, struct acc_device *d, > /* Check if the end of the sw ring memory block is before the > * start of next 64MB aligned mem address > */ > - if (sw_ring_iova_end_addr < next_64mb_align_addr_iova) { > + if (sw_ring_iova_end_addr <= next_64mb_align_addr_iova) { > d->sw_rings_iova = sw_rings_base_iova; > d->sw_rings = sw_rings_base; > d->sw_rings_base = sw_rings_base; IMHO, the proper fix would be to fix sw_ring_iova_end_addr to really represent the last address of the block and not the start address ofthe next one: sw_ring_iova_end_addr = sw_rings_base_iova + dev_sw_ring_size - 1; Regards, Maxime ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-11-05 13:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20241030185614.1605876-1-nicolas.chautru@intel.com>
2024-10-30 18:56 ` [PATCH v1 1/1] baseband/acc: fix ring memory allocation logic Nicolas Chautru
2024-11-05 13:55 ` Maxime Coquelin
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).