From: Bruce Richardson <bruce.richardson@intel.com>
To: dev@dpdk.org
Cc: Bruce Richardson <bruce.richardson@intel.com>,
stable@dpdk.org, Stephen Hemminger <stephen@networkplumber.org>
Subject: [PATCH] app/dumpcap: remove unused struct array
Date: Tue, 5 Nov 2024 11:27:21 +0000 [thread overview]
Message-ID: <20241105112721.373285-1-bruce.richardson@intel.com> (raw)
The callbacks(rx_cb) member of struct interface was unused inside
dumpcap, but was taking up a lot of memory space, since it was scaled
according to RTE_MAX_QUEUES_PER_PORT, which is 1k by default. Save
memory by removing the whole array.
Fixes: cbb44143be74 ("app/dumpcap: add new packet capture application")
Cc: stable@dpdk.org
Suggested-by: Stephen Hemminger <stephen@networkplumber.org>
Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
app/dumpcap/main.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/app/dumpcap/main.c b/app/dumpcap/main.c
index 4031f48441..3d3c0dbc66 100644
--- a/app/dumpcap/main.c
+++ b/app/dumpcap/main.c
@@ -96,7 +96,6 @@ struct interface {
struct rte_bpf_prm *bpf_prm;
char name[RTE_ETH_NAME_MAX_LEN];
- struct rte_rxtx_callback *rx_cb[RTE_MAX_QUEUES_PER_PORT];
const char *ifname;
const char *ifdescr;
};
--
2.43.0
next reply other threads:[~2024-11-05 11:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-05 11:27 Bruce Richardson [this message]
2024-11-06 18:18 ` Stephen Hemminger
2024-11-06 20:35 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241105112721.373285-1-bruce.richardson@intel.com \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).