* [PATCH v5 08/20] net/ice: remove use of VLAs for Windows built code
[not found] ` <1731026691-1529-1-git-send-email-andremue@linux.microsoft.com>
@ 2024-11-08 0:44 ` Andre Muezerie
2024-11-08 8:51 ` Bruce Richardson
0 siblings, 1 reply; 6+ messages in thread
From: Andre Muezerie @ 2024-11-08 0:44 UTC (permalink / raw)
To: dev; +Cc: Konstantin Ananyev, stable
From: Konstantin Ananyev <konstantin.ananyev@huawei.com>
gro_vxlan_tcp4_tbl_timeout_flush() is called without taking into account
that first entries in pkts[] can be already occupied by
un-processed packets.
Fixes: 74080d7dcf31 ("gro: support IPv6 for TCP")
Cc: stable@dpdk.org
Signed-off-by: Konstantin Ananyev <konstantin.ananyev@huawei.com>
Acked-by: Ferruh Yigit <ferruh.yigit@amd.com>
---
lib/gro/rte_gro.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/gro/rte_gro.c b/lib/gro/rte_gro.c
index d824eebd93..db86117609 100644
--- a/lib/gro/rte_gro.c
+++ b/lib/gro/rte_gro.c
@@ -327,7 +327,7 @@ rte_gro_reassemble_burst(struct rte_mbuf **pkts,
/* Flush all packets from the tables */
if (do_vxlan_tcp_gro) {
i += gro_vxlan_tcp4_tbl_timeout_flush(&vxlan_tcp_tbl,
- 0, pkts, nb_pkts);
+ 0, &pkts[i], nb_pkts - i);
}
if (do_vxlan_udp_gro) {
--
2.34.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v5 08/20] net/ice: remove use of VLAs for Windows built code
2024-11-08 0:44 ` [PATCH v5 08/20] net/ice: remove use of VLAs for Windows built code Andre Muezerie
@ 2024-11-08 8:51 ` Bruce Richardson
2024-11-08 10:18 ` Konstantin Ananyev
2024-11-08 21:17 ` Andre Muezerie
0 siblings, 2 replies; 6+ messages in thread
From: Bruce Richardson @ 2024-11-08 8:51 UTC (permalink / raw)
To: Andre Muezerie; +Cc: dev, Konstantin Ananyev, stable
Title for this patch is incorrect. Does it belong merged with the next
patch in series?
On Thu, Nov 07, 2024 at 04:44:39PM -0800, Andre Muezerie wrote:
> From: Konstantin Ananyev <konstantin.ananyev@huawei.com>
>
> gro_vxlan_tcp4_tbl_timeout_flush() is called without taking into account
> that first entries in pkts[] can be already occupied by
> un-processed packets.
>
> Fixes: 74080d7dcf31 ("gro: support IPv6 for TCP")
> Cc: stable@dpdk.org
>
> Signed-off-by: Konstantin Ananyev <konstantin.ananyev@huawei.com>
> Acked-by: Ferruh Yigit <ferruh.yigit@amd.com>
> ---
> lib/gro/rte_gro.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/gro/rte_gro.c b/lib/gro/rte_gro.c
> index d824eebd93..db86117609 100644
> --- a/lib/gro/rte_gro.c
> +++ b/lib/gro/rte_gro.c
> @@ -327,7 +327,7 @@ rte_gro_reassemble_burst(struct rte_mbuf **pkts,
> /* Flush all packets from the tables */
> if (do_vxlan_tcp_gro) {
> i += gro_vxlan_tcp4_tbl_timeout_flush(&vxlan_tcp_tbl,
> - 0, pkts, nb_pkts);
> + 0, &pkts[i], nb_pkts - i);
> }
>
> if (do_vxlan_udp_gro) {
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH v5 08/20] net/ice: remove use of VLAs for Windows built code
2024-11-08 8:51 ` Bruce Richardson
@ 2024-11-08 10:18 ` Konstantin Ananyev
2024-11-08 21:21 ` Andre Muezerie
2024-11-08 21:17 ` Andre Muezerie
1 sibling, 1 reply; 6+ messages in thread
From: Konstantin Ananyev @ 2024-11-08 10:18 UTC (permalink / raw)
To: Bruce Richardson, Andre Muezerie; +Cc: dev, stable
>
> Title for this patch is incorrect. Does it belong merged with the next
> patch in series?
Yes, seems like oringianl title get lost, I think it needs to be:
gro: fix overwrite unprocessed packets
https://patchwork.dpdk.org/project/dpdk/patch/20240523162604.2600-2-konstantin.v.ananyev@yandex.ru/
>
> On Thu, Nov 07, 2024 at 04:44:39PM -0800, Andre Muezerie wrote:
> > From: Konstantin Ananyev <konstantin.ananyev@huawei.com>
> >
> > gro_vxlan_tcp4_tbl_timeout_flush() is called without taking into account
> > that first entries in pkts[] can be already occupied by
> > un-processed packets.
> >
> > Fixes: 74080d7dcf31 ("gro: support IPv6 for TCP")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Konstantin Ananyev <konstantin.ananyev@huawei.com>
> > Acked-by: Ferruh Yigit <ferruh.yigit@amd.com>
> > ---
> > lib/gro/rte_gro.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/lib/gro/rte_gro.c b/lib/gro/rte_gro.c
> > index d824eebd93..db86117609 100644
> > --- a/lib/gro/rte_gro.c
> > +++ b/lib/gro/rte_gro.c
> > @@ -327,7 +327,7 @@ rte_gro_reassemble_burst(struct rte_mbuf **pkts,
> > /* Flush all packets from the tables */
> > if (do_vxlan_tcp_gro) {
> > i += gro_vxlan_tcp4_tbl_timeout_flush(&vxlan_tcp_tbl,
> > - 0, pkts, nb_pkts);
> > + 0, &pkts[i], nb_pkts - i);
> > }
> >
> > if (do_vxlan_udp_gro) {
> > --
> > 2.34.1
> >
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v5 08/20] net/ice: remove use of VLAs for Windows built code
2024-11-08 8:51 ` Bruce Richardson
2024-11-08 10:18 ` Konstantin Ananyev
@ 2024-11-08 21:17 ` Andre Muezerie
1 sibling, 0 replies; 6+ messages in thread
From: Andre Muezerie @ 2024-11-08 21:17 UTC (permalink / raw)
To: Bruce Richardson; +Cc: dev, Konstantin Ananyev, stable
On Fri, Nov 08, 2024 at 08:51:00AM +0000, Bruce Richardson wrote:
> Title for this patch is incorrect. Does it belong merged with the next
> patch in series?
Indeed, I used the wrong title for this patch. I'll fix it in v6.
>
> On Thu, Nov 07, 2024 at 04:44:39PM -0800, Andre Muezerie wrote:
> > From: Konstantin Ananyev <konstantin.ananyev@huawei.com>
> >
> > gro_vxlan_tcp4_tbl_timeout_flush() is called without taking into account
> > that first entries in pkts[] can be already occupied by
> > un-processed packets.
> >
> > Fixes: 74080d7dcf31 ("gro: support IPv6 for TCP")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Konstantin Ananyev <konstantin.ananyev@huawei.com>
> > Acked-by: Ferruh Yigit <ferruh.yigit@amd.com>
> > ---
> > lib/gro/rte_gro.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/lib/gro/rte_gro.c b/lib/gro/rte_gro.c
> > index d824eebd93..db86117609 100644
> > --- a/lib/gro/rte_gro.c
> > +++ b/lib/gro/rte_gro.c
> > @@ -327,7 +327,7 @@ rte_gro_reassemble_burst(struct rte_mbuf **pkts,
> > /* Flush all packets from the tables */
> > if (do_vxlan_tcp_gro) {
> > i += gro_vxlan_tcp4_tbl_timeout_flush(&vxlan_tcp_tbl,
> > - 0, pkts, nb_pkts);
> > + 0, &pkts[i], nb_pkts - i);
> > }
> >
> > if (do_vxlan_udp_gro) {
> > --
> > 2.34.1
> >
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v5 08/20] net/ice: remove use of VLAs for Windows built code
2024-11-08 10:18 ` Konstantin Ananyev
@ 2024-11-08 21:21 ` Andre Muezerie
0 siblings, 0 replies; 6+ messages in thread
From: Andre Muezerie @ 2024-11-08 21:21 UTC (permalink / raw)
To: Konstantin Ananyev; +Cc: Bruce Richardson, dev, stable
On Fri, Nov 08, 2024 at 10:18:31AM +0000, Konstantin Ananyev wrote:
>
>
> >
> > Title for this patch is incorrect. Does it belong merged with the next
> > patch in series?
>
> Yes, seems like oringianl title get lost, I think it needs to be:
> gro: fix overwrite unprocessed packets
> https://patchwork.dpdk.org/project/dpdk/patch/20240523162604.2600-2-konstantin.v.ananyev@yandex.ru/
>
Yes, I made a mistake. I'll fix it in v6 alonmg with other small changes.
> >
> > On Thu, Nov 07, 2024 at 04:44:39PM -0800, Andre Muezerie wrote:
> > > From: Konstantin Ananyev <konstantin.ananyev@huawei.com>
> > >
> > > gro_vxlan_tcp4_tbl_timeout_flush() is called without taking into account
> > > that first entries in pkts[] can be already occupied by
> > > un-processed packets.
> > >
> > > Fixes: 74080d7dcf31 ("gro: support IPv6 for TCP")
> > > Cc: stable@dpdk.org
> > >
> > > Signed-off-by: Konstantin Ananyev <konstantin.ananyev@huawei.com>
> > > Acked-by: Ferruh Yigit <ferruh.yigit@amd.com>
> > > ---
> > > lib/gro/rte_gro.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/lib/gro/rte_gro.c b/lib/gro/rte_gro.c
> > > index d824eebd93..db86117609 100644
> > > --- a/lib/gro/rte_gro.c
> > > +++ b/lib/gro/rte_gro.c
> > > @@ -327,7 +327,7 @@ rte_gro_reassemble_burst(struct rte_mbuf **pkts,
> > > /* Flush all packets from the tables */
> > > if (do_vxlan_tcp_gro) {
> > > i += gro_vxlan_tcp4_tbl_timeout_flush(&vxlan_tcp_tbl,
> > > - 0, pkts, nb_pkts);
> > > + 0, &pkts[i], nb_pkts - i);
> > > }
> > >
> > > if (do_vxlan_udp_gro) {
> > > --
> > > 2.34.1
> > >
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v6 08/20] gro: fix overwrite unprocessed packets
[not found] ` <1731116892-17109-1-git-send-email-andremue@linux.microsoft.com>
@ 2024-11-09 1:48 ` Andre Muezerie
0 siblings, 0 replies; 6+ messages in thread
From: Andre Muezerie @ 2024-11-09 1:48 UTC (permalink / raw)
To: dev; +Cc: Konstantin Ananyev, stable
From: Konstantin Ananyev <konstantin.ananyev@huawei.com>
gro_vxlan_tcp4_tbl_timeout_flush() is called without taking into account
that first entries in pkts[] can be already occupied by
un-processed packets.
Fixes: 74080d7dcf31 ("gro: support IPv6 for TCP")
Cc: stable@dpdk.org
Signed-off-by: Konstantin Ananyev <konstantin.ananyev@huawei.com>
Acked-by: Ferruh Yigit <ferruh.yigit@amd.com>
---
lib/gro/rte_gro.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/gro/rte_gro.c b/lib/gro/rte_gro.c
index d824eebd93..db86117609 100644
--- a/lib/gro/rte_gro.c
+++ b/lib/gro/rte_gro.c
@@ -327,7 +327,7 @@ rte_gro_reassemble_burst(struct rte_mbuf **pkts,
/* Flush all packets from the tables */
if (do_vxlan_tcp_gro) {
i += gro_vxlan_tcp4_tbl_timeout_flush(&vxlan_tcp_tbl,
- 0, pkts, nb_pkts);
+ 0, &pkts[i], nb_pkts - i);
}
if (do_vxlan_udp_gro) {
--
2.34.1
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2024-11-09 1:48 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <1713397319-26135-1-git-send-email-roretzla@linux.microsoft.com>
[not found] ` <1731026691-1529-1-git-send-email-andremue@linux.microsoft.com>
2024-11-08 0:44 ` [PATCH v5 08/20] net/ice: remove use of VLAs for Windows built code Andre Muezerie
2024-11-08 8:51 ` Bruce Richardson
2024-11-08 10:18 ` Konstantin Ananyev
2024-11-08 21:21 ` Andre Muezerie
2024-11-08 21:17 ` Andre Muezerie
[not found] ` <1731116892-17109-1-git-send-email-andremue@linux.microsoft.com>
2024-11-09 1:48 ` [PATCH v6 08/20] gro: fix overwrite unprocessed packets Andre Muezerie
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).