From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6A24445CB7 for ; Fri, 8 Nov 2024 22:22:00 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 629E940263; Fri, 8 Nov 2024 22:22:00 +0100 (CET) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id EBF4140263; Fri, 8 Nov 2024 22:21:58 +0100 (CET) Received: by linux.microsoft.com (Postfix, from userid 1213) id 2B1EB212D50E; Fri, 8 Nov 2024 13:21:58 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 2B1EB212D50E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1731100918; bh=jwW2pCwFQk4Q2MfIT48Jm/ap9N7sCizg93OBWjgeGhs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fXw535iFGPftBZcXv85G+zff12DUWHtD4eL5vwhKia3qC2x9IgDMzhPQRWTNIiJQ4 o5ZJqxqK4Liy2UJ73GiENELl/f85FFhHbEkWaUdlst1pegPqDkb4kelr4W7Ldfyj1T j24IHUHCuJeNP98CGyachhgKxh+R+ZXvEUSJGukA= Date: Fri, 8 Nov 2024 13:21:58 -0800 From: Andre Muezerie To: Konstantin Ananyev Cc: Bruce Richardson , "dev@dpdk.org" , "stable@dpdk.org" Subject: Re: [PATCH v5 08/20] net/ice: remove use of VLAs for Windows built code Message-ID: <20241108212158.GB30715@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> References: <1713397319-26135-1-git-send-email-roretzla@linux.microsoft.com> <1731026691-1529-1-git-send-email-andremue@linux.microsoft.com> <1731026691-1529-9-git-send-email-andremue@linux.microsoft.com> <6e36b497009b4a2dbc598435bdd44ef6@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6e36b497009b4a2dbc598435bdd44ef6@huawei.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On Fri, Nov 08, 2024 at 10:18:31AM +0000, Konstantin Ananyev wrote: > > > > > > Title for this patch is incorrect. Does it belong merged with the next > > patch in series? > > Yes, seems like oringianl title get lost, I think it needs to be: > gro: fix overwrite unprocessed packets > https://patchwork.dpdk.org/project/dpdk/patch/20240523162604.2600-2-konstantin.v.ananyev@yandex.ru/ > Yes, I made a mistake. I'll fix it in v6 alonmg with other small changes. > > > > On Thu, Nov 07, 2024 at 04:44:39PM -0800, Andre Muezerie wrote: > > > From: Konstantin Ananyev > > > > > > gro_vxlan_tcp4_tbl_timeout_flush() is called without taking into account > > > that first entries in pkts[] can be already occupied by > > > un-processed packets. > > > > > > Fixes: 74080d7dcf31 ("gro: support IPv6 for TCP") > > > Cc: stable@dpdk.org > > > > > > Signed-off-by: Konstantin Ananyev > > > Acked-by: Ferruh Yigit > > > --- > > > lib/gro/rte_gro.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/lib/gro/rte_gro.c b/lib/gro/rte_gro.c > > > index d824eebd93..db86117609 100644 > > > --- a/lib/gro/rte_gro.c > > > +++ b/lib/gro/rte_gro.c > > > @@ -327,7 +327,7 @@ rte_gro_reassemble_burst(struct rte_mbuf **pkts, > > > /* Flush all packets from the tables */ > > > if (do_vxlan_tcp_gro) { > > > i += gro_vxlan_tcp4_tbl_timeout_flush(&vxlan_tcp_tbl, > > > - 0, pkts, nb_pkts); > > > + 0, &pkts[i], nb_pkts - i); > > > } > > > > > > if (do_vxlan_udp_gro) { > > > -- > > > 2.34.1 > > >