From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C8C7245CC2 for ; Tue, 12 Nov 2024 23:08:47 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C0A384069F; Tue, 12 Nov 2024 23:08:47 +0100 (CET) Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) by mails.dpdk.org (Postfix) with ESMTP id 6D2C94064C for ; Tue, 12 Nov 2024 23:08:47 +0100 (CET) Received: by mail-wr1-f48.google.com with SMTP id ffacd0b85a97d-37d50fad249so4625362f8f.1 for ; Tue, 12 Nov 2024 14:08:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1731449327; x=1732054127; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=lVbronUusMPGBzCP62D72KTMHpeI23cb2Os7BrfSmGk=; b=CNK8U7oJBI+82tDWmPRHg199MmpGOkZbqKh4fFABpODa1pFZVc2KXPEC0s4rRGbJN7 WUZe5YMvk3ll3ZAypDmBqhgbkruTb3elW/W42hXv/c6ukMWeiSWC7NSxxWNBO6GW0FG2 hFw6e2TUuuexW+kyTrnLqa7V7cgACHd5KMhDRGuSYVSOOAFcyZbGOljDi5LxniUqqvGX UfT0AD7Zrb6J+H+h3VrCl+6YTD7+UzqTu77epUxlnfKiK03lQAIgTkKu/vzMuck6wEzl SxhijzFY2nbodmbNduOdRJizgm6Tdb4cGlT9Bsxnpb9kHfE4XqsZvYK4sYpUzPMuKJsF jJUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731449327; x=1732054127; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=lVbronUusMPGBzCP62D72KTMHpeI23cb2Os7BrfSmGk=; b=Y+f0TW+zo97/JFvKRNS28woYXLRehSFzyTQgNSI5rmgCeKvTnOqO/Nw+DKAU8q7GwM +ZIEc6iHN5JKr8GMz9Z5TAbMRxOzRGgggCYnWB5lttf1tMrgvKi+mtR2oY55WImam61y MdFWyvQFx7w1BNnkg0x+Nttx980gl9xziqEVqfHeiSAFHVuuan/x+l677vLiyoq4X30e WFc6bcFDm641roxsFneZRES8uPxjsN11SRcys9kCwlXIh9/tlTbO+cuszngdrse42/Nm 8PJ7UNTLNmSvXiZqGT4T6rpeDAU3WUzKbfexg6wZNM7yWPoF/VrSJkfjb8ZB6vYwPYE7 E7Hw== X-Forwarded-Encrypted: i=1; AJvYcCX5oSeK5wZ9LvTGf72QTiFdGQheV4JrHTC1k7o0mH32c2b5kUPhggZ65XH3GBHXRMzYeFRZ7rs=@dpdk.org X-Gm-Message-State: AOJu0YyoIgdAcfqXTCAdb8gCPvMHpS/tbT9tG+EP2CBQWtn2ohO4WnTm lI7z4InRpyIzaQXRcoQRIsESLCpknUCoAg/Kqw+CKq3BBlPI8gekb30OpQ== X-Google-Smtp-Source: AGHT+IEUgDkSsV6ZgUDq4NmjJktXBckRTVxZLZKcsxGeBAKNfjmIUFlTdOZn81Df6cvw5a8ZirtbEQ== X-Received: by 2002:a05:6000:401f:b0:37d:3e00:9a9b with SMTP id ffacd0b85a97d-381f186cafbmr15588446f8f.20.1731449326978; Tue, 12 Nov 2024 14:08:46 -0800 (PST) Received: from localhost ([2a01:4b00:d036:ae00:e89d:e9a1:da72:2f9d]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-381ed9ea4ebsm16464244f8f.69.2024.11.12.14.08.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Nov 2024 14:08:46 -0800 (PST) From: luca.boccassi@gmail.com To: Bruce Richardson Cc: Stephen Hemminger , dpdk stable Subject: patch 'app/dumpcap: remove unused struct array' has been queued to stable release 22.11.7 Date: Tue, 12 Nov 2024 22:07:25 +0000 Message-ID: <20241112220754.666489-15-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20241112220754.666489-1-luca.boccassi@gmail.com> References: <20241023211704.1216956-79-luca.boccassi@gmail.com> <20241112220754.666489-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.7 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/14/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/381787b7df76e0f15992219ed2519fc67e58f95a Thanks. Luca Boccassi --- >From 381787b7df76e0f15992219ed2519fc67e58f95a Mon Sep 17 00:00:00 2001 From: Bruce Richardson Date: Tue, 5 Nov 2024 11:27:21 +0000 Subject: [PATCH] app/dumpcap: remove unused struct array [ upstream commit 9bbd44d63846cf0771ec0f1c7e1b5a63ec5e9603 ] The callbacks(rx_cb) member of struct interface was unused inside dumpcap, but was taking up a lot of memory space, since it was scaled according to RTE_MAX_QUEUES_PER_PORT, which is 1k by default. Save memory by removing the whole array. Fixes: cbb44143be74 ("app/dumpcap: add new packet capture application") Suggested-by: Stephen Hemminger Signed-off-by: Bruce Richardson Acked-by: Stephen Hemminger --- app/dumpcap/main.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/app/dumpcap/main.c b/app/dumpcap/main.c index 7e8aa5d76e..0b6432ad4d 100644 --- a/app/dumpcap/main.c +++ b/app/dumpcap/main.c @@ -83,8 +83,6 @@ struct interface { TAILQ_ENTRY(interface) next; uint16_t port; char name[RTE_ETH_NAME_MAX_LEN]; - - struct rte_rxtx_callback *rx_cb[RTE_MAX_QUEUES_PER_PORT]; }; TAILQ_HEAD(interface_list, interface); -- 2.45.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-11-12 22:06:59.181291544 +0000 +++ 0015-app-dumpcap-remove-unused-struct-array.patch 2024-11-12 22:06:58.659307077 +0000 @@ -1 +1 @@ -From 9bbd44d63846cf0771ec0f1c7e1b5a63ec5e9603 Mon Sep 17 00:00:00 2001 +From 381787b7df76e0f15992219ed2519fc67e58f95a Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 9bbd44d63846cf0771ec0f1c7e1b5a63ec5e9603 ] + @@ -12 +13,0 @@ -Cc: stable@dpdk.org @@ -18,2 +19,2 @@ - app/dumpcap/main.c | 1 - - 1 file changed, 1 deletion(-) + app/dumpcap/main.c | 2 -- + 1 file changed, 2 deletions(-) @@ -22 +23 @@ -index 4031f48441..3d3c0dbc66 100644 +index 7e8aa5d76e..0b6432ad4d 100644 @@ -25,2 +26,3 @@ -@@ -96,7 +96,6 @@ struct interface { - struct rte_bpf_prm *bpf_prm; +@@ -83,8 +83,6 @@ struct interface { + TAILQ_ENTRY(interface) next; + uint16_t port; @@ -28 +30 @@ - +- @@ -30,2 +31,0 @@ - const char *ifname; - const char *ifdescr; @@ -32,0 +33,2 @@ + + TAILQ_HEAD(interface_list, interface);