From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AF6B845C9B for ; Tue, 12 Nov 2024 23:09:09 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AA4714064C; Tue, 12 Nov 2024 23:09:09 +0100 (CET) Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) by mails.dpdk.org (Postfix) with ESMTP id 2DDE240A6F for ; Tue, 12 Nov 2024 23:09:07 +0100 (CET) Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-43169902057so50644405e9.0 for ; Tue, 12 Nov 2024 14:09:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1731449347; x=1732054147; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=W6S+FEvIpY/Ltmn19npPrY+YdBr0cvLfNPB2GmXFYf0=; b=aK2PakDlA8IEsTaILxO1DVadQAkNjc1M59+o6FwjAc0DT8+DB+P92W/+LA5m4PvT8A BYNtdcj0CMSaRgVUu11k/uF9b7rikwQ4T6YgtaWOJkJS5FimVKtE41LykcvWc2XudJ5e 1+xq/6gBnJnrdQ9rozOfwKfE/eun6uwdBPzrHimMEnugnyoiKvTgT5+NA8wIKdfnhmMP jkUMbZF++2SU1fMSNC+XPYB8OgcgJK6mtm5OegbPGCZV+AhK/OWnsI52Gyc6MPisWeyk CaiuDgIodLmrnxlD6Q0Tlosz+LQxRUnU0OIa8Rl/x8GKRi9SsQxB11y95y0/4NcgWLFz dI/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731449347; x=1732054147; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=W6S+FEvIpY/Ltmn19npPrY+YdBr0cvLfNPB2GmXFYf0=; b=a+8Xak40BIoLwGQUvuy/mvdA+hgb2sG5TxM6QHERQ1/WHxZgc/um6Yr1Ch/6Dp3UIs xCxUKxJarhY6oaTvKRXm/CUdvIFqxyIYBrR+LJzlKt1zLlvFUyGwHQPKIX8TK/PSmOHv RWrRTV2PsldJkYWRoHYqt+2vvtKCNoutNbzJaXvtXgbkbyEuj7I9PSpprF6oyK/Tyum9 D0xPrQSwSm16w1NdEMK1OTkP2jIUOYK2vZv4Iuw15Eey3/I68KRY3Sp8NWCPP8S96y6P ZNM6Wry1cHK0t/b0sf2kFgFa8hGL7pwtDCT7VHKMk5y9dmNGwYucPOp5CHr1e4sJj31T qosA== X-Forwarded-Encrypted: i=1; AJvYcCWJgM9NLPTAJIRdzrcfaH1vH/7CN9AksmF9FXKM1NHijt0sGQSmm2caSFKW7P4z7qtdns0vpyM=@dpdk.org X-Gm-Message-State: AOJu0YyakiTHbgHv2lp2LKltcZ1Sh7fDt9UnkDyPiBrquAqEfoNQaIsV g50xlMQd0lwsZC+yrE77/0pwXL/lw4XNlHJ3rjGo5dccbDMh9f6HjVmaYQ== X-Google-Smtp-Source: AGHT+IHQ8OvYVpwzZ/soxS9wp/5M4MynncOdFoFKpBxi8kGg+FS1UWnickyEV1fQPkzDe41zAL9Acg== X-Received: by 2002:a05:600c:1f13:b0:431:55c1:f440 with SMTP id 5b1f17b1804b1-432cd47dac2mr37944155e9.30.1731449346459; Tue, 12 Nov 2024 14:09:06 -0800 (PST) Received: from localhost ([2a01:4b00:d036:ae00:e89d:e9a1:da72:2f9d]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-432d552c59fsm903635e9.37.2024.11.12.14.09.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Nov 2024 14:09:05 -0800 (PST) From: luca.boccassi@gmail.com To: Stephen Hemminger Cc: =?UTF-8?q?Morten=20Br=C3=B8rup?= , dpdk stable Subject: patch 'examples/ntb: check info query return' has been queued to stable release 22.11.7 Date: Tue, 12 Nov 2024 22:07:30 +0000 Message-ID: <20241112220754.666489-20-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20241112220754.666489-1-luca.boccassi@gmail.com> References: <20241023211704.1216956-79-luca.boccassi@gmail.com> <20241112220754.666489-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.7 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/14/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/63797f45c51e87faaede63d647d41314b4bfe85a Thanks. Luca Boccassi --- >From 63797f45c51e87faaede63d647d41314b4bfe85a Mon Sep 17 00:00:00 2001 From: Stephen Hemminger Date: Fri, 4 Oct 2024 09:21:53 -0700 Subject: [PATCH] examples/ntb: check info query return MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit [ upstream commit 07e4dc04d99a99699d71a0a39dd2a7034049e663 ] The ethdev_info is only valid if rte_eth_dev_info_get returns success. Fixes: 5194299d6ef5 ("examples/ntb: support more functions") Signed-off-by: Stephen Hemminger Acked-by: Morten Brørup --- examples/ntb/ntb_fwd.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/examples/ntb/ntb_fwd.c b/examples/ntb/ntb_fwd.c index 585aad9d70..5082e66c7b 100644 --- a/examples/ntb/ntb_fwd.c +++ b/examples/ntb/ntb_fwd.c @@ -1443,7 +1443,10 @@ main(int argc, char **argv) eth_port_id = rte_eth_find_next(0); if (eth_port_id < RTE_MAX_ETHPORTS) { - rte_eth_dev_info_get(eth_port_id, ðdev_info); + ret = rte_eth_dev_info_get(eth_port_id, ðdev_info); + if (ret) + rte_exit(EXIT_FAILURE, "Can't get info for port %u\n", eth_port_id); + eth_pconf.rx_adv_conf.rss_conf.rss_hf &= ethdev_info.flow_type_rss_offloads; ret = rte_eth_dev_configure(eth_port_id, num_queues, -- 2.45.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-11-12 22:06:59.324000969 +0000 +++ 0020-examples-ntb-check-info-query-return.patch 2024-11-12 22:06:58.663307139 +0000 @@ -1 +1 @@ -From 07e4dc04d99a99699d71a0a39dd2a7034049e663 Mon Sep 17 00:00:00 2001 +From 63797f45c51e87faaede63d647d41314b4bfe85a Mon Sep 17 00:00:00 2001 @@ -8,0 +9,2 @@ +[ upstream commit 07e4dc04d99a99699d71a0a39dd2a7034049e663 ] + @@ -12 +13,0 @@ -Cc: stable@dpdk.org @@ -21 +22 @@ -index 56c7672392..37d60208e3 100644 +index 585aad9d70..5082e66c7b 100644 @@ -24 +25 @@ -@@ -1285,7 +1285,10 @@ main(int argc, char **argv) +@@ -1443,7 +1443,10 @@ main(int argc, char **argv)