From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A3DE845C9B for ; Tue, 12 Nov 2024 23:09:39 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9E7904064C; Tue, 12 Nov 2024 23:09:39 +0100 (CET) Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45]) by mails.dpdk.org (Postfix) with ESMTP id 3F9644064C for ; Tue, 12 Nov 2024 23:09:38 +0100 (CET) Received: by mail-wr1-f45.google.com with SMTP id ffacd0b85a97d-37d47eff9acso3783809f8f.3 for ; Tue, 12 Nov 2024 14:09:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1731449378; x=1732054178; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=0lmwF/18yiuxjLXC9+huC772h6JH2zIBYWe7e6QKD1M=; b=cnWNKWVj6nq8iH79mYsS30+IWQFE0h/sjMBBjNVjGXXdguxYgVPvqmmCJhgAyl79kJ RYViCW6MuLBJeOSXZ5nLNe8qTsqPbcZbpfV8OS9VKK88centU/86iyy0hsWNaA8xUFYl /4t/eWy+mWOzGGrniM9YuHU+QdmAd9K6/gh7/mRd/ir5Ocnu6QqLVt2YGrZVePdd+kHl PKevzdi2gMIaY4CNxGV4Y6yc0/5TVW8M7AwqzQtag3s8zBRVL5e9FzCrE/atu6SUxVuQ vzzOrIczW0r6Pc+rGY+WiK1PTxO58s47ktYdT1HgdlfOQ5j96GYqiGZDq6jlxUgqPkvD 1pRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731449378; x=1732054178; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0lmwF/18yiuxjLXC9+huC772h6JH2zIBYWe7e6QKD1M=; b=BR5JKOSyCF2aRdIZCpjWDa0OoJ72P4YueSwTdbFek2eK062KvyN95MoQCzmKw4FymA g8l6kWTyID2hrS20eUzJpC4ylaGVoXhMIw36j+naxYyJuSn35oYcnMZPIS99fOBXjVv6 hkAx0u1CoE490z5BikHGFeUKrbF+XE96knGL6+AbcP0kCSWGOTF6hXAJX9rDZlTw7l2g VGvnA14iCYbu9FMlGAyLRjTsyDJG6+vaAC86yl8yoaoTOyjNwpvyDll2vWaES9oP+kzi iaZiKdMTNB0cSzYCaBYGIWPX9ApapaOp+rPTCuDZ0+kjapTmPer5qXoH0xWTQ42zJ3m9 KTDQ== X-Gm-Message-State: AOJu0Yw+klO7cZ68wK031xAEVs+Njg22WAfqX6c8Yku4hloqpgNRl6Wz 0DJlzrYlzv0navhwtDLt3+XBS3CtRssDd+lcrXkgp6F2g9giJg11x28RTQ== X-Google-Smtp-Source: AGHT+IEHERC1vbseXV2jp645o9VHugKJ5SmfK+L5khKXKndLQPB0nLmNgOdi9MFBasxmk5crDs20nA== X-Received: by 2002:a05:6000:1a8b:b0:37c:c80e:d030 with SMTP id ffacd0b85a97d-381f18850cdmr16729205f8f.53.1731449377795; Tue, 12 Nov 2024 14:09:37 -0800 (PST) Received: from localhost ([2a01:4b00:d036:ae00:e89d:e9a1:da72:2f9d]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-381ed9ea3cbsm16642717f8f.74.2024.11.12.14.09.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Nov 2024 14:09:36 -0800 (PST) From: luca.boccassi@gmail.com To: Jiawen Wu Cc: dpdk stable Subject: patch 'net/txgbe: remove outer UDP checksum capability' has been queued to stable release 22.11.7 Date: Tue, 12 Nov 2024 22:07:36 +0000 Message-ID: <20241112220754.666489-26-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20241112220754.666489-1-luca.boccassi@gmail.com> References: <20241023211704.1216956-79-luca.boccassi@gmail.com> <20241112220754.666489-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.7 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/14/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/535cdf7a7d9bb8be726bb2cdffc47365f8dc7346 Thanks. Luca Boccassi --- >From 535cdf7a7d9bb8be726bb2cdffc47365f8dc7346 Mon Sep 17 00:00:00 2001 From: Jiawen Wu Date: Mon, 4 Nov 2024 10:29:57 +0800 Subject: [PATCH] net/txgbe: remove outer UDP checksum capability [ upstream commit 25fe1c780d39ea3637ba8407f6e9a9800135becd ] The hardware does not support outer UDP checksum for tunnel packets. It's wrong to claim this Tx offload capability, so fix it. Bugzilla ID: 1529 Fixes: b950203be7f1 ("net/txgbe: support VXLAN-GPE") Signed-off-by: Jiawen Wu --- drivers/net/txgbe/txgbe_rxtx.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/txgbe/txgbe_rxtx.c b/drivers/net/txgbe/txgbe_rxtx.c index b0ec1c96d7..9a075cf54b 100644 --- a/drivers/net/txgbe/txgbe_rxtx.c +++ b/drivers/net/txgbe/txgbe_rxtx.c @@ -2254,8 +2254,7 @@ txgbe_get_tx_port_offloads(struct rte_eth_dev *dev) tx_offload_capa |= RTE_ETH_TX_OFFLOAD_MACSEC_INSERT; - tx_offload_capa |= RTE_ETH_TX_OFFLOAD_OUTER_IPV4_CKSUM | - RTE_ETH_TX_OFFLOAD_OUTER_UDP_CKSUM; + tx_offload_capa |= RTE_ETH_TX_OFFLOAD_OUTER_IPV4_CKSUM; #ifdef RTE_LIB_SECURITY if (dev->security_ctx) -- 2.45.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-11-12 22:06:59.510251911 +0000 +++ 0026-net-txgbe-remove-outer-UDP-checksum-capability.patch 2024-11-12 22:06:58.675307328 +0000 @@ -1 +1 @@ -From 25fe1c780d39ea3637ba8407f6e9a9800135becd Mon Sep 17 00:00:00 2001 +From 535cdf7a7d9bb8be726bb2cdffc47365f8dc7346 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 25fe1c780d39ea3637ba8407f6e9a9800135becd ] + @@ -11 +12,0 @@ -Cc: stable@dpdk.org @@ -19 +20 @@ -index 5bc0f8772f..c12726553c 100644 +index b0ec1c96d7..9a075cf54b 100644 @@ -22 +23 @@ -@@ -2284,8 +2284,7 @@ txgbe_get_tx_port_offloads(struct rte_eth_dev *dev) +@@ -2254,8 +2254,7 @@ txgbe_get_tx_port_offloads(struct rte_eth_dev *dev)