From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C5C4C45C9B for ; Tue, 12 Nov 2024 23:09:41 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C09B24064C; Tue, 12 Nov 2024 23:09:41 +0100 (CET) Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) by mails.dpdk.org (Postfix) with ESMTP id CF4D740A7D for ; Tue, 12 Nov 2024 23:09:40 +0100 (CET) Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-4314f38d274so78048765e9.1 for ; Tue, 12 Nov 2024 14:09:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1731449380; x=1732054180; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Kh9OF+u+isJ5x34bJY2rSDykzxwOC7opjYAtEqwipFs=; b=VmanywwnJNvEH2Mu0iMNFhqlV4sW3GpblL3fj7uVwJUpC23xt64SnVsWBiJpwR84b8 DN51KXZrm6G1BjSzaqJIBUvGCGJRUwcUTAsvbFCTagunwN0dlbieSVJ0h5eHIJu/oT4/ rxOAjF+kbcrpG8vxDU+SZ68WdJWqzCA2UFIQdQB8rrl3V95zuE/G4+nuTutMFX5P1G/R rpXa13ledJ2zd7E43FMdiHN/gSYWz2BW45p2SmovzKwo7PM4f+bmaWUgvqKxKLmM2Hpb vq+8BvNxaUW30yr+soaGGgEKv7k4fOoF770L5rToaL5W52qejLxVNZzBzrMgOvFfGNKo JwxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731449380; x=1732054180; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Kh9OF+u+isJ5x34bJY2rSDykzxwOC7opjYAtEqwipFs=; b=pJSKncpbc88a9Dxbc7DjmdspwSy25TawUjhmvL6SuKeR8p9f3DbXowwCv6zLCer1Ry MCR7t4f5TU+KqLGrl+XM/V1IJTCdT4ReTE+MOQKdpBm2En2bZiAp6IBd3yp91Srbcw7w z5DeJ07s+Er07rQsvu4Ak6jFTgkmmTXxQVDvFAorQeeu9vV8XvGz3ELaR0KSRAgTXI4+ uW8Ww6KGACv4F24BOPyhi++b6aXmDcTf/4gqQgdsTbxasfhHfZFLw6DkIQPDb071YtHR f3kWiOAL8VZfboFIGXn/XW8ewNr+LKGWJchtjNbaVvimBPr+lQr+fP0mk2zq19wfKNgT d2bw== X-Gm-Message-State: AOJu0YzFlOOhjJpYxG91pc+CY4+m5Nxtebx8ou3RpYZeZjyWhTYCCW/y mBV3AuJoI07lWhWk7+XfeOiVAUVkq3CKcwWsTGia1mMUSCk0lrhG5khhJg== X-Google-Smtp-Source: AGHT+IHaU6SQQez2Wlx26jh/nfrvpBgDk/Zf96XlYyzJIpFyX02FFJgYc1ljLipFPKXxuVrGky/uXg== X-Received: by 2002:a05:600c:1396:b0:431:5c3d:1700 with SMTP id 5b1f17b1804b1-432b7518e11mr182559455e9.21.1731449380343; Tue, 12 Nov 2024 14:09:40 -0800 (PST) Received: from localhost ([2a01:4b00:d036:ae00:e89d:e9a1:da72:2f9d]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-432d550f23bsm933475e9.35.2024.11.12.14.09.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Nov 2024 14:09:39 -0800 (PST) From: luca.boccassi@gmail.com To: Jiawen Wu Cc: dpdk stable Subject: patch 'net/txgbe: fix driver load bit to inform firmware' has been queued to stable release 22.11.7 Date: Tue, 12 Nov 2024 22:07:37 +0000 Message-ID: <20241112220754.666489-27-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20241112220754.666489-1-luca.boccassi@gmail.com> References: <20241023211704.1216956-79-luca.boccassi@gmail.com> <20241112220754.666489-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.7 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/14/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/3b4fec359ebcfeaca59d4609d9cceca1e7982e3c Thanks. Luca Boccassi --- >From 3b4fec359ebcfeaca59d4609d9cceca1e7982e3c Mon Sep 17 00:00:00 2001 From: Jiawen Wu Date: Mon, 4 Nov 2024 10:29:58 +0800 Subject: [PATCH] net/txgbe: fix driver load bit to inform firmware [ upstream commit 0a8f064bbc2cf4978857eae84e86c6b2c9e65feb ] Drv_load bit will be reset to default 0 after hardware LAN reset, reconfigure it to inform firmware that driver is loaded. And set it to 0 when device is closed. Fixes: b1f596677d8e ("net/txgbe: support device start") Signed-off-by: Jiawen Wu --- drivers/net/txgbe/txgbe_ethdev.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/net/txgbe/txgbe_ethdev.c b/drivers/net/txgbe/txgbe_ethdev.c index 2ed5ee683f..784b66a579 100644 --- a/drivers/net/txgbe/txgbe_ethdev.c +++ b/drivers/net/txgbe/txgbe_ethdev.c @@ -330,6 +330,8 @@ txgbe_pf_reset_hw(struct txgbe_hw *hw) status = hw->mac.reset_hw(hw); ctrl_ext = rd32(hw, TXGBE_PORTCTL); + /* let hardware know driver is loaded */ + ctrl_ext |= TXGBE_PORTCTL_DRVLOAD; /* Set PF Reset Done bit so PF/VF Mail Ops can work */ ctrl_ext |= TXGBE_PORTCTL_RSTDONE; wr32(hw, TXGBE_PORTCTL, ctrl_ext); @@ -2046,6 +2048,9 @@ txgbe_dev_close(struct rte_eth_dev *dev) ret = txgbe_dev_stop(dev); + /* Let firmware take over control of hardware */ + wr32m(hw, TXGBE_PORTCTL, TXGBE_PORTCTL_DRVLOAD, 0); + txgbe_dev_free_queues(dev); txgbe_set_pcie_master(hw, false); -- 2.45.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-11-12 22:06:59.541731463 +0000 +++ 0027-net-txgbe-fix-driver-load-bit-to-inform-firmware.patch 2024-11-12 22:06:58.675307328 +0000 @@ -1 +1 @@ -From 0a8f064bbc2cf4978857eae84e86c6b2c9e65feb Mon Sep 17 00:00:00 2001 +From 3b4fec359ebcfeaca59d4609d9cceca1e7982e3c Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 0a8f064bbc2cf4978857eae84e86c6b2c9e65feb ] + @@ -11 +12,0 @@ -Cc: stable@dpdk.org @@ -19 +20 @@ -index 2834468764..4aa3bfd0bc 100644 +index 2ed5ee683f..784b66a579 100644 @@ -22 +23 @@ -@@ -331,6 +331,8 @@ txgbe_pf_reset_hw(struct txgbe_hw *hw) +@@ -330,6 +330,8 @@ txgbe_pf_reset_hw(struct txgbe_hw *hw) @@ -31 +32 @@ -@@ -2061,6 +2063,9 @@ txgbe_dev_close(struct rte_eth_dev *dev) +@@ -2046,6 +2048,9 @@ txgbe_dev_close(struct rte_eth_dev *dev)