From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EF94345C9B for ; Tue, 12 Nov 2024 23:09:43 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E9BDF4064C; Tue, 12 Nov 2024 23:09:43 +0100 (CET) Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) by mails.dpdk.org (Postfix) with ESMTP id EBB8840A84 for ; Tue, 12 Nov 2024 23:09:41 +0100 (CET) Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-4319399a411so59042735e9.2 for ; Tue, 12 Nov 2024 14:09:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1731449381; x=1732054181; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=DfaYZPOr0shV+zvVjuhO88oaH4BS4vA7VpgiOYvcbrM=; b=QRIukhP+bjSOvwzFw+AL60pRZEoBlrDLHdeew/ISc0Aa+d0tR2/dedUnGAbSfn9iI2 KPOD/kr/OyJ7hp0OdeFMVCxmyGD9jKJK1QX+UC5Ae72u49Njo9baiKiWPFpeSYCd1xtI 1XWXWEFvgs6j3szBQcfu2Ny4I9j+p0Cts0WRf7PxJG8YTzYWclw6rXIzlYI+62Nl0k8b OnmZwDmrb+KgMLcn1ZFQXBzK1Nu/2WJTQmkUjUwA6zVee9rbTvknnXos6KkNwkzIxTi7 XOi5QsuQo0zTNXpcpLvU8zBr8pfv5giER0zDBPtpRoHOc634CtxcvF4K+mPC/aHpcSQ8 TWzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731449381; x=1732054181; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=DfaYZPOr0shV+zvVjuhO88oaH4BS4vA7VpgiOYvcbrM=; b=ZELn9t3hIEmIUK+m5hZbX+/7UDKgcC0d598p5w6459+dz5Imd5yWXXon+IFqkZcSfz tX71FrbODtV48QtngoQW8Jjr7WhV1OVtmjsY6phHlm5yfqW3SYzbquv0rtRjOAJBW8Dj i5BnAbngn3tIy6zTbFabV+uRrSsrFAaSK/OqqQ/YLCj3DXff1Mqlkv3V3f6ITwEZp9SC dsUt1Sl+SHT/fBH9TNXgjgOWRAULpF+eMv8pRqLF/BKwcm960VyipNMPr2EwPBf8YrWB +mYmh702eFo/qDvWoYq1F4eXBA8lSxC0BlY9pY5bVnPqxhPyaOCEntIhFg0+kGkrOJj8 6fuQ== X-Gm-Message-State: AOJu0YxNz3rDwegfLMfFwj31DdeOARlvmj+nO8LyrhCGm0RBtaYXu1Kr J3rzLOoM4CB/ffNlDNNkNu0QnNEMxRVcMtl6jr+P+2RBf3moFiMKaGyg9Q== X-Google-Smtp-Source: AGHT+IFGx4EqTdn5QLK6Bk7QpoV/FWHNNkiqDfSp7guSw+N0KXqRvmKKK44uuME4WWe1Dtxldegvvw== X-Received: by 2002:a05:600c:1c14:b0:426:627e:37af with SMTP id 5b1f17b1804b1-432b74fc93fmr164789275e9.3.1731449381520; Tue, 12 Nov 2024 14:09:41 -0800 (PST) Received: from localhost ([2a01:4b00:d036:ae00:e89d:e9a1:da72:2f9d]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-432d550c159sm940265e9.32.2024.11.12.14.09.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Nov 2024 14:09:41 -0800 (PST) From: luca.boccassi@gmail.com To: Jiawen Wu Cc: dpdk stable Subject: patch 'net/ngbe: fix driver load bit to inform firmware' has been queued to stable release 22.11.7 Date: Tue, 12 Nov 2024 22:07:38 +0000 Message-ID: <20241112220754.666489-28-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20241112220754.666489-1-luca.boccassi@gmail.com> References: <20241023211704.1216956-79-luca.boccassi@gmail.com> <20241112220754.666489-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.7 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/14/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/ed8bc9d268e07f0da95ab4465567dae4f0e178d5 Thanks. Luca Boccassi --- >From ed8bc9d268e07f0da95ab4465567dae4f0e178d5 Mon Sep 17 00:00:00 2001 From: Jiawen Wu Date: Mon, 4 Nov 2024 10:30:04 +0800 Subject: [PATCH] net/ngbe: fix driver load bit to inform firmware [ upstream commit cb7be5b510ef0995fa171832f0e0994f667e2161 ] Drv_load bit will be reset to default 0 after hardware LAN reset, reconfigure it to inform firmware that driver is loaded. And set it to 0 when device is closed. Fixes: 3518df5774c7 ("net/ngbe: support device start/stop") Fixes: cc63194e89cb ("net/ngbe: support close and reset device") Signed-off-by: Jiawen Wu --- drivers/net/ngbe/ngbe_ethdev.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/net/ngbe/ngbe_ethdev.c b/drivers/net/ngbe/ngbe_ethdev.c index 443bd9fef9..51a7c78e3d 100644 --- a/drivers/net/ngbe/ngbe_ethdev.c +++ b/drivers/net/ngbe/ngbe_ethdev.c @@ -263,6 +263,8 @@ ngbe_pf_reset_hw(struct ngbe_hw *hw) status = hw->mac.reset_hw(hw); ctrl_ext = rd32(hw, NGBE_PORTCTL); + /* let hardware know driver is loaded */ + ctrl_ext |= NGBE_PORTCTL_DRVLOAD; /* Set PF Reset Done bit so PF/VF Mail Ops can work */ ctrl_ext |= NGBE_PORTCTL_RSTDONE; wr32(hw, NGBE_PORTCTL, ctrl_ext); @@ -1269,6 +1271,9 @@ ngbe_dev_close(struct rte_eth_dev *dev) ngbe_dev_stop(dev); + /* Let firmware take over control of hardware */ + wr32m(hw, NGBE_PORTCTL, NGBE_PORTCTL_DRVLOAD, 0); + ngbe_dev_free_queues(dev); ngbe_set_pcie_master(hw, false); -- 2.45.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-11-12 22:06:59.572402455 +0000 +++ 0028-net-ngbe-fix-driver-load-bit-to-inform-firmware.patch 2024-11-12 22:06:58.679307391 +0000 @@ -1 +1 @@ -From cb7be5b510ef0995fa171832f0e0994f667e2161 Mon Sep 17 00:00:00 2001 +From ed8bc9d268e07f0da95ab4465567dae4f0e178d5 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit cb7be5b510ef0995fa171832f0e0994f667e2161 ] + @@ -12 +13,0 @@ -Cc: stable@dpdk.org @@ -20 +21 @@ -index 353d17acc8..238533f2b8 100644 +index 443bd9fef9..51a7c78e3d 100644 @@ -32 +33 @@ -@@ -1277,6 +1279,9 @@ ngbe_dev_close(struct rte_eth_dev *dev) +@@ -1269,6 +1271,9 @@ ngbe_dev_close(struct rte_eth_dev *dev)