From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3CA5845C9B for ; Tue, 12 Nov 2024 23:08:11 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 375604067E; Tue, 12 Nov 2024 23:08:11 +0100 (CET) Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) by mails.dpdk.org (Postfix) with ESMTP id 7E9254021E for ; Tue, 12 Nov 2024 23:08:09 +0100 (CET) Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-43161c0068bso53238245e9.1 for ; Tue, 12 Nov 2024 14:08:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1731449289; x=1732054089; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=5eoUE/qTfKMyIfuvOL5BKVYTFZrA1NCfa+DvYz2x9/U=; b=GlEYEC9lrIS5LHeleMT+9ottdu5UDcYLWHMoAacBFX6ha8xwoms68jRp4f8YTMUTmp Dpc6Opo6mu5Aigxo+XykO05wPWzRT/2zmHYskLWfItm25Z2Gxre2eyam8YpwdsRTO8b4 aXAlsbZqYk/xSq0L+deM8fmQrZQcQZP+z1puX2SLdIbDPknGwVeYrJuCmDEji+0amNH4 a4RwBC0jAg/BfrUnufvVMe25YC5W3ZbuyLs0+6LPekv524GImLegfLp735Ngo/gqGn70 wOLvU+4tV3UcZchL3mIreIhdcD3Avm8JwrNhJyfIbnxYiqVwu4PVm9/rcwxXPK30fKM3 28Ew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731449289; x=1732054089; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5eoUE/qTfKMyIfuvOL5BKVYTFZrA1NCfa+DvYz2x9/U=; b=MN0TuZN77mY6n5TVatZ2PBEw8XgZfLm1VOlL4L7aU+03StS28KB6XbQ4GcSxE+Gdli GkOpbH6sN/gunZcw+ukJUV7P7HkOpz2utttwYimkcSralwnkZVfahOtNzSBZaiPleFqn EUgD9TGTIb15QfImqCjBBg2sbecnnvrHejH0VvxdgyF6r+lfm/iNRVVwDntpDOfWNli+ Hcz5g23fQ+ys/jcHRvLYDcCtOuJZZO1V47b6PI3/MLkQXVIneqFsfg7nUX9gyzHblyM9 MTQ7KMsRHySJPaCrAYslansfjaq//RL++1xZStCUiTvho2AeUkblUgs6Q9G5IP0pPiqn Zb9w== X-Forwarded-Encrypted: i=1; AJvYcCXC6Qk5iR6fQhZ3p6Lw4yGH8LOgUFCInDfFiPjZue3JLBNvzrJJD29/R5AwP+fMqyAxXum+USs=@dpdk.org X-Gm-Message-State: AOJu0YyYh/NRq35XHsN9f0Dg22Jm83Aoj7IWVjsgI+5yJ71/6X24Js/4 LoJCs7TRTjPokC27bSE+Vt+7SMK8rdgMrazaDwxbayjIR0iPhn5HExCiNw== X-Google-Smtp-Source: AGHT+IF45kSIePpROZslvSmP5TX3MlAcEZEb9lfaIF8HlD6BBUQNn7T7iPyg9F/QmrPsn6FmVTzGlg== X-Received: by 2002:a05:600c:4e8b:b0:42c:c401:6d8b with SMTP id 5b1f17b1804b1-432b74feb99mr153134935e9.7.1731449288869; Tue, 12 Nov 2024 14:08:08 -0800 (PST) Received: from localhost ([2a01:4b00:d036:ae00:e89d:e9a1:da72:2f9d]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-432d48baa42sm5520365e9.1.2024.11.12.14.08.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Nov 2024 14:08:08 -0800 (PST) From: luca.boccassi@gmail.com To: Lewis Donzis Cc: Stephen Hemminger , dpdk stable Subject: patch 'net/ixgbe: fix link status delay on FreeBSD' has been queued to stable release 22.11.7 Date: Tue, 12 Nov 2024 22:07:15 +0000 Message-ID: <20241112220754.666489-5-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20241112220754.666489-1-luca.boccassi@gmail.com> References: <20241023211704.1216956-79-luca.boccassi@gmail.com> <20241112220754.666489-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.7 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/14/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/a4ee1170efdafa7e38b42b4f9974795bbacb2f8b Thanks. Luca Boccassi --- >From a4ee1170efdafa7e38b42b4f9974795bbacb2f8b Mon Sep 17 00:00:00 2001 From: Lewis Donzis Date: Tue, 22 Oct 2024 09:42:05 -0500 Subject: [PATCH] net/ixgbe: fix link status delay on FreeBSD [ upstream commit f775386d92d68e534600fcff3fc4bcaa30d3e68c ] Forcing wait true prevents checking link status without delay, because the function will wait more than 10 seconds for link status to be true, even if the API caller requested no waiting. Fixes: 0012111a3d87 ("net/ixgbe: fix link status synchronization on BSD") Signed-off-by: Lewis Donzis Acked-by: Stephen Hemminger --- drivers/net/ixgbe/ixgbe_ethdev.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c index 9e1a65a50a..99986aa1d4 100644 --- a/drivers/net/ixgbe/ixgbe_ethdev.c +++ b/drivers/net/ixgbe/ixgbe_ethdev.c @@ -4302,11 +4302,6 @@ ixgbe_dev_link_update_share(struct rte_eth_dev *dev, if (wait_to_complete == 0 || dev->data->dev_conf.intr_conf.lsc != 0) wait = 0; -/* BSD has no interrupt mechanism, so force NIC status synchronization. */ -#ifdef RTE_EXEC_ENV_FREEBSD - wait = 1; -#endif - if (vf) diag = ixgbevf_check_link(hw, &link_speed, &link_up, wait); else -- 2.45.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-11-12 22:06:58.855499459 +0000 +++ 0005-net-ixgbe-fix-link-status-delay-on-FreeBSD.patch 2024-11-12 22:06:58.635306699 +0000 @@ -1 +1 @@ -From f775386d92d68e534600fcff3fc4bcaa30d3e68c Mon Sep 17 00:00:00 2001 +From a4ee1170efdafa7e38b42b4f9974795bbacb2f8b Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit f775386d92d68e534600fcff3fc4bcaa30d3e68c ] + @@ -11 +12,0 @@ -Cc: stable@dpdk.org @@ -20 +21 @@ -index ab37c37469..008760e315 100644 +index 9e1a65a50a..99986aa1d4 100644 @@ -23 +24 @@ -@@ -4314,11 +4314,6 @@ ixgbe_dev_link_update_share(struct rte_eth_dev *dev, +@@ -4302,11 +4302,6 @@ ixgbe_dev_link_update_share(struct rte_eth_dev *dev,