From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5FF2D45C9B for ; Tue, 12 Nov 2024 23:08:23 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 566B64021E; Tue, 12 Nov 2024 23:08:23 +0100 (CET) Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) by mails.dpdk.org (Postfix) with ESMTP id 511114021E for ; Tue, 12 Nov 2024 23:08:21 +0100 (CET) Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-43193678216so59224115e9.0 for ; Tue, 12 Nov 2024 14:08:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1731449301; x=1732054101; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=P0tDceyN9eJRKIKIvIhYD72fIwqf+Q5g7AMibolTJaw=; b=htquiSzQJrkBe6JXrKU6TL+1s3arR8uni6WRGjwUqxT8DDwTlAQMB7B8pBiAJR9VCj 346IVAVe4Kt/j/bRgVlgwzvENlOnWSbzgOVhJKP1Gxo/jCTzzCAzLJmR+/6Sa3qHSrD9 7ugvLA/FfJ6Uwl2aIpBEW6SMQtqGyAEsOjGNIEm9yeTzb+p847QmOfqknn14acNRGqCI pKKvGsUbwfrYAo1Z2r9IiQ6pIQUs/eNWKiALnTYe5Kf6D9rvXVvQkaVOkhA0B/YUR4rJ gRaxiuhaEBtZXZ9qtWtEZr/LFrI0DfebwKGG+L6zQUADAwwIkkZe3KQ49AvsxTeJ4WdV mxaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731449301; x=1732054101; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=P0tDceyN9eJRKIKIvIhYD72fIwqf+Q5g7AMibolTJaw=; b=xOJviy3k5m+BWyC/T02Ym+ZpLg6mjHCwqyHxWyovD38H1HpkzfcGR7AXRp6T0kbNzG 9yXsCppeh9krux1SP2HQkAVhcLoW6lF7TfRKXtKAqaYKgrCrUw8IeyqHDQMs7WqZXVPS 0SBLCHIH/G11UZs1heApnDwK9BclGqKICZubUky81xfTrwbxnCl07rycV6EOr8oWn/ik xy4TLLmGEbQlFIOk8HbUSPr7Z93/xEt0mXSy6Hj6ePPWkx3+bR8FHm9iflj6ZzoxU0sX HUlkgRFE0g1K7lTGCIrLRSKyghUayzUmlUpzsMbL7skjJdcwVzajH66zFdIb+b+6Xc3T JM5g== X-Forwarded-Encrypted: i=1; AJvYcCVlGXk7rlHXhNyRdzPbv+CD9vmM9enhAZ555GYYP5nrnQa5r6GExjDGrB8xXCejfUDy81A9vns=@dpdk.org X-Gm-Message-State: AOJu0YzB9S69BMjF8mNSwN5YCYWQHNh3qkVWg0M1jE7Mb0pkdpa4oVwU 5sBH9mfj8p2HhTs4qPOoG2cqP7vUdEoa86h8KC34S+15E9G3nY34 X-Google-Smtp-Source: AGHT+IGh9P920549zIKpTgLclF5Wuk/czMOD9DJcxoMUIMHtxvvZLF7txL2JFG3XqF9jlWn8J8GQTw== X-Received: by 2002:a05:6000:1f8e:b0:37d:4a16:81d6 with SMTP id ffacd0b85a97d-381f186e1dbmr16126247f8f.24.1731449300761; Tue, 12 Nov 2024 14:08:20 -0800 (PST) Received: from localhost ([2a01:4b00:d036:ae00:e89d:e9a1:da72:2f9d]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-432d550bff0sm929405e9.30.2024.11.12.14.08.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Nov 2024 14:08:20 -0800 (PST) From: luca.boccassi@gmail.com To: Chengwen Feng Cc: Ferruh Yigit , Stephen Hemminger , dpdk stable Subject: patch 'net/mvneta: fix possible out-of-bounds write' has been queued to stable release 22.11.7 Date: Tue, 12 Nov 2024 22:07:16 +0000 Message-ID: <20241112220754.666489-6-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20241112220754.666489-1-luca.boccassi@gmail.com> References: <20241023211704.1216956-79-luca.boccassi@gmail.com> <20241112220754.666489-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.7 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/14/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/b6454df58c5aef1eaa40d35d1ee1e098c307b613 Thanks. Luca Boccassi --- >From b6454df58c5aef1eaa40d35d1ee1e098c307b613 Mon Sep 17 00:00:00 2001 From: Chengwen Feng Date: Thu, 10 Oct 2024 00:53:26 +0000 Subject: [PATCH] net/mvneta: fix possible out-of-bounds write [ upstream commit c705c67d304b9450824a169b652520c2358c6aee ] The mvneta_ifnames_get() function will save 'iface' value to ifnames, it will out-of-bounds write if passed many iface pairs (e.g. 'iface=xxx,iface=xxx,...'). Fixes: 4ccc8d770d3b ("net/mvneta: add PMD skeleton") Signed-off-by: Chengwen Feng Acked-by: Ferruh Yigit Acked-by: Stephen Hemminger --- drivers/net/mvneta/mvneta_ethdev.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/net/mvneta/mvneta_ethdev.c b/drivers/net/mvneta/mvneta_ethdev.c index f281d1d7f8..6821f8e559 100644 --- a/drivers/net/mvneta/mvneta_ethdev.c +++ b/drivers/net/mvneta/mvneta_ethdev.c @@ -91,6 +91,12 @@ mvneta_ifnames_get(const char *key __rte_unused, const char *value, { struct mvneta_ifnames *ifnames = extra_args; + if (ifnames->idx >= NETA_NUM_ETH_PPIO) { + MVNETA_LOG(ERR, "Too many ifnames specified (max %u)", + NETA_NUM_ETH_PPIO); + return -EINVAL; + } + ifnames->names[ifnames->idx++] = value; return 0; -- 2.45.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-11-12 22:06:58.888440214 +0000 +++ 0006-net-mvneta-fix-possible-out-of-bounds-write.patch 2024-11-12 22:06:58.635306699 +0000 @@ -1 +1 @@ -From c705c67d304b9450824a169b652520c2358c6aee Mon Sep 17 00:00:00 2001 +From b6454df58c5aef1eaa40d35d1ee1e098c307b613 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit c705c67d304b9450824a169b652520c2358c6aee ] + @@ -11 +12,0 @@ -Cc: stable@dpdk.org @@ -21 +22 @@ -index 3841c1ebe9..f99f9e6289 100644 +index f281d1d7f8..6821f8e559 100644