From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F21A945DC2 for ; Thu, 28 Nov 2024 18:16:02 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E15F140A6E; Thu, 28 Nov 2024 18:16:02 +0100 (CET) Received: from mail-pj1-f51.google.com (mail-pj1-f51.google.com [209.85.216.51]) by mails.dpdk.org (Postfix) with ESMTP id 4DD9440670 for ; Thu, 28 Nov 2024 18:16:00 +0100 (CET) Received: by mail-pj1-f51.google.com with SMTP id 98e67ed59e1d1-2ea6f821decso842897a91.1 for ; Thu, 28 Nov 2024 09:16:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1732814159; x=1733418959; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=idgaIsXHaNhCD2aiP4MVqM7Fqq9P6OwSw5bulozKVmY=; b=c05Qw4JQoy+rg5UTWQNhJ/A36StHivNJSMlf4uPmskY4jDUe5CZZIus+egPR0073Ka fWpRlUubcPyISBf3JnVT3Vhv+4dOYiOQnaIO8bFUiac+fXXo8ICWAfHFfHVvb5AZy83F 2vC07R8sIPS/QLKBLkD0+CLo+e9F0tSxz76zH8fZNuKYtG5IEGOO+5DNeMMkWk3vcqvC Y5pc/TsW8thUTG7svxLkOVqj93G3oaAeqnnGNVn0wrB5bDJKzwZXZQUPFlB68SLDbEdL e0wgu9JzIRjfV15SXS09Z8EU4EmbDMEUpQ84BYKi1xbED/+iW/1+ZRHqs1X6CZ1jMP4x GqkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732814159; x=1733418959; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=idgaIsXHaNhCD2aiP4MVqM7Fqq9P6OwSw5bulozKVmY=; b=kRk1egitoFAjxpF3A02Sw3ztgtCZNY9/FF1NlraKd0p26pGR0XFBm6IRaIzidKMFgN wTf7k80yD8jod1mBRZCxq81B+6caaDmpdUqUj+r4CmFx35m7Uspt6dZF2Ss1Lnw8W6sK 0qJ4DvatFO0U1EhTjraYG0syVOWjgWiKbtcZV+zC+j5CQQdn2wlC1HOTFPU9ZTzvvnv/ D56Cj+6xe/0dljmhEgnVlsMk714UPp52jX5+7Sdjnc72WnioUZ3yY9KljLbIHYv0TSg6 wrTk8lKj2bxxDmiI8jqEMjIwciEY4RRNUA+EHsJ0XKgbUFr/dssaYaE1NJJjqaTbwcxQ QYkQ== X-Forwarded-Encrypted: i=1; AJvYcCXQ2SgK1/P1QuZt/i0/+VqT7lI2VdRV4+1P76mJR97w5mnzVpBZC0y80b2i/MPEqLDkHv16ysc=@dpdk.org X-Gm-Message-State: AOJu0Yy2SlZlcENJB8qXbEZyYcANzqcPilc9BDrCgOL8StfKil/HOTW1 B+bE2TpbAR0L+9rD1t3T7ZZhn8PqDxyP4p8tjU5KOlWl0SIvbqnb1i9YqfamYvY= X-Gm-Gg: ASbGncuA/FNhf7SuvI7/J4JYFg0CdupwhtK6Y4kWbXAbgDsUWe1N7aiYXWPH4EsA58W GRQPwz4KPaDUF5yK/oixNgnWJ3tqRBjdjrDpngM0vzVYsIi2rTqkwuvEJFip/5NMBdVo6D8Rf5e tqRFo1vYIavjz4TZh5CeMAKlA3hmxFC9p/3iufjmjrrGJEsoAHJUB1+u/PgpwIRryAlR7sSeCgo Rjfy37FyJ8+SQTSUms2SpNui5+olWSEvg04tAWLyknJidGF4EaMNHI0apd9WyxYv3D76M6guquF 0x8EHCqCQNHrgiSwmFRYieDivZQ= X-Google-Smtp-Source: AGHT+IHum4iIzpBFaqzplvQg3Sa1x/gydonz8D7mMIY368HCtm711LsA8C44bnEj/EPuUKzRF38enA== X-Received: by 2002:a17:90b:3849:b0:2ea:4e9e:df8c with SMTP id 98e67ed59e1d1-2ee08ed4468mr9265658a91.21.1732814159404; Thu, 28 Nov 2024 09:15:59 -0800 (PST) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2ee0fa68448sm3690229a91.31.2024.11.28.09.15.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Nov 2024 09:15:59 -0800 (PST) Date: Thu, 28 Nov 2024 09:15:52 -0800 From: Stephen Hemminger To: myang Cc: Anatoly Burakov , Bruce Richardson , Kevin Laatz , Morten =?UTF-8?B?QnLDuHJ1cA==?= , dev@dpdk.org, stable@dpdk.org Subject: Re: [PATCH] eal: fix bus cleanup in secondary process Message-ID: <20241128091552.2406f1a3@hermes.local> In-Reply-To: <20241128054829.1453-1-ming.1.yang@nokia-sbell.com> References: <20241128054829.1453-1-ming.1.yang@nokia-sbell.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On Thu, 28 Nov 2024 13:48:29 +0800 myang wrote: > eal_bus_cleanup has been added in rte_eal_cleanup. But for > secondary process, eal_bus_cleanup will trigger vdev_cleanup > which trigger rte_vdev_driver to remove. Then our crypto devices > will execute ipsec_mb_remove to rte_cryptodev_pmd_destroy. > > Finally error logs occur as below: > CRYPTODEV: rte_cryptodev_close() line 1453: Device 0 must be > stopped before closing > EAL: failed to send to (/tmp/dpdk/l2hicu/mp_socket) due to Bad > file descriptor > EAL: Fail to send request /tmp/dpdk/l2hicu/mp_socket:ipsec_mb_mp_msg > USER1: Create MR request to primary process failed. > > Function call trace: rte_eal_cleanup->eal_bus_cleanup-> > vdev_cleanup->rte_vdev_driver->ipsec_mb_remove-> > 1. ipsec_mb_remove->rte_cryptodev_pmd_destroy-> > rte_cryptodev_pmd_release_device->rte_cryptodev_close > 2. ipsec_mb_remove->ipsec_mb_qp_release->ipsec_mb_secondary_qp_op > ->rte_mp_request_async->mp_request_async > > Fixes: 1cab1a40ea9b ("bus: cleanup devices on shutdown") > Cc: stable@dpdk.org > > Signed-off-by: myang There is was a reason for calling cleanup on shutdown. It looks like more of a bug in the crypto device not the EAL. Freebsd and Windows also calls eal_bus_cleanup.