From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 59ABB45E41 for ; Sat, 7 Dec 2024 09:03:25 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4E36F40281; Sat, 7 Dec 2024 09:03:25 +0100 (CET) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2056.outbound.protection.outlook.com [40.107.94.56]) by mails.dpdk.org (Postfix) with ESMTP id 1DAA640281 for ; Sat, 7 Dec 2024 09:03:24 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=nVHudKzvG9UEVtqjxPKp3Ua/gcB7x/l8cWo9mch3NT9yRBtbF+L5/b2qzZlNsCHHIK3exEgawCWkHmaM47UsMQo8TkPKsdn71AyeMkO1whorGOwOGFJAZdK3bYwb9PcVhBl5icIaDlIV0WIY9PvkL/np4ge2gXi0VIxSWbSGUzQjsMjwhQVbm8WGbD4RbspQz5FCe5U4F+/9iXCW6aFvu1JpCgooYEi9zCZcHeOTpgHfUWVWKj91wHPyWxUvSB4wBJV1QPnBSAWd69yryh2iy0VMtb6I/4HEVObKMvTFIxc6lNT0e2mh7q7WUIe56VKZdVgMx5Wq7Z/a+vm/UBerfw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=m+Dfnivo9PlM3RrL7mWZ2fpFOpmRK8t/mrJnx+kyAqo=; b=ytHM1cUyAtdAG5ysEuzdtkPOncQY7QRoR26toB/gA9tRmAPwBuHrqHdb+Ig929SOWndZgtMsdwe69Nh2TiwtT2owyC4hGoPQOkzkJ+4x49lFodM5HklNsC92UE5/V5IdCeZp84FpC1jYay4x1oxx66cwuZ/hpatFhhgGa78FQ2Ho7eFSMNgHGp+QMYkRva9iyZ0O7C4/iDMOisrwtUkvE2CwEnIEDS8thPms8gVR4/mI6NOUjmUtcknoOPoxBQkng9m6xUK3ENBoJ2TbYPpv7iECHVGpJ4a/+VOMWH9PUO4o1pEL3HEX9EX+jeBp+nbtxLyOEIA32t+ez4Rf55y1og== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=intel.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=m+Dfnivo9PlM3RrL7mWZ2fpFOpmRK8t/mrJnx+kyAqo=; b=t/o+r704nh6T68J8C6QBglwxR6RaqjF43Qd13CVHAytcEL+5cFSbCBp01sUKACNK3bkuX35bvUuMblfKCCiOjPWOFMkZWiq0YLa32Dr8a0exDBvF6kJpfwFVLjUUtfPC361eYrooTCNTpi5YYadPcFO9JfuC6pT9qBY9vadmBTkobefsv11/3NvS6AXLKCXG+v6YggIthjJ96ULqAVpslcf+3deU9DskOnU6DVMZz+3ckDmZuW1ubCy+wGaanCDFjgDIMW1mM4Mq5lZx+onZAuO6DPC4lD5r3bIpKDvvSTQhOWLd2kk5KQeLY8qssiTu0uTE8GjM7Z18Dyq8mAlXPw== Received: from PH8PR05CA0014.namprd05.prod.outlook.com (2603:10b6:510:2cc::7) by IA1PR12MB6387.namprd12.prod.outlook.com (2603:10b6:208:389::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8207.18; Sat, 7 Dec 2024 08:03:20 +0000 Received: from CY4PEPF0000E9DC.namprd05.prod.outlook.com (2603:10b6:510:2cc:cafe::12) by PH8PR05CA0014.outlook.office365.com (2603:10b6:510:2cc::7) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8230.10 via Frontend Transport; Sat, 7 Dec 2024 08:03:19 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by CY4PEPF0000E9DC.mail.protection.outlook.com (10.167.241.75) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8230.7 via Frontend Transport; Sat, 7 Dec 2024 08:03:19 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Sat, 7 Dec 2024 00:03:08 -0800 Received: from nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Sat, 7 Dec 2024 00:03:07 -0800 From: Xueming Li To: Bruce Richardson CC: Xueming Li , Stephen Hemminger , dpdk stable Subject: patch 'app/dumpcap: remove unused struct array' has been queued to stable release 23.11.3 Date: Sat, 7 Dec 2024 15:59:39 +0800 Message-ID: <20241207080055.488538-22-xuemingl@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20241207080055.488538-1-xuemingl@nvidia.com> References: <20241111062847.216344-122-xuemingl@nvidia.com> <20241207080055.488538-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.231.35] X-ClientProxiedBy: rnnvmail201.nvidia.com (10.129.68.8) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000E9DC:EE_|IA1PR12MB6387:EE_ X-MS-Office365-Filtering-Correlation-Id: 242c65a1-64eb-4279-27fa-08dd16959cc7 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|1800799024|376014|36860700013|82310400026|7053199007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?UdD04uUYItIpXylDd15XYk4tg/Tli654t18IEaQ5JmKnD2adZKDL/9XOzQXr?= =?us-ascii?Q?Hy/CcREDDlzDK2uY4Vn6o5KPPWJXg6Nc2ywulNsyg9G+3+JDICmsjmh73A6W?= =?us-ascii?Q?9atNEInGRd2H2cqdJIRBkH39gYPnS4Y5EAE+yfsQK2uaKaQikgYJg00/7FS1?= =?us-ascii?Q?EoKD7vYrBFF03XvZYAOBmxiAd59V6PD5kV5smjOmJUnAmvssAyEtz4NDXwNT?= =?us-ascii?Q?06i5WnUo5S7FT2XYSpM3IkdojGsGmy7XPs61ZupfI3ahuki3u+eAL2v4OvAA?= =?us-ascii?Q?ARdfoap60Ky4L2XBjWXbFj056FcEnbSt8h3JkXePBgCMrVRvLQhbAz4z3B+W?= =?us-ascii?Q?DE8lvNbkrTmXOqhkepLSFKsBAj5hEeu1GlL4driIE3VQTElC4LWeHce+L+Ph?= =?us-ascii?Q?FsNULgIt/vjGD/GMSu9J+3+IrRB8+Ks/jMzcoIRFqi2WZ8Kcs0GavdStSEjq?= =?us-ascii?Q?QsdzLR8SY2hRUuPKYzY0JsgnXruAhvIXHGKhtgexBFTvGKUrR7745w3LZrKz?= =?us-ascii?Q?ZsK3EyXOdyTvnryyqcJhzoq64jOWryysRA3BnJdFq8IFlo9SR3ARUbH44Th6?= =?us-ascii?Q?EYRYVuI2U+Q08/eaaD7HZToFu0ABKpyiS+2QwvMZuqtacfchiQO1NLXppqh0?= =?us-ascii?Q?Mx62YtdLoMSJieLFvXE2Slx8xuRJMeJBJUjOsEh1o7ilKTc8V8jwbIiiSKGC?= =?us-ascii?Q?AtBsIAgFt3rDRNRHWlJy5mJ8e1XhWzJCe8xNXrNRzBnYPlDGEdsv3DCZp12n?= =?us-ascii?Q?KZIF2s+VaV4gnxOJWkECgrpVuLTulbMOOau/4/o8cCu5lM7txd/UBiPc666W?= =?us-ascii?Q?tZ2F3Hr7tqB/9ofMJ0p4I3rtvdEjLJ6LFtHztNd1Kt3jGgqRjY3PhTToqfmk?= =?us-ascii?Q?omZZAMYhXyETwLhJ0X0UVSnSdzjsmSU7HZOQw/FstGczvaKyeEmmZ0ccvcjy?= =?us-ascii?Q?HXIKemddnNK5I+o3Z9KalEtPV/VuY3cqZ56RUgTOnqb71bbPUATuXJEOYew2?= =?us-ascii?Q?l0tRI18BYLcvbCSTHP1u6HVXLs5qZURLkG6lzF+dOM/Rycd+WXKZTZWBowrA?= =?us-ascii?Q?XY8Reqvfr5RW3S5HuUlLRyeBpOriP8+7MFYwpT+EgP7ydIBsF99I9AsVTZZY?= =?us-ascii?Q?0tfABo6V+JtYUm/eXud00h6794JRBh3mP2MbKDc2ofbYlZnKa1lIxG/JowdW?= =?us-ascii?Q?aQKf63FJZ9Vw5fjdRECmh/2hHfnomUIvQQAuomkhdTJChCMXY2gtCJKjWZCU?= =?us-ascii?Q?DQMcRvz/9YWt7iYNQTppUhdnxAJ0jv6A8VlpDVUBdMHvQtqTaYQWMwpPi4cG?= =?us-ascii?Q?4t+Nf9IgkQaCsRELuRuB1wNK9ZjxFmp1mccyvnY/1B4Ug/GMtO7jGl9WDCd5?= =?us-ascii?Q?UN0xZobXRCotQS7hRzjkkOXc3kn1m13xoCdZTkGmvDCKoJsCKzgsgRoBE6mH?= =?us-ascii?Q?KqBrRan92ld/Wg0yzApeLqynly32Ouy6?= X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230040)(1800799024)(376014)(36860700013)(82310400026)(7053199007); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Dec 2024 08:03:19.1620 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 242c65a1-64eb-4279-27fa-08dd16959cc7 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000E9DC.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB6387 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 23.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 12/10/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=23.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=23.11-staging&id=58645a6a0fd9f6888b8dfbd2c0a552daf9b70011 Thanks. Xueming Li --- >From 58645a6a0fd9f6888b8dfbd2c0a552daf9b70011 Mon Sep 17 00:00:00 2001 From: Bruce Richardson Date: Tue, 5 Nov 2024 11:27:21 +0000 Subject: [PATCH] app/dumpcap: remove unused struct array Cc: Xueming Li [ upstream commit 9bbd44d63846cf0771ec0f1c7e1b5a63ec5e9603 ] The callbacks(rx_cb) member of struct interface was unused inside dumpcap, but was taking up a lot of memory space, since it was scaled according to RTE_MAX_QUEUES_PER_PORT, which is 1k by default. Save memory by removing the whole array. Fixes: cbb44143be74 ("app/dumpcap: add new packet capture application") Suggested-by: Stephen Hemminger Signed-off-by: Bruce Richardson Acked-by: Stephen Hemminger --- app/dumpcap/main.c | 1 - 1 file changed, 1 deletion(-) diff --git a/app/dumpcap/main.c b/app/dumpcap/main.c index 213e764c2e..5eaab6350f 100644 --- a/app/dumpcap/main.c +++ b/app/dumpcap/main.c @@ -93,7 +93,6 @@ struct interface { struct rte_bpf_prm *bpf_prm; char name[RTE_ETH_NAME_MAX_LEN]; - struct rte_rxtx_callback *rx_cb[RTE_MAX_QUEUES_PER_PORT]; const char *ifname; const char *ifdescr; }; -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-12-06 23:26:44.855842618 +0800 +++ 0021-app-dumpcap-remove-unused-struct-array.patch 2024-12-06 23:26:43.903044828 +0800 @@ -1 +1 @@ -From 9bbd44d63846cf0771ec0f1c7e1b5a63ec5e9603 Mon Sep 17 00:00:00 2001 +From 58645a6a0fd9f6888b8dfbd2c0a552daf9b70011 Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit 9bbd44d63846cf0771ec0f1c7e1b5a63ec5e9603 ] @@ -12 +14,0 @@ -Cc: stable@dpdk.org @@ -22 +24 @@ -index 4031f48441..3d3c0dbc66 100644 +index 213e764c2e..5eaab6350f 100644 @@ -25 +27 @@ -@@ -96,7 +96,6 @@ struct interface { +@@ -93,7 +93,6 @@ struct interface {